You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/05/04 16:26:21 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6016: NIFI-9984 Allow 200-series responses in OAuth2 Access Token Provider

exceptionfactory opened a new pull request, #6016:
URL: https://github.com/apache/nifi/pull/6016

   # Summary
   
   [NIFI-9984](https://issues.apache.org/jira/browse/NIFI-9984) Updates the `StandardOauth2AccessTokenProvider` to allow processing all 200-series HTTP responses as successful.
   
   The update changes from checking if the response code equals to 200 to calling [Response.isSuccessful()](https://square.github.io/okhttp/4.x/okhttp/okhttp3/-response/is-successful/), which allows all 200-series response codes.
   
   [RFC 6749 Section 5.1](https://www.rfc-editor.org/rfc/rfc6749#section-5.1) describes a successful response with an HTTP 200 response code, but some OAuth2 providers, such as [IBM Cloud Pak](https://www.ibm.com/docs/en/dbaoc?topic=applications-using-oauth-20-based-authentication) return HTTP 201. Making adjustments to support other successful HTTP response codes enables compatibility with a wider array of OAuth2 providers.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nifi] asfgit closed pull request #6016: NIFI-9984 Allow 200-series responses in OAuth2 Access Token Provider

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #6016: NIFI-9984 Allow 200-series responses in OAuth2 Access Token Provider
URL: https://github.com/apache/nifi/pull/6016


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org