You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/22 06:21:30 UTC
[GitHub] [rocketmq-mqtt] codecov-commenter commented on pull request #79: Define a subscription storage interface
codecov-commenter commented on PR #79:
URL: https://github.com/apache/rocketmq-mqtt/pull/79#issuecomment-1106052187
# [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/79?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#79](https://codecov.io/gh/apache/rocketmq-mqtt/pull/79?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5181549) into [main](https://codecov.io/gh/apache/rocketmq-mqtt/commit/344cb70dafd074b60e18e48fe63a436005c0339b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (344cb70) will **increase** coverage by `0.77%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head 5181549 differs from pull request most recent head 0c16e03. Consider uploading reports for the commit 0c16e03 to get more accurate results
```diff
@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 30.35% 31.13% +0.77%
==========================================
Files 97 98 +1
Lines 4191 4237 +46
Branches 661 671 +10
==========================================
+ Hits 1272 1319 +47
+ Misses 2676 2666 -10
- Partials 243 252 +9
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-mqtt/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/rocketmq/mqtt/common/util/SpringUtils.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/79/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL21xdHQvY29tbW9uL3V0aWwvU3ByaW5nVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...a/org/apache/rocketmq/mqtt/cs/starter/Startup.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/79/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9zdGFydGVyL1N0YXJ0dXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...rocketmq/mqtt/cs/session/loop/SessionLoopImpl.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/79/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9zZXNzaW9uL2xvb3AvU2Vzc2lvbkxvb3BJbXBsLmphdmE=) | `44.85% <50.00%> (+0.37%)` | :arrow_up: |
| [...tt/ds/upstream/processor/UnSubscribeProcessor.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/79/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy91cHN0cmVhbS9wcm9jZXNzb3IvVW5TdWJzY3JpYmVQcm9jZXNzb3IuamF2YQ==) | `76.47% <66.66%> (+76.47%)` | :arrow_up: |
| [...mqtt/ds/upstream/processor/SubscribeProcessor.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/79/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy91cHN0cmVhbS9wcm9jZXNzb3IvU3Vic2NyaWJlUHJvY2Vzc29yLmphdmE=) | `84.21% <70.00%> (+84.21%)` | :arrow_up: |
| [...a/org/apache/rocketmq/mqtt/cs/session/Session.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/79/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9zZXNzaW9uL1Nlc3Npb24uamF2YQ==) | `39.84% <0.00%> (+2.68%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/79?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/79?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [344cb70...0c16e03](https://codecov.io/gh/apache/rocketmq-mqtt/pull/79?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org