You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Barna Zsombor Klara <zs...@cloudera.com> on 2017/06/12 15:31:55 UTC
Review Request 60006: HIVE-14746: Remove branch and repositories from
profiles by sending them from ptest-client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60006/
-----------------------------------------------------------
Review request for hive, Sergio Pena and Siddharth Seth.
Bugs: HIVE-14746
https://issues.apache.org/jira/browse/HIVE-14746
Repository: hive-git
Description
-------
HIVE-14746: Remove branch and repositories from profiles by sending them from ptest-client
Diffs
-----
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java 8e2604d372ac29b94445b269f08423b058308efe
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/request/TestStartRequest.java 8deed52ae0307d4fc075654a4d75e6cb09a5d9db
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java b2c61f03c5bf5f170894141848c89fc26129115a
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 1cdfdb309acd8282e593abd7ed10c87721926c60
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/CloudExecutionContextProvider.java 8b82497bdaf43694e0e1552e125b5ffdce40f56c
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/ExecutionContext.java b09de1d4d930cf2d4d26b500f3457cea3fffa9ce
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/FixedExecutionContextProvider.java f7b50d6a61962d2727b5181215be9de2e64b05b7
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/WorkingDirWrapper.java PRE-CREATION
testutils/ptest2/src/test/java/org/apache/hive/ptest/api/server/TestTestExecutor.java a4a789b579305d9ed573d8c1fd0b6ce75787d50f
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java 848faf27af1ed8945d7013b6562bab544605e4bc
Diff: https://reviews.apache.org/r/60006/diff/1/
Testing
-------
Manually tested the PTestClient with and without the branch argument.
Updated and ran the unit tests.
Thanks,
Barna Zsombor Klara
Re: Review Request 60006: HIVE-14746: Remove branch and repositories
from profiles by sending them from ptest-client
Posted by Sergio Pena <se...@cloudera.com>.
> On June 14, 2017, 4:03 p.m., Sergio Pena wrote:
> > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java
> > Lines 108 (patched)
> > <https://reviews.apache.org/r/60006/diff/2/?file=1749730#file1749730line108>
> >
> > Why is a workingDirectoryWrapper needed?
> >
> > Currently, Ptest works on a 'working' directory for any branch detected on the profile. Why do we want to change that for different branches?
>
> Barna Zsombor Klara wrote:
> I did this based on Siddharth Seth's comments on the Jira, where he mentioned that associating the working dir with the branch could prevent frequent rebasing when the checkout occurs. We don't need it for the original intent of the Jira. We can discuss if we want it or if the rebase would not be that problematic.
It's a good time savings. However, it's done only once. I don't know how much time we do save. Anyway, can we have this as a follow up jira?
- Sergio
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60006/#review177910
-----------------------------------------------------------
On June 13, 2017, 2:28 p.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60006/
> -----------------------------------------------------------
>
> (Updated June 13, 2017, 2:28 p.m.)
>
>
> Review request for hive, Sergio Pena and Siddharth Seth.
>
>
> Bugs: HIVE-14746
> https://issues.apache.org/jira/browse/HIVE-14746
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14746: Remove branch and repositories from profiles by sending them from ptest-client
>
>
> Diffs
> -----
>
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java 8e2604d372ac29b94445b269f08423b058308efe
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/request/TestStartRequest.java 8deed52ae0307d4fc075654a4d75e6cb09a5d9db
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java b2c61f03c5bf5f170894141848c89fc26129115a
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 1cdfdb309acd8282e593abd7ed10c87721926c60
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/CloudExecutionContextProvider.java 8b82497bdaf43694e0e1552e125b5ffdce40f56c
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/ExecutionContext.java b09de1d4d930cf2d4d26b500f3457cea3fffa9ce
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/FixedExecutionContextProvider.java f7b50d6a61962d2727b5181215be9de2e64b05b7
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/WorkingDirWrapper.java PRE-CREATION
> testutils/ptest2/src/test/java/org/apache/hive/ptest/api/server/TestTestExecutor.java a4a789b579305d9ed573d8c1fd0b6ce75787d50f
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java 848faf27af1ed8945d7013b6562bab544605e4bc
>
>
> Diff: https://reviews.apache.org/r/60006/diff/2/
>
>
> Testing
> -------
>
> Manually tested the PTestClient with and without the branch argument.
> Updated and ran the unit tests.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>
Re: Review Request 60006: HIVE-14746: Remove branch and repositories
from profiles by sending them from ptest-client
Posted by Barna Zsombor Klara <zs...@cloudera.com>.
> On June 14, 2017, 4:03 p.m., Sergio Pena wrote:
> > testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java
> > Line 322 (original), 324 (patched)
> > <https://reviews.apache.org/r/60006/diff/2/?file=1749727#file1749727line324>
> >
> > Should we check that BRANCH is not empty before starting the test?
> >
> > Is this a required argument or optional?
> >
> > If it is optional, what branch will use as default? We're removing the branch option from the profiles, so this will not exist.
Based on the scripts and the properties it seems like PTest also supports SVN as the SCM system alongside Git, but there branch is a not supported parameter. If we want to keep the compatibility with SVN then we cannot make branch mandatory (since at this point we don't know the SCM type in the PTestClient).
> On June 14, 2017, 4:03 p.m., Sergio Pena wrote:
> > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java
> > Lines 108 (patched)
> > <https://reviews.apache.org/r/60006/diff/2/?file=1749730#file1749730line108>
> >
> > Why is a workingDirectoryWrapper needed?
> >
> > Currently, Ptest works on a 'working' directory for any branch detected on the profile. Why do we want to change that for different branches?
I did this based on Siddharth Seth's comments on the Jira, where he mentioned that associating the working dir with the branch could prevent frequent rebasing when the checkout occurs. We don't need it for the original intent of the Jira. We can discuss if we want it or if the rebase would not be that problematic.
- Barna Zsombor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60006/#review177910
-----------------------------------------------------------
On June 13, 2017, 2:28 p.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60006/
> -----------------------------------------------------------
>
> (Updated June 13, 2017, 2:28 p.m.)
>
>
> Review request for hive, Sergio Pena and Siddharth Seth.
>
>
> Bugs: HIVE-14746
> https://issues.apache.org/jira/browse/HIVE-14746
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14746: Remove branch and repositories from profiles by sending them from ptest-client
>
>
> Diffs
> -----
>
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java 8e2604d372ac29b94445b269f08423b058308efe
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/request/TestStartRequest.java 8deed52ae0307d4fc075654a4d75e6cb09a5d9db
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java b2c61f03c5bf5f170894141848c89fc26129115a
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 1cdfdb309acd8282e593abd7ed10c87721926c60
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/CloudExecutionContextProvider.java 8b82497bdaf43694e0e1552e125b5ffdce40f56c
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/ExecutionContext.java b09de1d4d930cf2d4d26b500f3457cea3fffa9ce
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/FixedExecutionContextProvider.java f7b50d6a61962d2727b5181215be9de2e64b05b7
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/WorkingDirWrapper.java PRE-CREATION
> testutils/ptest2/src/test/java/org/apache/hive/ptest/api/server/TestTestExecutor.java a4a789b579305d9ed573d8c1fd0b6ce75787d50f
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java 848faf27af1ed8945d7013b6562bab544605e4bc
>
>
> Diff: https://reviews.apache.org/r/60006/diff/2/
>
>
> Testing
> -------
>
> Manually tested the PTestClient with and without the branch argument.
> Updated and ran the unit tests.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>
Re: Review Request 60006: HIVE-14746: Remove branch and repositories
from profiles by sending them from ptest-client
Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60006/#review177910
-----------------------------------------------------------
Thank you so much Zsombor for working on this patch. This is going to help us alot on running patches on newer branches without manual interaction to create a new profile.
There's still some work to do, but I'm glad we're starting to have progress on this.
Btw, looking at the code, I think you need to edit jenkins-execute-build.sh to send the branch name?
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java
Line 322 (original), 324 (patched)
<https://reviews.apache.org/r/60006/#comment251613>
Should we check that BRANCH is not empty before starting the test?
Is this a required argument or optional?
If it is optional, what branch will use as default? We're removing the branch option from the profiles, so this will not exist.
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java
Lines 108 (patched)
<https://reviews.apache.org/r/60006/#comment251614>
Why is a workingDirectoryWrapper needed?
Currently, Ptest works on a 'working' directory for any branch detected on the profile. Why do we want to change that for different branches?
- Sergio Pena
On June 13, 2017, 2:28 p.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60006/
> -----------------------------------------------------------
>
> (Updated June 13, 2017, 2:28 p.m.)
>
>
> Review request for hive, Sergio Pena and Siddharth Seth.
>
>
> Bugs: HIVE-14746
> https://issues.apache.org/jira/browse/HIVE-14746
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14746: Remove branch and repositories from profiles by sending them from ptest-client
>
>
> Diffs
> -----
>
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java 8e2604d372ac29b94445b269f08423b058308efe
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/request/TestStartRequest.java 8deed52ae0307d4fc075654a4d75e6cb09a5d9db
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java b2c61f03c5bf5f170894141848c89fc26129115a
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 1cdfdb309acd8282e593abd7ed10c87721926c60
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/CloudExecutionContextProvider.java 8b82497bdaf43694e0e1552e125b5ffdce40f56c
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/ExecutionContext.java b09de1d4d930cf2d4d26b500f3457cea3fffa9ce
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/FixedExecutionContextProvider.java f7b50d6a61962d2727b5181215be9de2e64b05b7
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/WorkingDirWrapper.java PRE-CREATION
> testutils/ptest2/src/test/java/org/apache/hive/ptest/api/server/TestTestExecutor.java a4a789b579305d9ed573d8c1fd0b6ce75787d50f
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java 848faf27af1ed8945d7013b6562bab544605e4bc
>
>
> Diff: https://reviews.apache.org/r/60006/diff/2/
>
>
> Testing
> -------
>
> Manually tested the PTestClient with and without the branch argument.
> Updated and ran the unit tests.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>
Re: Review Request 60006: HIVE-14746: Remove branch and repositories
from profiles by sending them from ptest-client
Posted by Barna Zsombor Klara <zs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60006/
-----------------------------------------------------------
(Updated June 13, 2017, 2:28 p.m.)
Review request for hive, Sergio Pena and Siddharth Seth.
Changes
-------
Updated based on Peter's comments. Thank you!
Bugs: HIVE-14746
https://issues.apache.org/jira/browse/HIVE-14746
Repository: hive-git
Description
-------
HIVE-14746: Remove branch and repositories from profiles by sending them from ptest-client
Diffs (updated)
-----
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java 8e2604d372ac29b94445b269f08423b058308efe
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/request/TestStartRequest.java 8deed52ae0307d4fc075654a4d75e6cb09a5d9db
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java b2c61f03c5bf5f170894141848c89fc26129115a
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 1cdfdb309acd8282e593abd7ed10c87721926c60
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/CloudExecutionContextProvider.java 8b82497bdaf43694e0e1552e125b5ffdce40f56c
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/ExecutionContext.java b09de1d4d930cf2d4d26b500f3457cea3fffa9ce
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/FixedExecutionContextProvider.java f7b50d6a61962d2727b5181215be9de2e64b05b7
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/WorkingDirWrapper.java PRE-CREATION
testutils/ptest2/src/test/java/org/apache/hive/ptest/api/server/TestTestExecutor.java a4a789b579305d9ed573d8c1fd0b6ce75787d50f
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java 848faf27af1ed8945d7013b6562bab544605e4bc
Diff: https://reviews.apache.org/r/60006/diff/2/
Changes: https://reviews.apache.org/r/60006/diff/1-2/
Testing
-------
Manually tested the PTestClient with and without the branch argument.
Updated and ran the unit tests.
Thanks,
Barna Zsombor Klara
Re: Review Request 60006: HIVE-14746: Remove branch and repositories
from profiles by sending them from ptest-client
Posted by Peter Vary <pv...@cloudera.com>.
> On June 13, 2017, 10:21 a.m., Peter Vary wrote:
> > testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java
> > Lines 118-120 (patched)
> > <https://reviews.apache.org/r/60006/diff/1/?file=1748269#file1748269line118>
> >
> > Is it possible to have a request without branch? Should not we use a default for this so we have a cleaner directory layout?
>
> Barna Zsombor Klara wrote:
> PTest can technically work with svn as well not just git, and the branch parameter is not supported for it. So always having a sensible default is a bit difficult.
That makes sense. Thanks for pointing this out!
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60006/#review177720
-----------------------------------------------------------
On June 13, 2017, 2:28 p.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60006/
> -----------------------------------------------------------
>
> (Updated June 13, 2017, 2:28 p.m.)
>
>
> Review request for hive, Sergio Pena and Siddharth Seth.
>
>
> Bugs: HIVE-14746
> https://issues.apache.org/jira/browse/HIVE-14746
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14746: Remove branch and repositories from profiles by sending them from ptest-client
>
>
> Diffs
> -----
>
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java 8e2604d372ac29b94445b269f08423b058308efe
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/request/TestStartRequest.java 8deed52ae0307d4fc075654a4d75e6cb09a5d9db
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java b2c61f03c5bf5f170894141848c89fc26129115a
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 1cdfdb309acd8282e593abd7ed10c87721926c60
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/CloudExecutionContextProvider.java 8b82497bdaf43694e0e1552e125b5ffdce40f56c
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/ExecutionContext.java b09de1d4d930cf2d4d26b500f3457cea3fffa9ce
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/FixedExecutionContextProvider.java f7b50d6a61962d2727b5181215be9de2e64b05b7
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/WorkingDirWrapper.java PRE-CREATION
> testutils/ptest2/src/test/java/org/apache/hive/ptest/api/server/TestTestExecutor.java a4a789b579305d9ed573d8c1fd0b6ce75787d50f
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java 848faf27af1ed8945d7013b6562bab544605e4bc
>
>
> Diff: https://reviews.apache.org/r/60006/diff/2/
>
>
> Testing
> -------
>
> Manually tested the PTestClient with and without the branch argument.
> Updated and ran the unit tests.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>
Re: Review Request 60006: HIVE-14746: Remove branch and repositories
from profiles by sending them from ptest-client
Posted by Barna Zsombor Klara <zs...@cloudera.com>.
> On June 13, 2017, 10:21 a.m., Peter Vary wrote:
> > testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java
> > Lines 118-120 (patched)
> > <https://reviews.apache.org/r/60006/diff/1/?file=1748269#file1748269line118>
> >
> > Is it possible to have a request without branch? Should not we use a default for this so we have a cleaner directory layout?
PTest can technically work with svn as well not just git, and the branch parameter is not supported for it. So always having a sensible default is a bit difficult.
- Barna Zsombor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60006/#review177720
-----------------------------------------------------------
On June 13, 2017, 2:28 p.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60006/
> -----------------------------------------------------------
>
> (Updated June 13, 2017, 2:28 p.m.)
>
>
> Review request for hive, Sergio Pena and Siddharth Seth.
>
>
> Bugs: HIVE-14746
> https://issues.apache.org/jira/browse/HIVE-14746
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14746: Remove branch and repositories from profiles by sending them from ptest-client
>
>
> Diffs
> -----
>
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java 8e2604d372ac29b94445b269f08423b058308efe
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/request/TestStartRequest.java 8deed52ae0307d4fc075654a4d75e6cb09a5d9db
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java b2c61f03c5bf5f170894141848c89fc26129115a
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 1cdfdb309acd8282e593abd7ed10c87721926c60
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/CloudExecutionContextProvider.java 8b82497bdaf43694e0e1552e125b5ffdce40f56c
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/ExecutionContext.java b09de1d4d930cf2d4d26b500f3457cea3fffa9ce
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/FixedExecutionContextProvider.java f7b50d6a61962d2727b5181215be9de2e64b05b7
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/WorkingDirWrapper.java PRE-CREATION
> testutils/ptest2/src/test/java/org/apache/hive/ptest/api/server/TestTestExecutor.java a4a789b579305d9ed573d8c1fd0b6ce75787d50f
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java 848faf27af1ed8945d7013b6562bab544605e4bc
>
>
> Diff: https://reviews.apache.org/r/60006/diff/2/
>
>
> Testing
> -------
>
> Manually tested the PTestClient with and without the branch argument.
> Updated and ran the unit tests.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>
Re: Review Request 60006: HIVE-14746: Remove branch and repositories
from profiles by sending them from ptest-client
Posted by Peter Vary <pv...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60006/#review177720
-----------------------------------------------------------
Thanks for the patch Zsombor!
It would be nice to have automatic testing for new branches without extra configuration work!
Just minor questions.
Thanks for your work!
Peter
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java
Lines 118-120 (patched)
<https://reviews.apache.org/r/60006/#comment251444>
Is it possible to have a request without branch? Should not we use a default for this so we have a cleaner directory layout?
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java
Lines 107 (patched)
<https://reviews.apache.org/r/60006/#comment251442>
We might be able to used File object here. What do you think?
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/WorkingDirWrapper.java
Lines 49 (patched)
<https://reviews.apache.org/r/60006/#comment251440>
It might be useful to use File objects instead of the path string. What do you think?
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/WorkingDirWrapper.java
Lines 59 (patched)
<https://reviews.apache.org/r/60006/#comment251441>
We do not use this method. Do we need it?
- Peter Vary
On June 12, 2017, 3:31 p.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60006/
> -----------------------------------------------------------
>
> (Updated June 12, 2017, 3:31 p.m.)
>
>
> Review request for hive, Sergio Pena and Siddharth Seth.
>
>
> Bugs: HIVE-14746
> https://issues.apache.org/jira/browse/HIVE-14746
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14746: Remove branch and repositories from profiles by sending them from ptest-client
>
>
> Diffs
> -----
>
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java 8e2604d372ac29b94445b269f08423b058308efe
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/request/TestStartRequest.java 8deed52ae0307d4fc075654a4d75e6cb09a5d9db
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java b2c61f03c5bf5f170894141848c89fc26129115a
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 1cdfdb309acd8282e593abd7ed10c87721926c60
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/CloudExecutionContextProvider.java 8b82497bdaf43694e0e1552e125b5ffdce40f56c
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/ExecutionContext.java b09de1d4d930cf2d4d26b500f3457cea3fffa9ce
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/FixedExecutionContextProvider.java f7b50d6a61962d2727b5181215be9de2e64b05b7
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/WorkingDirWrapper.java PRE-CREATION
> testutils/ptest2/src/test/java/org/apache/hive/ptest/api/server/TestTestExecutor.java a4a789b579305d9ed573d8c1fd0b6ce75787d50f
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java 848faf27af1ed8945d7013b6562bab544605e4bc
>
>
> Diff: https://reviews.apache.org/r/60006/diff/1/
>
>
> Testing
> -------
>
> Manually tested the PTestClient with and without the branch argument.
> Updated and ran the unit tests.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>