[GitHub] [pulsar] merlimat commented on pull request #7054: Add properties for managed-ledger.

[GitBox <gi...@apache.org>]

merlimat commented on pull request #7054:
URL: https://github.com/apache/pulsar/pull/7054#issuecomment-637843729


   @codelipenghui @jiazhai There are multiple problems with this PR
   
    1.  It's not checking that there no other metadata operations in place. That will result in ZK bad version errors.
    2. It's writing the metadata without updating the in-memory version that the managed ledger keeps. This will result in a managed ledger fenced error each time a property is set, forcing the topic to get closed. 
    3. Why do we need to re-read the metadata from store? We already have that metadata and its corresponding version in memory.
   
   Finally, from the API is not clear what happens if there are already some properties and I just want to add a new one. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org