[GitHub] [hbase] ndimiduk commented on a change in pull request #2268: HBASE-24874 Fix hbase-shell access to ModifiableTableDescriptor methods

[GitBox <gi...@apache.org>]

ndimiduk commented on a change in pull request #2268:
URL: https://github.com/apache/hbase/pull/2268#discussion_r471764312



##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -664,6 +668,40 @@ def alter_status(table_name)
       puts 'Done.'
     end
 
+    #----------------------------------------------------------------------------------------------
+    # Use our internal logic to convert from "spec string" format to a coprocessor descriptor
+    #
+    # Provided for backwards shell compatibility
+    #
+    # @param [String] spec_str
+    # @return [ColumnDescriptor]
+    def coprocessor_descriptor_from_spec_str(spec_str)

Review comment:
       If you want to do this, please place a fat warning in the docs over on the `TableDescriptorBuilder.toCoprocessorDescriptor` method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org