You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/05 06:28:27 UTC
[GitHub] [airflow] potiuk opened a new pull request #17432: Fixes some static check errors
potiuk opened a new pull request #17432:
URL: https://github.com/apache/airflow/pull/17432
Disabling pre-commit even for a while and usin GitHub to
edit .rst files can have disastrous consequences for the static checks.
This one fixes my own mistakes from 3 PRs (!) after being far too
hasty in adding/merging them.
Will do better next time.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17432: Fixes some static check errors
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17432:
URL: https://github.com/apache/airflow/pull/17432#issuecomment-893207042
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17432: Fixes some static check errors
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17432:
URL: https://github.com/apache/airflow/pull/17432#issuecomment-893207042
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17432: Fixes some static check errors
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17432:
URL: https://github.com/apache/airflow/pull/17432#issuecomment-893208649
Thanks @uranusjr ! I am a bit embarrassed after those after all those reviews :D . 3 PRS + 1 fixing static checks and finally only that one fixes it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17432: Fixes some static check errors
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17432:
URL: https://github.com/apache/airflow/pull/17432#issuecomment-893214157
Glad I am going for vacations whole next week ;) - looks like I need it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17432: Fixes some static check errors
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17432:
URL: https://github.com/apache/airflow/pull/17432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17432: Fixes some static check errors
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17432:
URL: https://github.com/apache/airflow/pull/17432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17432: Fixes some static check errors
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17432:
URL: https://github.com/apache/airflow/pull/17432#issuecomment-893208649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org