You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2016/02/27 00:55:38 UTC

Review Request 44114: Combo Search: Implement "component state" related filters

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44114/
-----------------------------------------------------------

Review request for Ambari and Xi Wang.


Bugs: AMBARI-15120
    https://issues.apache.org/jira/browse/AMBARI-15120


Repository: ambari


Description
-------

Combo Search: Implement "component state" related filters


Diffs
-----

  ambari-web/app/controllers/global/update_controller.js ebefd0f 
  ambari-web/app/controllers/main/host.js dac005b 
  ambari-web/app/controllers/main/host/combo_search_box.js 3cbb602 
  ambari-web/app/mixins/common/table_server_view_mixin.js 0f84633 
  ambari-web/app/views/main/host/combo_search_box.js 73dd347 

Diff: https://reviews.apache.org/r/44114/diff/


Testing
-------

Manually tested on live cluster.
All unit test passed.

  24337 tests complete (23 seconds)
  146 tests pending


Thanks,

Richard Zang


Re: Review Request 44114: Combo Search: Implement "component state" related filters

Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44114/#review121034
-----------------------------------------------------------


Ship it!




Ship It!

- Xi Wang


On Feb. 26, 2016, 5:01 p.m., Richard Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44114/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 5:01 p.m.)
> 
> 
> Review request for Ambari and Xi Wang.
> 
> 
> Bugs: AMBARI-15120
>     https://issues.apache.org/jira/browse/AMBARI-15120
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Combo Search: Implement "component state" related filters
> This one only support component filter tag on not more than 1 component. Will support multiple component later.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/global/update_controller.js ebefd0f 
>   ambari-web/app/controllers/main/host.js dac005b 
>   ambari-web/app/controllers/main/host/combo_search_box.js 3cbb602 
>   ambari-web/app/mixins/common/table_server_view_mixin.js 0f84633 
>   ambari-web/app/views/main/host/combo_search_box.js 73dd347 
> 
> Diff: https://reviews.apache.org/r/44114/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on live cluster.
> All unit test passed.
> 
>   24337 tests complete (23 seconds)
>   146 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>


Re: Review Request 44114: Combo Search: Implement "component state" related filters

Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44114/
-----------------------------------------------------------

(Updated Feb. 27, 2016, 1:16 a.m.)


Review request for Ambari and Xi Wang.


Bugs: AMBARI-15210
    https://issues.apache.org/jira/browse/AMBARI-15210


Repository: ambari


Description
-------

Combo Search: Implement "component state" related filters
This one only support component filter tag on not more than 1 component. Will support multiple component later.


Diffs
-----

  ambari-web/app/controllers/global/update_controller.js ebefd0f 
  ambari-web/app/controllers/main/host.js dac005b 
  ambari-web/app/controllers/main/host/combo_search_box.js 3cbb602 
  ambari-web/app/mixins/common/table_server_view_mixin.js 0f84633 
  ambari-web/app/views/main/host/combo_search_box.js 73dd347 

Diff: https://reviews.apache.org/r/44114/diff/


Testing
-------

Manually tested on live cluster.
All unit test passed.

  24337 tests complete (23 seconds)
  146 tests pending


Thanks,

Richard Zang


Re: Review Request 44114: Combo Search: Implement "component state" related filters

Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44114/
-----------------------------------------------------------

(Updated Feb. 27, 2016, 1:01 a.m.)


Review request for Ambari and Xi Wang.


Bugs: AMBARI-15120
    https://issues.apache.org/jira/browse/AMBARI-15120


Repository: ambari


Description (updated)
-------

Combo Search: Implement "component state" related filters
This one only support component filter tag on not more than 1 component. Will support multiple component later.


Diffs
-----

  ambari-web/app/controllers/global/update_controller.js ebefd0f 
  ambari-web/app/controllers/main/host.js dac005b 
  ambari-web/app/controllers/main/host/combo_search_box.js 3cbb602 
  ambari-web/app/mixins/common/table_server_view_mixin.js 0f84633 
  ambari-web/app/views/main/host/combo_search_box.js 73dd347 

Diff: https://reviews.apache.org/r/44114/diff/


Testing
-------

Manually tested on live cluster.
All unit test passed.

  24337 tests complete (23 seconds)
  146 tests pending


Thanks,

Richard Zang


Re: Review Request 44114: Combo Search: Implement "component state" related filters

Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44114/
-----------------------------------------------------------

(Updated Feb. 27, 2016, 12:12 a.m.)


Review request for Ambari and Xi Wang.


Changes
-------

Fix STOPPED state


Bugs: AMBARI-15120
    https://issues.apache.org/jira/browse/AMBARI-15120


Repository: ambari


Description
-------

Combo Search: Implement "component state" related filters


Diffs (updated)
-----

  ambari-web/app/controllers/global/update_controller.js ebefd0f 
  ambari-web/app/controllers/main/host.js dac005b 
  ambari-web/app/controllers/main/host/combo_search_box.js 3cbb602 
  ambari-web/app/mixins/common/table_server_view_mixin.js 0f84633 
  ambari-web/app/views/main/host/combo_search_box.js 73dd347 

Diff: https://reviews.apache.org/r/44114/diff/


Testing
-------

Manually tested on live cluster.
All unit test passed.

  24337 tests complete (23 seconds)
  146 tests pending


Thanks,

Richard Zang