You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/10 13:13:41 UTC
[GitHub] [flink] slinkydeveloper opened a new pull request #18704: [FLINK-26054][table-planner][build] Add enforcer rule to disable direct dependency on table planner
slinkydeveloper opened a new pull request #18704:
URL: https://github.com/apache/flink/pull/18704
## What is the purpose of the change
Add a maven enforcer rule to disable direct dependency on table planner. Added exclusions to modules depending directly on table planner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18704: [FLINK-26054][table-planner][build] Add enforcer rule to disable direct dependency on table planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18704:
URL: https://github.com/apache/flink/pull/18704#issuecomment-1034913098
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "385d41344c4a95ddc7041b05ff2c622d9de2c6ce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31132",
"triggerID" : "385d41344c4a95ddc7041b05ff2c622d9de2c6ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 385d41344c4a95ddc7041b05ff2c622d9de2c6ce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31132)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18704: [FLINK-26054][table-planner][build] Add enforcer rule to disable direct dependency on table planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18704:
URL: https://github.com/apache/flink/pull/18704#issuecomment-1034913098
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "385d41344c4a95ddc7041b05ff2c622d9de2c6ce",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31132",
"triggerID" : "385d41344c4a95ddc7041b05ff2c622d9de2c6ce",
"triggerType" : "PUSH"
}, {
"hash" : "06af5845ff7cb107455d48cdca7c5ed0bd04a286",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31145",
"triggerID" : "06af5845ff7cb107455d48cdca7c5ed0bd04a286",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 385d41344c4a95ddc7041b05ff2c622d9de2c6ce Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31132)
* 06af5845ff7cb107455d48cdca7c5ed0bd04a286 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31145)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18704: [FLINK-26054][table-planner][build] Add enforcer rule to disable direct dependency on table planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18704:
URL: https://github.com/apache/flink/pull/18704#issuecomment-1034913098
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "385d41344c4a95ddc7041b05ff2c622d9de2c6ce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31132",
"triggerID" : "385d41344c4a95ddc7041b05ff2c622d9de2c6ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 385d41344c4a95ddc7041b05ff2c622d9de2c6ce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31132)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18704: [FLINK-26054][table-planner][build] Add enforcer rule to disable direct dependency on table planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18704:
URL: https://github.com/apache/flink/pull/18704#issuecomment-1034913098
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "385d41344c4a95ddc7041b05ff2c622d9de2c6ce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31132",
"triggerID" : "385d41344c4a95ddc7041b05ff2c622d9de2c6ce",
"triggerType" : "PUSH"
}, {
"hash" : "06af5845ff7cb107455d48cdca7c5ed0bd04a286",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31145",
"triggerID" : "06af5845ff7cb107455d48cdca7c5ed0bd04a286",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 385d41344c4a95ddc7041b05ff2c622d9de2c6ce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31132)
* 06af5845ff7cb107455d48cdca7c5ed0bd04a286 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31145)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #18704: [FLINK-26054][table-planner][build] Add enforcer rule to disable direct dependency on table planner
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #18704:
URL: https://github.com/apache/flink/pull/18704#discussion_r803700398
##########
File path: flink-connectors/flink-connector-cassandra/pom.xml
##########
@@ -43,6 +43,23 @@ under the License.
<build>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>forbid-direct-table-planner-dependencies</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <!-- We need to depend on table planner because we rely on its internals -->
+ <skip>true</skip>
Review comment:
Removed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #18704: [FLINK-26054][table-planner][build] Add enforcer rule to disable direct dependency on table planner
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #18704:
URL: https://github.com/apache/flink/pull/18704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18704: [FLINK-26054][table-planner][build] Add enforcer rule to disable direct dependency on table planner
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18704:
URL: https://github.com/apache/flink/pull/18704#issuecomment-1034913098
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "385d41344c4a95ddc7041b05ff2c622d9de2c6ce",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "385d41344c4a95ddc7041b05ff2c622d9de2c6ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 385d41344c4a95ddc7041b05ff2c622d9de2c6ce UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18704: [FLINK-26054][table-planner][build] Add enforcer rule to disable direct dependency on table planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18704:
URL: https://github.com/apache/flink/pull/18704#issuecomment-1034913098
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "385d41344c4a95ddc7041b05ff2c622d9de2c6ce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31132",
"triggerID" : "385d41344c4a95ddc7041b05ff2c622d9de2c6ce",
"triggerType" : "PUSH"
}, {
"hash" : "06af5845ff7cb107455d48cdca7c5ed0bd04a286",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "06af5845ff7cb107455d48cdca7c5ed0bd04a286",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 385d41344c4a95ddc7041b05ff2c622d9de2c6ce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31132)
* 06af5845ff7cb107455d48cdca7c5ed0bd04a286 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18704: [FLINK-26054][table-planner][build] Add enforcer rule to disable direct dependency on table planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18704:
URL: https://github.com/apache/flink/pull/18704#issuecomment-1034913098
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "385d41344c4a95ddc7041b05ff2c622d9de2c6ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31132",
"triggerID" : "385d41344c4a95ddc7041b05ff2c622d9de2c6ce",
"triggerType" : "PUSH"
}, {
"hash" : "06af5845ff7cb107455d48cdca7c5ed0bd04a286",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31145",
"triggerID" : "06af5845ff7cb107455d48cdca7c5ed0bd04a286",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 06af5845ff7cb107455d48cdca7c5ed0bd04a286 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31145)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18704: [FLINK-26054][table-planner][build] Add enforcer rule to disable direct dependency on table planner
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18704:
URL: https://github.com/apache/flink/pull/18704#issuecomment-1034913440
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 385d41344c4a95ddc7041b05ff2c622d9de2c6ce (Thu Feb 10 13:19:03 UTC 2022)
**Warnings:**
* **6 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18704: [FLINK-26054][table-planner][build] Add enforcer rule to disable direct dependency on table planner
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18704:
URL: https://github.com/apache/flink/pull/18704#discussion_r803675502
##########
File path: flink-connectors/flink-connector-cassandra/pom.xml
##########
@@ -43,6 +43,23 @@ under the License.
<build>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>forbid-direct-table-planner-dependencies</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <!-- We need to depend on table planner because we rely on its internals -->
+ <skip>true</skip>
Review comment:
What does cassandra need the planner for? O.o
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18704: [FLINK-26054][table-planner][build] Add enforcer rule to disable direct dependency on table planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18704:
URL: https://github.com/apache/flink/pull/18704#issuecomment-1034913098
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "385d41344c4a95ddc7041b05ff2c622d9de2c6ce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31132",
"triggerID" : "385d41344c4a95ddc7041b05ff2c622d9de2c6ce",
"triggerType" : "PUSH"
}, {
"hash" : "06af5845ff7cb107455d48cdca7c5ed0bd04a286",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "06af5845ff7cb107455d48cdca7c5ed0bd04a286",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 385d41344c4a95ddc7041b05ff2c622d9de2c6ce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31132)
* 06af5845ff7cb107455d48cdca7c5ed0bd04a286 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org