You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "airborne12 (via GitHub)" <gi...@apache.org> on 2024/03/22 07:01:28 UTC

[PR] [Fix](inverted index) fix tokenize function wrong result when params … [doris]

airborne12 opened a new pull request, #32671:
URL: https://github.com/apache/doris/pull/32671

   …with space seperator
   
   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](inverted index) fix tokenize function wrong result when params … [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32671:
URL: https://github.com/apache/doris/pull/32671#issuecomment-2014498309

   TeamCity be ut coverage result:
    Function Coverage: 35.28% (8733/24756) 
    Line Coverage: 27.07% (71511/264142)
    Region Coverage: 26.31% (37101/140995)
    Branch Coverage: 23.21% (18972/81742)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/0856ca76e1d7f7f0248c663f7bdd0654066f980e_0856ca76e1d7f7f0248c663f7bdd0654066f980e/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](inverted index) fix tokenize function wrong result when params … [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32671:
URL: https://github.com/apache/doris/pull/32671#issuecomment-2014474302

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](inverted index) fix tokenize function wrong result when params … [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32671:
URL: https://github.com/apache/doris/pull/32671#issuecomment-2014507768

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 37216 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 0856ca76e1d7f7f0248c663f7bdd0654066f980e, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17672	4212	4098	4098
   q2	2103	155	154	154
   q3	10595	1107	1185	1107
   q4	10229	758	710	710
   q5	7453	2985	2964	2964
   q6	199	124	121	121
   q7	1021	571	550	550
   q8	9334	1999	1961	1961
   q9	7155	6435	6455	6435
   q10	8391	3323	3479	3323
   q11	432	229	217	217
   q12	469	195	188	188
   q13	17807	2837	2836	2836
   q14	244	211	204	204
   q15	508	462	466	462
   q16	487	369	363	363
   q17	936	525	606	525
   q18	7081	6372	6319	6319
   q19	3454	1374	1393	1374
   q20	542	251	248	248
   q21	3562	2770	2931	2770
   q22	352	287	296	287
   Total cold run time: 110026 ms
   Total hot run time: 37216 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4137	4048	4212	4048
   q2	324	230	233	230
   q3	2939	2831	2832	2831
   q4	1817	1586	1558	1558
   q5	5225	5265	5182	5182
   q6	197	116	117	116
   q7	2228	1842	1835	1835
   q8	3133	3298	3283	3283
   q9	8547	8486	8563	8486
   q10	3684	3659	3682	3659
   q11	546	448	441	441
   q12	740	525	528	525
   q13	16942	2895	2853	2853
   q14	275	261	254	254
   q15	500	451	470	451
   q16	483	417	412	412
   q17	1722	1479	1456	1456
   q18	7464	7312	7215	7215
   q19	1623	1524	1472	1472
   q20	1907	1717	1706	1706
   q21	4772	4709	4693	4693
   q22	525	443	446	443
   Total cold run time: 69730 ms
   Total hot run time: 53149 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](inverted index) fix tokenize function wrong result when params … [doris]

Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon merged PR #32671:
URL: https://github.com/apache/doris/pull/32671


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](inverted index) fix tokenize function wrong result when params … [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32671:
URL: https://github.com/apache/doris/pull/32671#issuecomment-2014611139

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](inverted index) fix tokenize function wrong result when params … [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32671:
URL: https://github.com/apache/doris/pull/32671#issuecomment-2014520614

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 181321 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 0856ca76e1d7f7f0248c663f7bdd0654066f980e, data reload: false
   
   query1	930	375	351	351
   query2	7404	2128	2025	2025
   query3	6701	212	213	212
   query4	31601	20549	20783	20549
   query5	4305	406	386	386
   query6	268	186	190	186
   query7	4637	289	291	289
   query8	227	167	175	167
   query9	9306	2273	2279	2273
   query10	555	245	246	245
   query11	14677	14168	14223	14168
   query12	137	89	89	89
   query13	1622	418	404	404
   query14	12528	10994	11384	10994
   query15	264	203	188	188
   query16	8242	261	274	261
   query17	1952	574	532	532
   query18	2108	285	282	282
   query19	348	152	153	152
   query20	95	85	89	85
   query21	197	136	125	125
   query22	4620	4434	4482	4434
   query23	31684	30912	31036	30912
   query24	10742	2842	2828	2828
   query25	613	378	377	377
   query26	870	154	156	154
   query27	2287	346	358	346
   query28	6631	1892	1856	1856
   query29	901	654	616	616
   query30	313	148	145	145
   query31	954	717	733	717
   query32	95	57	53	53
   query33	785	262	263	262
   query34	1035	454	485	454
   query35	830	593	614	593
   query36	1023	857	868	857
   query37	122	75	74	74
   query38	3556	3443	3441	3441
   query39	1409	1371	1394	1371
   query40	205	109	110	109
   query41	48	46	46	46
   query42	100	92	90	90
   query43	486	461	474	461
   query44	1199	704	711	704
   query45	271	256	252	252
   query46	1106	681	689	681
   query47	1646	1589	1591	1589
   query48	464	351	362	351
   query49	1090	320	325	320
   query50	748	368	362	362
   query51	6706	6564	6617	6564
   query52	102	90	83	83
   query53	341	271	274	271
   query54	307	256	240	240
   query55	80	81	75	75
   query56	236	231	223	223
   query57	1084	1023	1014	1014
   query58	236	198	199	198
   query59	2762	2716	2583	2583
   query60	260	243	263	243
   query61	101	97	98	97
   query62	621	387	403	387
   query63	306	273	270	270
   query64	5538	3931	3845	3845
   query65	3075	2981	3042	2981
   query66	876	360	373	360
   query67	14818	14397	14327	14327
   query68	6115	517	525	517
   query69	598	383	388	383
   query70	1205	1141	1131	1131
   query71	490	285	274	274
   query72	6822	2816	2619	2619
   query73	731	318	315	315
   query74	6992	6546	6574	6546
   query75	3897	2780	2781	2780
   query76	4366	945	870	870
   query77	634	264	261	261
   query78	10309	9703	9728	9703
   query79	10436	518	525	518
   query80	2071	394	400	394
   query81	559	218	210	210
   query82	1607	214	199	199
   query83	290	151	153	151
   query84	285	77	90	77
   query85	1550	331	311	311
   query86	496	291	298	291
   query87	3767	3560	3513	3513
   query88	4910	2288	2301	2288
   query89	518	359	383	359
   query90	2003	175	174	174
   query91	171	157	142	142
   query92	60	51	47	47
   query93	7005	501	473	473
   query94	1290	181	177	177
   query95	432	328	324	324
   query96	628	276	272	272
   query97	3043	2873	2883	2873
   query98	230	208	209	208
   query99	1101	742	763	742
   Total cold run time: 305997 ms
   Total hot run time: 181321 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](inverted index) fix tokenize function wrong result when params … [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32671:
URL: https://github.com/apache/doris/pull/32671#issuecomment-2014479548

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](inverted index) fix tokenize function wrong result when params … [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32671:
URL: https://github.com/apache/doris/pull/32671#issuecomment-2014524160

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 0856ca76e1d7f7f0248c663f7bdd0654066f980e with default session variables
   Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
   Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       20.2 seconds inserted 10000000 Rows, about 495K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](inverted index) fix tokenize function wrong result when params … [doris]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #32671:
URL: https://github.com/apache/doris/pull/32671#issuecomment-2014474411

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](inverted index) fix tokenize function wrong result when params … [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32671:
URL: https://github.com/apache/doris/pull/32671#issuecomment-2014611179

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org