You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/11 20:14:31 UTC
[GitHub] [incubator-superset] ktmud opened a new pull request #9286: fix:
bump legacy-table-chart to 0.11.19
ktmud opened a new pull request #9286: fix: bump legacy-table-chart to 0.11.19
URL: https://github.com/apache/incubator-superset/pull/9286
### CATEGORY
- [x ] Bug Fix
### SUMMARY
Fixes data table chart on very long column names and in very small containers:
Also adjusted the position of the sort icons to align them at the bottom of table head.
Depends on https://github.com/apache-superset/superset-ui-plugins/pull/398
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
- Before
- After
### TEST PLAN
1. Create a table with a very long metric name
2. Put it into a small grid container in the dashboard
3. The table should not overflow out of the chart container.
### ADDITIONAL INFORMATION
N/A
### REVIEWERS
@etr2460 @graceguo-supercat @kristw
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #9286: fix: bump
legacy-table-chart to 0.11.20
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #9286: fix: bump legacy-table-chart to 0.11.20
URL: https://github.com/apache/incubator-superset/pull/9286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9286: fix: bump legacy-table-chart to 0.11.20
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9286: fix: bump legacy-table-chart to 0.11.20
URL: https://github.com/apache/incubator-superset/pull/9286#discussion_r391272348
##########
File path: superset-frontend/package-lock.json
##########
@@ -7670,28 +7670,28 @@
"dependencies": {
"abbrev": {
"version": "1.1.1",
- "resolved": "",
+ "resolved": false,
Review comment:
Empty strings become `false`s again. 🤦♂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on issue #9286: fix: bump
legacy-table-chart to 0.11.20
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #9286: fix: bump legacy-table-chart to 0.11.20
URL: https://github.com/apache/incubator-superset/pull/9286#issuecomment-597880025
> Why are there so many package lock changes here?
Did a fresh `npm install` this time by removing both `node_modules` and `package-lock.json`.
```bas
rm -rf node_modules package-lock.json && ENV="" NODE_ENV="development" npm install
```
Maybe not a good idea?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on issue #9286: fix: bump
legacy-table-chart to 0.11.20
Posted by GitBox <gi...@apache.org>.
etr2460 commented on issue #9286: fix: bump legacy-table-chart to 0.11.20
URL: https://github.com/apache/incubator-superset/pull/9286#issuecomment-597878482
Why are there so many package lock changes here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9286: fix: bump legacy-table-chart to 0.11.20
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9286: fix: bump legacy-table-chart to 0.11.20
URL: https://github.com/apache/incubator-superset/pull/9286#discussion_r391292016
##########
File path: superset-frontend/package-lock.json
##########
@@ -7670,28 +7670,28 @@
"dependencies": {
"abbrev": {
"version": "1.1.1",
- "resolved": "",
+ "resolved": false,
Review comment:
lol this i can deal with :P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw commented on issue #9286: fix: bump
legacy-table-chart to 0.11.20
Posted by GitBox <gi...@apache.org>.
kristw commented on issue #9286: fix: bump legacy-table-chart to 0.11.20
URL: https://github.com/apache/incubator-superset/pull/9286#issuecomment-597881833
@ktmud That is kinda dangerous.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org