You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/04/10 06:09:24 UTC

[PR] CAMEL-23306: Add missing sample-placeholder route to Spring XML test config [camel]

gnodet opened a new pull request, #22526:
URL: https://github.com/apache/camel/pull/22526

   [CAMEL-23306](https://issues.apache.org/jira/browse/CAMEL-23306)
   
   ## Summary
   
   - Add the missing `direct:sample-placeholder` route with property placeholder to `samplingThrottler.xml`
   - Add `testSamplingWithPropertyPlaceholder()` override in `SpringSamplingThrottlerTest`
   
   The parent test `SamplingThrottlerTest` added `testSamplingWithPropertyPlaceholder()` and its corresponding route in commit 06629602fe6a (CAMEL-23279), but the Spring XML config and Spring test subclass were not updated, causing the inherited test to always fail with a 30-second timeout.
   
   _Claude Code on behalf of Guillaume Nodet_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23306: Add missing sample-placeholder route to Spring XML test config [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22526:
URL: https://github.com/apache/camel/pull/22526#issuecomment-4221613902

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `components/camel-spring-parent/camel-spring-xml`
   
   > :information_source: Dependent modules were not tested because the total number of affected modules exceeded the threshold (50). Use the `test-dependents` label to force testing all dependents.
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/24229172396)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23306: Add missing sample-placeholder route to Spring XML test config [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22526:
URL: https://github.com/apache/camel/pull/22526#issuecomment-4221393980

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23306: Add missing sample-placeholder route to Spring XML test config [camel]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #22526:
URL: https://github.com/apache/camel/pull/22526


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org