[GitHub] LucaCanali commented on a change in pull request #22290: [SPARK-25285][CORE] Add executor task metrics, successfulTasks and threadpool.startedTasks

[GitBox <gi...@apache.org>]

LucaCanali commented on a change in pull request #22290: [SPARK-25285][CORE] Add executor task metrics, successfulTasks and threadpool.startedTasks
URL: https://github.com/apache/spark/pull/22290#discussion_r254856020
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/executor/ExecutorSource.scala
 ##########
 @@ -75,6 +80,7 @@ class ExecutorSource(threadPool: ThreadPoolExecutor, executorId: String) extends
 
   // Expose executor task metrics using the Dropwizard metrics system.
   // The list is taken from TaskMetrics.scala
+  val SUCCESSFUL_TASKS = metricRegistry.counter(MetricRegistry.name("successfulTasks"))
 
 Review comment:
   The two metrics come from different sources, one from the Java thread pool and the other from the executor. When all runs soomthly the values of the two metrics should be very close/the same. Large differences between those 2 values can help spotting issues.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org