You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/03/20 12:25:23 UTC
[kudu-CR] [docs] Change NTP pool addresses
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9726
to review the following change.
Change subject: [docs] Change NTP pool addresses
......................................................................
[docs] Change NTP pool addresses
Official pool.ntp.org docs say "Looking up pool.ntp.org (or
0.pool.ntp.org, 1.pool.ntp.org, etc) will usually return IP addresses
for servers in or close to your country. For most users this will give
the best results." - http://www.pool.ntp.org/en/use.html
It would be better to use this as an example
Change-Id: I3ba728584b095eb24312191efcaecbb221b6658b
---
M docs/troubleshooting.adoc
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/9726/1
--
To view, visit http://gerrit.cloudera.org:8080/9726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ba728584b095eb24312191efcaecbb221b6658b
Gerrit-Change-Number: 9726
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] [docs] Change NTP pool addresses
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9726 )
Change subject: [docs] Change NTP pool addresses
......................................................................
[docs] Change NTP pool addresses
Official pool.ntp.org docs say "Looking up pool.ntp.org (or
0.pool.ntp.org, 1.pool.ntp.org, etc) will usually return IP addresses
for servers in or close to your country. For most users this will give
the best results." - http://www.pool.ntp.org/en/use.html
It would be better to use this as an example
Change-Id: I3ba728584b095eb24312191efcaecbb221b6658b
Reviewed-on: http://gerrit.cloudera.org:8080/9726
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M docs/troubleshooting.adoc
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved; Verified
Kudu Jenkins: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ba728584b095eb24312191efcaecbb221b6658b
Gerrit-Change-Number: 9726
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [docs] Change NTP pool addresses
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9726 )
Change subject: [docs] Change NTP pool addresses
......................................................................
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ba728584b095eb24312191efcaecbb221b6658b
Gerrit-Change-Number: 9726
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 20 Mar 2018 12:59:49 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Change NTP pool addresses
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9726 )
Change subject: [docs] Change NTP pool addresses
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ba728584b095eb24312191efcaecbb221b6658b
Gerrit-Change-Number: 9726
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 20 Mar 2018 22:30:07 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Change NTP pool addresses
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9726 )
Change subject: [docs] Change NTP pool addresses
......................................................................
Patch Set 1:
LGTM but I'll give Todd a chance to do a once over.
--
To view, visit http://gerrit.cloudera.org:8080/9726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ba728584b095eb24312191efcaecbb221b6658b
Gerrit-Change-Number: 9726
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 20 Mar 2018 13:00:24 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Change NTP pool addresses
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9726 )
Change subject: [docs] Change NTP pool addresses
......................................................................
Removed reviewer Kudu Jenkins.
--
To view, visit http://gerrit.cloudera.org:8080/9726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I3ba728584b095eb24312191efcaecbb221b6658b
Gerrit-Change-Number: 9726
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>