You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/09/20 22:12:38 UTC
[GitHub] [bookkeeper] pkumar-singh opened a new pull request #2800: {Draft}
pkumar-singh opened a new pull request #2800:
URL: https://github.com/apache/bookkeeper/pull/2800
Descriptions of the changes in this PR:
### Motivation
(Explain: why you're making that change, what is the problem you're trying to solve)
### Changes
(Describe: what changes you have made)
Master Issue: #<master-issue-number>
> ---
> In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
> checks for pull requests. A pull request can only be merged when it passes precommit checks.
>
> ---
> Be sure to do all of the following to help us incorporate your contribution
> quickly and easily:
>
> If this PR is a BookKeeper Proposal (BP):
>
> - [ ] Make sure the PR title is formatted like:
> `<BP-#>: Description of bookkeeper proposal`
> `e.g. BP-1: 64 bits ledger is support`
> - [ ] Attach the master issue link in the description of this PR.
> - [ ] Attach the google doc link if the BP is written in Google Doc.
>
> Otherwise:
>
> - [ ] Make sure the PR title is formatted like:
> `<Issue #>: Description of pull request`
> `e.g. Issue 123: Description ...`
> - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
> - [ ] Replace `<Issue #>` in the title with the actual Issue number.
>
> ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hsaputra commented on pull request #2800: ISSUE #2640: BP-43 Migrate bookkeeper client tests to gradle
Posted by GitBox <gi...@apache.org>.
hsaputra commented on pull request #2800:
URL: https://github.com/apache/bookkeeper/pull/2800#issuecomment-926923667
Duplicated by https://github.com/apache/bookkeeper/pull/2807 to help with the merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #2800: ISSUE #2640: BP-43 Migrate bookkeeper client tests to gradle
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #2800:
URL: https://github.com/apache/bookkeeper/pull/2800#issuecomment-925360468
@pkumar-singh thanks, i mean to remove it also from properties and settings, but we can keep them if they will be used in the next PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pkumar-singh commented on pull request #2800: ISSUE #2640: BP-43 Migrate bookkeeper client tests to gradle
Posted by GitBox <gi...@apache.org>.
pkumar-singh commented on pull request #2800:
URL: https://github.com/apache/bookkeeper/pull/2800#issuecomment-925323010
@nicoloboschi I will uncomment that in next commit, If you do not mind. It will follow soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hsaputra commented on pull request #2800: ISSUE #2640: BP-43 Migrate bookkeeper client tests to gradle
Posted by GitBox <gi...@apache.org>.
hsaputra commented on pull request #2800:
URL: https://github.com/apache/bookkeeper/pull/2800#issuecomment-925375581
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pkumar-singh commented on pull request #2800: ISSUE #2640: BP-43 Migrate bookkeeper client tests to gradle
Posted by GitBox <gi...@apache.org>.
pkumar-singh commented on pull request #2800:
URL: https://github.com/apache/bookkeeper/pull/2800#issuecomment-925340161
> @nicoloboschi I will uncomment that in next commit, If you do not mind. It will follow soon.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hsaputra closed pull request #2800: ISSUE #2640: BP-43 Migrate bookkeeper client tests to gradle
Posted by GitBox <gi...@apache.org>.
hsaputra closed pull request #2800:
URL: https://github.com/apache/bookkeeper/pull/2800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pkumar-singh commented on a change in pull request #2800: ISSUE #2640: BP-43 Migrate bookkeeper client tests to gradle
Posted by GitBox <gi...@apache.org>.
pkumar-singh commented on a change in pull request #2800:
URL: https://github.com/apache/bookkeeper/pull/2800#discussion_r714320077
##########
File path: bookkeeper-server/build.gradle
##########
@@ -18,6 +18,8 @@
*/
plugins {
id 'java'
+ id 'com.adarshr.test-logger'
+ //id 'org.gradle.test-retry'
Review comment:
Sure done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hsaputra edited a comment on pull request #2800: ISSUE #2640: BP-43 Migrate bookkeeper client tests to gradle
Posted by GitBox <gi...@apache.org>.
hsaputra edited a comment on pull request #2800:
URL: https://github.com/apache/bookkeeper/pull/2800#issuecomment-925409343
@merlimat , @eolivelli , or @ivankelly - could one of you help merge this one? I keep getting this error:
```
Unable to fetch URL, exiting: https://api.github.com/repos/apache/bookkeeper/pulls/2800/merge - HTTP Error 404: Not Found
HTTP Error 404: Not Found
```
again =(
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pkumar-singh commented on a change in pull request #2800: ISSUE #2640: BP-43 Migrate bookkeeper client tests to gradle
Posted by GitBox <gi...@apache.org>.
pkumar-singh commented on a change in pull request #2800:
URL: https://github.com/apache/bookkeeper/pull/2800#discussion_r714187701
##########
File path: bookkeeper-server/build.gradle
##########
@@ -18,6 +18,8 @@
*/
plugins {
id 'java'
+ id 'com.adarshr.test-logger'
+ //id 'org.gradle.test-retry'
Review comment:
yeah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hsaputra commented on pull request #2800: ISSUE #2640: BP-43 Migrate bookkeeper client tests to gradle
Posted by GitBox <gi...@apache.org>.
hsaputra commented on pull request #2800:
URL: https://github.com/apache/bookkeeper/pull/2800#issuecomment-925409343
@merlimat - could you help merge this one? I get this error:
```
Unable to fetch URL, exiting: https://api.github.com/repos/apache/bookkeeper/pulls/2800/merge - HTTP Error 404: Not Found
HTTP Error 404: Not Found
```
again =(
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pkumar-singh commented on a change in pull request #2800: ISSUE #2640: BP-43 Migrate bookkeeper client tests to gradle
Posted by GitBox <gi...@apache.org>.
pkumar-singh commented on a change in pull request #2800:
URL: https://github.com/apache/bookkeeper/pull/2800#discussion_r714187701
##########
File path: bookkeeper-server/build.gradle
##########
@@ -18,6 +18,8 @@
*/
plugins {
id 'java'
+ id 'com.adarshr.test-logger'
+ //id 'org.gradle.test-retry'
Review comment:
yeah thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hsaputra commented on a change in pull request #2800: ISSUE #2640: BP-43 Migrate bookkeeper client tests to gradle
Posted by GitBox <gi...@apache.org>.
hsaputra commented on a change in pull request #2800:
URL: https://github.com/apache/bookkeeper/pull/2800#discussion_r714307100
##########
File path: bookkeeper-server/build.gradle
##########
@@ -18,6 +18,8 @@
*/
plugins {
id 'java'
+ id 'com.adarshr.test-logger'
+ //id 'org.gradle.test-retry'
Review comment:
@pkumar-singh - could you update the PR to remove at least this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] merlimat commented on a change in pull request #2800: ISSUE #2640: BP-43 Migrate bookkeeper client tests to gradle
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #2800:
URL: https://github.com/apache/bookkeeper/pull/2800#discussion_r714184858
##########
File path: bookkeeper-server/build.gradle
##########
@@ -18,6 +18,8 @@
*/
plugins {
id 'java'
+ id 'com.adarshr.test-logger'
+ //id 'org.gradle.test-retry'
Review comment:
we can remove if not used for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hsaputra commented on pull request #2800: ISSUE #2640: BP-43 Migrate bookkeeper client tests to gradle
Posted by GitBox <gi...@apache.org>.
hsaputra commented on pull request #2800:
URL: https://github.com/apache/bookkeeper/pull/2800#issuecomment-925317323
Will merge this by end of day if no more comment or suggestion. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org