You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/01/20 02:26:55 UTC
Review Request 42530: Changed 'createReservationInfo' to take
'Option'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42530/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
Changed 'createReservationInfo' to take 'Option<string>'.
Diffs
-----
src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac
Diff: https://reviews.apache.org/r/42530/diff/
Testing
-------
`make check` on OSX.
Thanks,
Greg Mann
Re: Review Request 42530: Changed `createReservationInfo` to take
`Option`.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42530/#review115310
-----------------------------------------------------------
src/tests/mesos.hpp (line 479)
<https://reviews.apache.org/r/42530/#comment176280>
Oops, sorry. Let's give this a default argument of `None()` here for consistently in style and so that we can do `createReservationInfo()`.
- Michael Park
On Jan. 20, 2016, 1:30 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42530/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 1:30 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed `createReservationInfo` to take `Option<string>`.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac
>
> Diff: https://reviews.apache.org/r/42530/diff/
>
>
> Testing
> -------
>
> `make check` on OSX.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 42530: Changed `createReservationInfo` to take
`Option`.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42530/#review115306
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Jan. 20, 2016, 1:30 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42530/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 1:30 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed `createReservationInfo` to take `Option<string>`.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac
>
> Diff: https://reviews.apache.org/r/42530/diff/
>
>
> Testing
> -------
>
> `make check` on OSX.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 42530: Changed `createReservationInfo` to take
`Option`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42530/
-----------------------------------------------------------
(Updated Jan. 20, 2016, 3:40 a.m.)
Review request for mesos and Michael Park.
Changes
-------
Addressed comment.
Repository: mesos
Description
-------
Changed `createReservationInfo` to take `Option<string>`.
Diffs (updated)
-----
src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac
Diff: https://reviews.apache.org/r/42530/diff/
Testing
-------
`make check` on OSX.
Thanks,
Greg Mann
Re: Review Request 42530: Changed `createReservationInfo` to take
`Option`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42530/
-----------------------------------------------------------
(Updated Jan. 20, 2016, 1:30 a.m.)
Review request for mesos and Michael Park.
Summary (updated)
-----------------
Changed `createReservationInfo` to take `Option<string>`.
Repository: mesos
Description (updated)
-------
Changed `createReservationInfo` to take `Option<string>`.
Diffs
-----
src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac
Diff: https://reviews.apache.org/r/42530/diff/
Testing
-------
`make check` on OSX.
Thanks,
Greg Mann