[jira] [Commented] (TS-4608) Memory leak in ProxyAllocator.cc

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357560#comment-15357560 ] 

ASF GitHub Bot commented on TS-4608:
------------------------------------

GitHub user jaaju opened a pull request:

    https://github.com/apache/trafficserver/pull/774

    TS-4608: Fix memory leak in ProxyAllocator.cc.

    This removes the pre-processor flag TS_USE_FREELIST which is not defined since commit e56d1f9eb6f55b0257d1fb758b773dea468159ee to make freelists a runtime option.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaaju/trafficserver master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/774.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #774
    
----

----


> Memory leak in ProxyAllocator.cc
> --------------------------------
>
>                 Key: TS-4608
>                 URL: https://issues.apache.org/jira/browse/TS-4608
>             Project: Traffic Server
>          Issue Type: Bug
>            Reporter: Jay Ramamurthi
>            Priority: Blocker
>             Fix For: 7.0.0
>
>
> The change to make freelists a runtime option (https://github.com/apache/trafficserver/commit/e56d1f9eb6f55b0257d1fb758b773dea468159ee) seems to have missed this file.
> With the preprocessor symbol TS_USE_FREELIST now gone (earlier used to be 1), the overload of thread_alloc defined in this file always uses Proxy Allocator (the second argument to the method) but free routines are from the freelist. This overload of thread_alloc is used by HdrHeap, that is widely used in transaction processing, causing leaks.
> Steps to reproduce:
> Traffic server with a single remap configuration, and ab workload should show memory growth.
> Version seen in: Traffic Server built from branches master, 6.1.x, 6.2.x.
> Platform: Linux 64-bit (RHEL 6.6), g++ 4.4.7



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)