You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2023/04/28 19:38:57 UTC

[GitHub] [beam] Abacn commented on a diff in pull request #25824: Add driverJars parameter to JdbcIO.

Abacn commented on code in PR #25824:
URL: https://github.com/apache/beam/pull/25824#discussion_r1180754375


##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java:
##########
@@ -209,6 +209,14 @@ protected JdbcIO.DataSourceConfiguration getDataSourceConfiguration() {
         }
       }
 
+      if (config.getSchema().hasField("driverJars")) {

Review Comment:
   I see, this PR intended to support xlang wrapper, but test still failing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org