You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2013/10/22 19:30:38 UTC
Review Request 14848: Added a shared pointer abstraction which enforces
const accesses.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14848/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Vinod Kone, and Jiang Yan Xu.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/include/process/shared.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/14848/diff/
Testing
-------
Trivial, thus no test.
Thanks,
Jie Yu
Re: Review Request 14848: Added a shared pointer abstraction which enforces
const accesses.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Oct. 22, 2013, 6:08 p.m., Benjamin Hindman wrote:
> > Ship It!
I've committed this, thanks!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14848/#review27317
-----------------------------------------------------------
On Oct. 22, 2013, 5:55 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14848/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 5:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 130d40c
> 3rdparty/libprocess/include/process/shared.hpp PRE-CREATION
> 3rdparty/libprocess/src/tests/shared_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14848/diff/
>
>
> Testing
> -------
>
> Trivial, thus no test.
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 14848: Added a shared pointer abstraction which enforces
const accesses.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14848/#review27317
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Oct. 22, 2013, 5:55 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14848/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 5:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 130d40c
> 3rdparty/libprocess/include/process/shared.hpp PRE-CREATION
> 3rdparty/libprocess/src/tests/shared_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14848/diff/
>
>
> Testing
> -------
>
> Trivial, thus no test.
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 14848: Added a shared pointer abstraction which enforces
const accesses.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14848/#review27315
-----------------------------------------------------------
Ship it!
Ship It!
- Jiang Yan Xu
On Oct. 22, 2013, 5:55 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14848/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 5:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 130d40c
> 3rdparty/libprocess/include/process/shared.hpp PRE-CREATION
> 3rdparty/libprocess/src/tests/shared_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14848/diff/
>
>
> Testing
> -------
>
> Trivial, thus no test.
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 14848: Added a shared pointer abstraction which enforces
const accesses.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14848/#review27316
-----------------------------------------------------------
Ship it!
Better be in stout?
- Jiang Yan Xu
On Oct. 22, 2013, 5:55 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14848/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 5:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 130d40c
> 3rdparty/libprocess/include/process/shared.hpp PRE-CREATION
> 3rdparty/libprocess/src/tests/shared_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14848/diff/
>
>
> Testing
> -------
>
> Trivial, thus no test.
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 14848: Added a shared pointer abstraction which enforces
const accesses.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14848/
-----------------------------------------------------------
(Updated Oct. 22, 2013, 5:55 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Vinod Kone, and Jiang Yan Xu.
Changes
-------
Added a test. Fixed the Makefile.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 130d40c
3rdparty/libprocess/include/process/shared.hpp PRE-CREATION
3rdparty/libprocess/src/tests/shared_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/14848/diff/
Testing
-------
Trivial, thus no test.
Thanks,
Jie Yu