You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@answer.apache.org by "colinyyj (via GitHub)" <gi...@apache.org> on 2024/03/06 14:01:10 UTC

[PR] 修改企业微信中敏感信息邮箱节点为biz-email [incubator-answer-plugins]

colinyyj opened a new pull request, #80:
URL: https://github.com/apache/incubator-answer-plugins/pull/80

   The email dictionary for sensitive information returned in wecom is changed from email to biz-email
   ![image](https://github.com/apache/incubator-answer-plugins/assets/5284443/eeaf4379-4d44-4a51-bd5d-5603c542b65e)
   
   Here is the official response
   ![image](https://github.com/apache/incubator-answer-plugins/assets/5284443/37e3a78c-637e-4fb9-9ea3-f71222a07ee4)
   
   For now, apps created in wecom with answer are new apps, according to the timeline
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] 修改企业微信中敏感信息邮箱节点为biz-email [incubator-answer-plugins]

Posted by "colinyyj (via GitHub)" <gi...@apache.org>.
colinyyj commented on PR #80:
URL: https://github.com/apache/incubator-answer-plugins/pull/80#issuecomment-1983391355

   I think your decision is better and should have been made compatible.
   The mailbox has been restricted, thank you very much for your reminding.
   ________________________________
   发件人: LinkinStars ***@***.***>
   发送时间: 2024年3月7日 20:05
   收件人: apache/incubator-answer-plugins ***@***.***>
   抄送: 杨英俊 ***@***.***>; Mention ***@***.***>
   主题: Re: [apache/incubator-answer-plugins] 修改企业微信中敏感信息邮箱节点为biz-email (PR #80)
   
   
   @colinyyj<https://github.com/colinyyj>
   
   image.png (view on web)<https://github.com/apache/incubator-answer-plugins/assets/19712692/a9c2f690-55d9-4ccf-bb22-b0b6599f556a>
   
   I don't know the exact reason why, but in the several applications we are currently using, we can only retrieve the email field and not the biz_mail field. That's why I used the email field when developing this plugin.
   
   However, perhaps we can do this: prioritize using the biz_mail field, and if biz_mail is empty, then try using the email field. It would be better than only use the biz_mail field.
   
   BTW, If you want to use a corporate email, you don't have to worry about users from outside the company registering. You can restrict the registration to only allow users with email domains associated with the company.
   
   image.png (view on web)<https://github.com/apache/incubator-answer-plugins/assets/19712692/b799219e-989e-4615-b6fb-4a4a0b22e6b3>
   
   This means that if the plugin gets a personal email address, the user will not be able to log in either.
   
   ―
   Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-answer-plugins/pull/80#issuecomment-1983369962>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABIKEWZIQAM2GS7CQMVKFFDYXBJXFAVCNFSM6AAAAABEJDWOU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBTGM3DSOJWGI>.
   You are receiving this because you were mentioned.Message ID: ***@***.***>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] 修改企业微信中敏感信息邮箱节点为biz-email [incubator-answer-plugins]

Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars commented on PR #80:
URL: https://github.com/apache/incubator-answer-plugins/pull/80#issuecomment-1983369962

   @colinyyj 
   
   <img width="702" alt="image" src="https://github.com/apache/incubator-answer-plugins/assets/19712692/a9c2f690-55d9-4ccf-bb22-b0b6599f556a">
   
   I don't know the exact reason why, but in the several applications we are currently using, we can only retrieve the email field and not the biz_mail field. That's why I used the email field when developing this plugin.
   
   However, perhaps we can do this: prioritize using the `biz_mail` field, and if `biz_mail` is empty, then try using the `email` field. It would be better than only use the `biz_mail` field.
   
   BTW, If you want to use a corporate email, you don't have to worry about users from outside the company registering. You can restrict the registration to only allow users with email domains associated with the company.
   
   <img width="945" alt="image" src="https://github.com/apache/incubator-answer-plugins/assets/19712692/b799219e-989e-4615-b6fb-4a4a0b22e6b3">
   
   This means that if the plugin gets a personal email address, the user will not be able to log in either.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] 修改企业微信中敏感信息邮箱节点为biz-email [incubator-answer-plugins]

Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars commented on PR #80:
URL: https://github.com/apache/incubator-answer-plugins/pull/80#issuecomment-2095484679

   Done #112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] 修改企业微信中敏感信息邮箱节点为biz-email [incubator-answer-plugins]

Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars closed pull request #80: 修改企业微信中敏感信息邮箱节点为biz-email
URL: https://github.com/apache/incubator-answer-plugins/pull/80


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] 修改企业微信中敏感信息邮箱节点为biz-email [incubator-answer-plugins]

Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars commented on PR #80:
URL: https://github.com/apache/incubator-answer-plugins/pull/80#issuecomment-1981057981

   @colinyyj Thanks for the feedback and contributions, I'll test it later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org