You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sanpwc (via GitHub)" <gi...@apache.org> on 2024/08/05 10:46:06 UTC
Re: [PR] IGNITE-22218 Remove TableRaftService in favor of using RaftGroupService from Replica instances [ignite-3]
sanpwc commented on code in PR #3973:
URL: https://github.com/apache/ignite-3/pull/3973#discussion_r1703923760
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -190,6 +205,9 @@ public PartitionReplicaLifecycleManager(
this.lowWatermark = lowWatermark;
this.ioExecutor = ioExecutor;
this.rebalanceScheduler = rebalanceScheduler;
+ this.clockService = clockService;
+ // should it be ExecutorInclinedPlacementDriver as in TableManager?
Review Comment:
Yes, it is. You may either extract ExecutorInclinedPlacementDriver from TableManager to some common place or just duplicate the class - no big deal in this particular case. Please fix it in follow up ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org