You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/10/08 14:48:52 UTC
[GitHub] [sling-org-apache-sling-graphql-core] raducotescu opened a new pull request #7: SLING-9800 - Extract a service to be able to execute GraphQL queries directly
raducotescu opened a new pull request #7:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/7
* defined a new service - `QueryExecutor` - to execute GraphQL queries
* switched the `GraphQLServlet` and `GraphQLScriptEngine` to use the new service
* cleaned code interacting with the OSGi service registry
* made handling of OSGi services consistent, by using the service with the highest ranking which matches the filter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] raducotescu merged pull request #7: SLING-9800 - Extract a service to be able to execute GraphQL queries directly
Posted by GitBox <gi...@apache.org>.
raducotescu merged pull request #7:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on pull request #7: SLING-9800 - Extract a service to be able to execute GraphQL queries directly
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on pull request #7:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/7#issuecomment-705650614
The build failed as it was not finding the parent pom 40-SNAPSHOT - in the meantime I have mvn:deployed that pom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on pull request #7: SLING-9800 - Extract a service to be able to execute GraphQL queries directly
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on pull request #7:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/7#issuecomment-705650614
The build failed as it was not finding the parent pom 40-SNAPSHOT - in the meantime I have mvn:deployed that pom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on a change in pull request #7: SLING-9800 - Extract a service to be able to execute GraphQL queries directly
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on a change in pull request #7:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/7#discussion_r501813901
##########
File path: src/main/java/org/apache/sling/graphql/core/schema/RankedSchemaProviders.java
##########
@@ -43,7 +43,7 @@
@Component(service = RankedSchemaProviders.class)
public class RankedSchemaProviders implements SchemaProvider {
- final RankedServices<SchemaProvider> providers = new RankedServices<>(Order.ASCENDING);
+ final RankedServices<SchemaProvider> providers = new RankedServices<>(Order.DESCENDING);
Review comment:
Could you just add a comment here that before this commit the order was the opposite?
I don't think it will break anything, but just in case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on a change in pull request #7: SLING-9800 - Extract a service to be able to execute GraphQL queries directly
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on a change in pull request #7:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/7#discussion_r501813901
##########
File path: src/main/java/org/apache/sling/graphql/core/schema/RankedSchemaProviders.java
##########
@@ -43,7 +43,7 @@
@Component(service = RankedSchemaProviders.class)
public class RankedSchemaProviders implements SchemaProvider {
- final RankedServices<SchemaProvider> providers = new RankedServices<>(Order.ASCENDING);
+ final RankedServices<SchemaProvider> providers = new RankedServices<>(Order.DESCENDING);
Review comment:
Could you just add a comment here that before this commit the order was the opposite?
I don't think it will break anything, but just in case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] raducotescu merged pull request #7: SLING-9800 - Extract a service to be able to execute GraphQL queries directly
Posted by GitBox <gi...@apache.org>.
raducotescu merged pull request #7:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org