You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "RongtongJin (via GitHub)" <gi...@apache.org> on 2026/07/21 07:39:39 UTC
[I] [Improvement] Deprecate legacy Broker DLedger mode [rocketmq]
RongtongJin opened a new issue, #10641:
URL: https://github.com/apache/rocketmq/issues/10641
### Motivation
RocketMQ still exposes the legacy Broker DLedger mode through `enableDLegerCommitLog=true`, `DLedgerCommitLog`, and the related `MessageStoreConfig` accessors. For new deployments, Controller mode is the recommended automatic failover path.
This proposal is limited to Broker DLedger mode. It does **not** deprecate the DLedger-backed Controller implementation.
### Proposed changes
- Mark `DLedgerCommitLog` and the Broker-DLedger-specific `MessageStoreConfig` accessors as deprecated.
- Log a clear warning when a Broker starts with `enableDLegerCommitLog=true`.
- Keep existing Broker DLedger behavior, dependencies, and tests intact for compatibility.
- Do not remove or disable the feature because existing deployments may still rely on it.
### Compatibility
Existing clusters continue to start and operate unchanged. The only runtime difference is a deprecation warning for Brokers that explicitly enable the legacy mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Improvement] Deprecate legacy Broker DLedger mode [rocketmq]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #10641:
URL: https://github.com/apache/rocketmq/issues/10641#issuecomment-5031569245
**Issue Evaluation**
Category: `type/enhancement` | Status: **Evaluated**
**Feasibility:** Feasible
**Scope:** `DLedgerCommitLog`, `MessageStoreConfig` (Broker DLedger-specific accessors)
**Compatibility:** No breaking changes — existing clusters continue to operate unchanged
This is a well-scoped deprecation. The distinction between Broker DLedger mode (deprecated) and DLedger-backed Controller (retained) is clearly documented. The approach — add `@Deprecated` annotations + startup warning log while keeping full backward compatibility — is the correct way to signal deprecation without disrupting existing deployments.
**Assessment:**
- Clear motivation: Controller mode is the recommended path for new deployments
- Compatibility is properly considered (no removal, just deprecation markers)
- Scope is correctly limited to Broker DLedger mode only
This looks ready for implementation.
---
*Automated evaluation by RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Improvement] Deprecate legacy Broker DLedger mode [rocketmq]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed issue #10641: [Improvement] Deprecate legacy Broker DLedger mode
URL: https://github.com/apache/rocketmq/issues/10641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org