[GitHub] [arrow] supunkamburugamuve commented on a change in pull request #11854: ARROW-12629: [C++] Add option for disabling readahead in CSV and JSON readers

[GitBox <gi...@apache.org>]

supunkamburugamuve commented on a change in pull request #11854:
URL: https://github.com/apache/arrow/pull/11854#discussion_r768798590



##########
File path: cpp/src/arrow/json/options.h
##########
@@ -65,6 +65,8 @@ struct ARROW_EXPORT ReadOptions {
   /// Block size we request from the IO layer; also determines the size of
   /// chunks when use_threads is true
   int32_t block_size = 1 << 20;  // 1 MB
+  /// weather we will use a separate thread for read ahead

Review comment:
       Done

##########
File path: cpp/src/arrow/csv/options.h
##########
@@ -166,6 +166,9 @@ struct ARROW_EXPORT ReadOptions {
   /// Create read options with default values
   static ReadOptions Defaults();
 
+  /// weather to use an IO thread to read ahead

Review comment:
       Done

##########
File path: cpp/src/arrow/csv/options.h
##########
@@ -166,6 +166,9 @@ struct ARROW_EXPORT ReadOptions {
   /// Create read options with default values
   static ReadOptions Defaults();
 
+  /// weather to use an IO thread to read ahead
+  bool use_read_ahead = false;

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org