[jira] [Resolved] (YUNIKORN-1908) Support GPU in placeholders

["Craig Condit (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YUNIKORN-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Condit resolved YUNIKORN-1908.
------------------------------------
    Fix Version/s: 1.4.0
       Resolution: Fixed

Merged to master.

> Support GPU in placeholders
> ---------------------------
>
>                 Key: YUNIKORN-1908
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1908
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: shim - kubernetes
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Wilfred Spiegelenburg
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.4.0
>
>
> When we create a placeholder pod we read the list of resources defined in the task group and add that as a list of resource Requests to the new pod.
> We do not check the content and just use the key as the resource type. This goes horribly wrong for taskgroups that contain extended resources like GPU requests.
> We need to change the placeholder creation to add a limit for all extended resources to prevent this error message: 
> {code:java}
> 2023-08-08T22:53:34.863Z        ERROR   cache/placeholder_manager.go:99 failed to create placeholder pod        {"error": "Pod \"tg-test-yunikorn-0\" is invalid: spec.containers[0].resources.limits: Required value: Limit must be set for non overcommitable resources"} {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org