You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2023/04/13 08:38:55 UTC

[Impala-ASF-CR] IMPALA-11974: Fix xrange call in collect minidumps.py

Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19727


Change subject: IMPALA-11974: Fix xrange call in collect_minidumps.py
......................................................................

IMPALA-11974: Fix xrange call in collect_minidumps.py

Python3 deprecates xrange operator, this commit replaces it with the new
range operator similar to earlier replacements in IMPALA-11974.

Testing:
 - Tested that Python3 parses this file successfully

Change-Id: I155725d8edac9222064c88912b19f0591c690afe
---
M bin/collect_minidumps.py
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/19727/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I155725d8edac9222064c88912b19f0591c690afe
Gerrit-Change-Number: 19727
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>

[Impala-ASF-CR] IMPALA-11974: Fix xrange call in collect minidumps.py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19727 )

Change subject: IMPALA-11974: Fix xrange call in collect_minidumps.py
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9225/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I155725d8edac9222064c88912b19f0591c690afe
Gerrit-Change-Number: 19727
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 13 Apr 2023 18:23:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11974: Fix xrange call in collect minidumps.py

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19727 )

Change subject: IMPALA-11974: Fix xrange call in collect_minidumps.py
......................................................................


Patch Set 2: Code-Review+2

This looks good to me, thanks for fixing this


-- 
To view, visit http://gerrit.cloudera.org:8080/19727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I155725d8edac9222064c88912b19f0591c690afe
Gerrit-Change-Number: 19727
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 13 Apr 2023 17:53:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11974: Fix xrange call in collect minidumps.py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19727 )

Change subject: IMPALA-11974: Fix xrange call in collect_minidumps.py
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12791/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I155725d8edac9222064c88912b19f0591c690afe
Gerrit-Change-Number: 19727
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 13 Apr 2023 17:53:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11974: Fix xrange call in collect minidumps.py

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19727 )

Change subject: IMPALA-11974: Fix xrange call in collect_minidumps.py
......................................................................

IMPALA-11974: Fix xrange call in collect_minidumps.py

Python3 deprecates xrange operator, this commit replaces it with the new
range operator similar to earlier replacements in IMPALA-11974.

Testing:
 - Tested that Python3 parses this file successfully

Change-Id: I155725d8edac9222064c88912b19f0591c690afe
---
M bin/collect_minidumps.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/19727/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I155725d8edac9222064c88912b19f0591c690afe
Gerrit-Change-Number: 19727
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>

[Impala-ASF-CR] IMPALA-11974: Fix xrange call in collect minidumps.py

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19727 )

Change subject: IMPALA-11974: Fix xrange call in collect_minidumps.py
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I155725d8edac9222064c88912b19f0591c690afe
Gerrit-Change-Number: 19727
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 13 Apr 2023 17:44:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11974: Fix xrange call in collect minidumps.py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19727 )

Change subject: IMPALA-11974: Fix xrange call in collect_minidumps.py
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I155725d8edac9222064c88912b19f0591c690afe
Gerrit-Change-Number: 19727
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 13 Apr 2023 23:53:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11974: Fix xrange call in collect minidumps.py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19727 )

Change subject: IMPALA-11974: Fix xrange call in collect_minidumps.py
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I155725d8edac9222064c88912b19f0591c690afe
Gerrit-Change-Number: 19727
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 13:58:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11974: Fix xrange call in collect minidumps.py

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19727 )

Change subject: IMPALA-11974: Fix xrange call in collect_minidumps.py
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19727/1/bin/collect_minidumps.py
File bin/collect_minidumps.py:

http://gerrit.cloudera.org:8080/#/c/19727/1/bin/collect_minidumps.py@28
PS1, Line 28: from builtins import range
> shell/compatibility.py has this:
Yes, that is a reasonable approach as well.



-- 
To view, visit http://gerrit.cloudera.org:8080/19727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I155725d8edac9222064c88912b19f0591c690afe
Gerrit-Change-Number: 19727
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 16:53:47 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11974: Fix xrange call in collect minidumps.py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19727 )

Change subject: IMPALA-11974: Fix xrange call in collect_minidumps.py
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12786/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I155725d8edac9222064c88912b19f0591c690afe
Gerrit-Change-Number: 19727
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 08:59:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11974: Fix xrange call in collect minidumps.py

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19727 )

Change subject: IMPALA-11974: Fix xrange call in collect_minidumps.py
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19727/1/bin/collect_minidumps.py
File bin/collect_minidumps.py:

http://gerrit.cloudera.org:8080/#/c/19727/1/bin/collect_minidumps.py@28
PS1, Line 28: from builtins import range
> "builtins" is a library provided by the PyPi future package, so it isn't in
shell/compatibility.py has this:

try:
  _xrange = xrange
except NameError:
  _xrange = range  # python3 compatibilty

And then it is being used like this:
shell/impala_client.py:from compatibility import _xrange as xrange
shell/impala_shell.py:from compatibility import _xrange as xrange



-- 
To view, visit http://gerrit.cloudera.org:8080/19727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I155725d8edac9222064c88912b19f0591c690afe
Gerrit-Change-Number: 19727
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 16:34:55 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11974: Fix xrange call in collect minidumps.py

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19727 )

Change subject: IMPALA-11974: Fix xrange call in collect_minidumps.py
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19727/1/bin/collect_minidumps.py
File bin/collect_minidumps.py:

http://gerrit.cloudera.org:8080/#/c/19727/1/bin/collect_minidumps.py@28
PS1, Line 28: from builtins import range
"builtins" is a library provided by the PyPi future package, so it isn't installed by default with plain Python. For this particular script, I'm not sure PyPi future will be installed consistently, and we don't want to have problems because it isn't installed.

I think the other option is to just use "range" without this import. On python2 it is less efficient, but that only comes up if it is constructing a very large list.



-- 
To view, visit http://gerrit.cloudera.org:8080/19727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I155725d8edac9222064c88912b19f0591c690afe
Gerrit-Change-Number: 19727
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 16:23:08 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11974: Fix xrange call in collect minidumps.py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19727 )

Change subject: IMPALA-11974: Fix xrange call in collect_minidumps.py
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9223/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/19727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I155725d8edac9222064c88912b19f0591c690afe
Gerrit-Change-Number: 19727
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 08:41:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11974: Fix xrange call in collect minidumps.py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19727 )

Change subject: IMPALA-11974: Fix xrange call in collect_minidumps.py
......................................................................

IMPALA-11974: Fix xrange call in collect_minidumps.py

Python3 deprecates xrange operator, this commit replaces it with the new
range operator similar to earlier replacements in IMPALA-11974.

Testing:
 - Tested that Python3 parses this file successfully

Change-Id: I155725d8edac9222064c88912b19f0591c690afe
Reviewed-on: http://gerrit.cloudera.org:8080/19727
Reviewed-by: Riza Suminto <ri...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/collect_minidumps.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Riza Suminto: Looks good to me, but someone else must approve
  Joe McDonnell: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I155725d8edac9222064c88912b19f0591c690afe
Gerrit-Change-Number: 19727
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>