You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Leslin (Hong Xiang Lin)" <le...@gmail.com> on 2012/06/21 02:13:28 UTC
Review Request: FLUME-1154: flume-ng script should first try finding java
from PATH and then try using bigtop, instead of vice-versa
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5466/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Change flume-ng script to find java from PATH first instead of using bigtop-detect-javahome to get when JAVA_HOME does not set. It will helpful in multi-java environment.
This addresses bug FLUME-1154.
https://issues.apache.org/jira/browse/FLUME-1154
Diffs
-----
bin/flume-ng 24a7d95
Diff: https://reviews.apache.org/r/5466/diff/
Testing
-------
test with normal start agent
Thanks,
Leslin (Hong Xiang Lin)
Re: Review Request: FLUME-1154: flume-ng script should first
try finding java from PATH and then try using bigtop, instead of
vice-versa
Posted by Mike Percy <mp...@cloudera.com>.
Hi Leslin! Done.
Best,
Mike
On Sunday, June 24, 2012 at 3:42 AM, Leslin wrote:
> Hi, Mike
>
> Would you help check in this patch as Will agree with latest patch?
> Thanks so much!
>
> Best Regards
> Leslin
>
> 2012/6/23 Will McQueen <will@cloudera.com (mailto:will@cloudera.com)>
>
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/5466/
> >
> > On June 22nd, 2012, 6:57 p.m., *Will McQueen* wrote:
> >
> > lgtm! Thanks Leslie.
> >
> > Sorry, I meant 'Leslin' :-)
> >
> >
> > - Will
> >
> > On June 22nd, 2012, 3:07 p.m., Leslin (Hong Xiang Lin) wrote:
> > Review request for Flume.
> > By Leslin (Hong Xiang Lin).
> >
> > *Updated June 22, 2012, 3:07 p.m.*
> > Description
> >
> > Change flume-ng script to find java from PATH first instead of using bigtop-detect-javahome to get when JAVA_HOME does not set. It will helpful in multi-java environment.
> >
> > Testing
> >
> > test with normal start agent
> >
> > *Bugs: * FLUME-1154 <https://issues.apache.org/jira/browse/FLUME-1154>
> > Diffs
> >
> > - bin/flume-ng (24a7d95)
> >
> > View Diff <https://reviews.apache.org/r/5466/diff/>
>
>
>
> --
>
>
>
> Best Regards
>
> Leslin
Re: Review Request: FLUME-1154: flume-ng script should first try
finding java from PATH and then try using bigtop, instead of vice-versa
Posted by Leslin <le...@gmail.com>.
Hi, Mike
Would you help check in this patch as Will agree with latest patch?
Thanks so much!
Best Regards
Leslin
2012/6/23 Will McQueen <wi...@cloudera.com>
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5466/
>
> On June 22nd, 2012, 6:57 p.m., *Will McQueen* wrote:
>
> lgtm! Thanks Leslie.
>
> Sorry, I meant 'Leslin' :-)
>
>
> - Will
>
> On June 22nd, 2012, 3:07 p.m., Leslin (Hong Xiang Lin) wrote:
> Review request for Flume.
> By Leslin (Hong Xiang Lin).
>
> *Updated June 22, 2012, 3:07 p.m.*
> Description
>
> Change flume-ng script to find java from PATH first instead of using bigtop-detect-javahome to get when JAVA_HOME does not set. It will helpful in multi-java environment.
>
> Testing
>
> test with normal start agent
>
> *Bugs: * FLUME-1154 <https://issues.apache.org/jira/browse/FLUME-1154>
> Diffs
>
> - bin/flume-ng (24a7d95)
>
> View Diff <https://reviews.apache.org/r/5466/diff/>
>
--
Best Regards
Leslin
Re: Review Request: FLUME-1154: flume-ng script should first try finding
java from PATH and then try using bigtop, instead of vice-versa
Posted by Will McQueen <wi...@cloudera.com>.
> On June 22, 2012, 6:57 p.m., Will McQueen wrote:
> > lgtm! Thanks Leslie.
Sorry, I meant 'Leslin' :-)
- Will
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5466/#review8490
-----------------------------------------------------------
On June 22, 2012, 3:07 p.m., Leslin (Hong Xiang Lin) wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5466/
> -----------------------------------------------------------
>
> (Updated June 22, 2012, 3:07 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Change flume-ng script to find java from PATH first instead of using bigtop-detect-javahome to get when JAVA_HOME does not set. It will helpful in multi-java environment.
>
>
> This addresses bug FLUME-1154.
> https://issues.apache.org/jira/browse/FLUME-1154
>
>
> Diffs
> -----
>
> bin/flume-ng 24a7d95
>
> Diff: https://reviews.apache.org/r/5466/diff/
>
>
> Testing
> -------
>
> test with normal start agent
>
>
> Thanks,
>
> Leslin (Hong Xiang Lin)
>
>
Re: Review Request: FLUME-1154: flume-ng script should first try
finding java from PATH and then try using bigtop, instead of vice-versa
Posted by Leslin <le...@gmail.com>.
Hi,
2012/6/23 Will McQueen <wi...@cloudera.com>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5466/#review8490
> -----------------------------------------------------------
>
> Ship it!
>
>
> lgtm! Thanks Leslie.
>
> - Will McQueen
>
>
> On June 22, 2012, 3:07 p.m., Leslin (Hong Xiang Lin) wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/5466/
> > -----------------------------------------------------------
> >
> > (Updated June 22, 2012, 3:07 p.m.)
> >
> >
> > Review request for Flume.
> >
> >
> > Description
> > -------
> >
> > Change flume-ng script to find java from PATH first instead of using
> bigtop-detect-javahome to get when JAVA_HOME does not set. It will helpful
> in multi-java environment.
> >
> >
> > This addresses bug FLUME-1154.
> > https://issues.apache.org/jira/browse/FLUME-1154
> >
> >
> > Diffs
> > -----
> >
> > bin/flume-ng 24a7d95
> >
> > Diff: https://reviews.apache.org/r/5466/diff/
> >
> >
> > Testing
> > -------
> >
> > test with normal start agent
> >
> >
> > Thanks,
> >
> > Leslin (Hong Xiang Lin)
> >
> >
>
>
--
Best Regards
Leslin
Re: Review Request: FLUME-1154: flume-ng script should first try finding
java from PATH and then try using bigtop, instead of vice-versa
Posted by Will McQueen <wi...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5466/#review8490
-----------------------------------------------------------
Ship it!
lgtm! Thanks Leslie.
- Will McQueen
On June 22, 2012, 3:07 p.m., Leslin (Hong Xiang Lin) wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5466/
> -----------------------------------------------------------
>
> (Updated June 22, 2012, 3:07 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Change flume-ng script to find java from PATH first instead of using bigtop-detect-javahome to get when JAVA_HOME does not set. It will helpful in multi-java environment.
>
>
> This addresses bug FLUME-1154.
> https://issues.apache.org/jira/browse/FLUME-1154
>
>
> Diffs
> -----
>
> bin/flume-ng 24a7d95
>
> Diff: https://reviews.apache.org/r/5466/diff/
>
>
> Testing
> -------
>
> test with normal start agent
>
>
> Thanks,
>
> Leslin (Hong Xiang Lin)
>
>
Re: Review Request: FLUME-1154: flume-ng script should first try finding
java from PATH and then try using bigtop, instead of vice-versa
Posted by "Leslin (Hong Xiang Lin)" <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5466/
-----------------------------------------------------------
(Updated June 22, 2012, 3:07 p.m.)
Review request for Flume.
Changes
-------
Update code with Will's comment, thanks Will so much!
3) With the new logic, this line is no longer relevant and can be removed:
[ -n "${JAVA_HOME}" ] || error "Unable to find a suitable JAVA_HOME" 1
4) Could you please use the new-style format, to change this:
JAVA_DEFAULT=`type -p java`
...into this:
JAVA_DEFAULT=$(type -p java)
Description
-------
Change flume-ng script to find java from PATH first instead of using bigtop-detect-javahome to get when JAVA_HOME does not set. It will helpful in multi-java environment.
This addresses bug FLUME-1154.
https://issues.apache.org/jira/browse/FLUME-1154
Diffs (updated)
-----
bin/flume-ng 24a7d95
Diff: https://reviews.apache.org/r/5466/diff/
Testing
-------
test with normal start agent
Thanks,
Leslin (Hong Xiang Lin)
Re: Review Request: FLUME-1154: flume-ng script should first try finding
java from PATH and then try using bigtop, instead of vice-versa
Posted by "Leslin (Hong Xiang Lin)" <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5466/
-----------------------------------------------------------
(Updated June 21, 2012, 5:07 a.m.)
Review request for Flume.
Description
-------
Change flume-ng script to find java from PATH first instead of using bigtop-detect-javahome to get when JAVA_HOME does not set. It will helpful in multi-java environment.
This addresses bug FLUME-1154.
https://issues.apache.org/jira/browse/FLUME-1154
Diffs (updated)
-----
bin/flume-ng 24a7d95
Diff: https://reviews.apache.org/r/5466/diff/
Testing
-------
test with normal start agent
Thanks,
Leslin (Hong Xiang Lin)
Re: Review Request: FLUME-1154: flume-ng script should first try finding
java from PATH and then try using bigtop, instead of vice-versa
Posted by "Leslin (Hong Xiang Lin)" <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5466/
-----------------------------------------------------------
(Updated June 21, 2012, 12:15 a.m.)
Review request for Flume.
Description
-------
Change flume-ng script to find java from PATH first instead of using bigtop-detect-javahome to get when JAVA_HOME does not set. It will helpful in multi-java environment.
This addresses bug FLUME-1154.
https://issues.apache.org/jira/browse/FLUME-1154
Diffs
-----
bin/flume-ng 24a7d95
Diff: https://reviews.apache.org/r/5466/diff/
Testing
-------
test with normal start agent
Thanks,
Leslin (Hong Xiang Lin)