You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by joaohf <gi...@git.apache.org> on 2016/11/09 20:18:58 UTC
[GitHub] nifi pull request #1196: NIFI-3014 GetSNMP add textual oid attribute to flow...
GitHub user joaohf opened a pull request:
https://github.com/apache/nifi/pull/1196
NIFI-3014 GetSNMP add textual oid attribute to flowfile
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
Signed-off-by: Jo�o Henrique Ferreira de Freitas <jo...@gmail.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joaohf/nifi NIFI-3014
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1196.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1196
----
commit e9d16763f9770ed4732069eca3c1f740f97dde55
Author: Jo�o Henrique Ferreira de Freitas <jo...@gmail.com>
Date: 2016-11-04T11:32:32Z
NIFI-3014 GetSNMP add textual oid attribute to flowfile
Signed-off-by: Jo�o Henrique Ferreira de Freitas <jo...@gmail.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1196: NIFI-3014 GetSNMP add textual oid attribute to flowfile
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1196
Added annotation regarding the new attribute and merged to master. Thanks @joaohf for your contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1196: NIFI-3014 GetSNMP add textual oid attribute to flowfile
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1196
Hi @joaohf, thanks for the PR. Do you agree that this will make sense if and only if we are doing a GET and not a WALK? Besides you will get the same result having an UpdateAttribute processor after the GetSNMP one, correct? (I am just trying to understand if I missing something here)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1196: NIFI-3014 GetSNMP add textual oid attribute to flow...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1196: NIFI-3014 GetSNMP add textual oid attribute to flowfile
Posted by joaohf <gi...@git.apache.org>.
Github user joaohf commented on the issue:
https://github.com/apache/nifi/pull/1196
Yes, you are right. I should document this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1196: NIFI-3014 GetSNMP add textual oid attribute to flowfile
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/1196
@joaohf @pvillard31 can you two work together to close this one out? Looks very close to being ready.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---