[GitHub] [spark] cloud-fan commented on a change in pull request #24117: [SPARK-27181][SQL]: Add public transform API

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #24117: [SPARK-27181][SQL]: Add public transform API
URL: https://github.com/apache/spark/pull/24117#discussion_r269259815
 
 

 ##########
 File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
 ##########
 @@ -578,6 +578,21 @@ namedExpressionSeq
     : namedExpression (',' namedExpression)*
     ;
 
+transformList
+    : '(' transforms+=transform (',' transforms+=transform)* ')'
+    ;
+
+transform
+    : qualifiedName                                                           #identityTransform
 
 Review comment:
   it's used in CREATE TABLE statement only, do we really need `qualifiedName`? I think `identifier` is good enough here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org