You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by "vinothchandar (via GitHub)" <gi...@apache.org> on 2025/05/22 23:16:14 UTC

Re: [PR] [MINOR] Optimizing metadata getter for metadata table [hudi]

vinothchandar commented on code in PR #13298:
URL: https://github.com/apache/hudi/pull/13298#discussion_r2103551304


##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/HoodieFlinkTable.java:
##########
@@ -100,6 +100,9 @@ protected HoodieIndex getIndex(HoodieWriteConfig config, HoodieEngineContext con
   protected Option<HoodieTableMetadataWriter> getMetadataWriter(
       String triggeringInstantTimestamp,
       HoodieFailedWritesCleaningPolicy failedWritesCleaningPolicy) {
+    if (isMetadataTable()) {
+      return Option.empty();

Review Comment:
   we should throw an error from here? so it never reaches this sort of condition?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org