You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/03/22 18:36:43 UTC
Re: Review Request 70168: Refactored SLRP with `ServiceManager` to
manage container lifecycles.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70168/
-----------------------------------------------------------
(Updated March 22, 2019, 6:36 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Squashed r/70169 into this patch.
Summary (updated)
-----------------
Refactored SLRP with `ServiceManager` to manage container lifecycles.
Bugs: MESOS-9632
https://issues.apache.org/jira/browse/MESOS-9632
Repository: mesos
Description (updated)
-------
Container management is moved out from SLRP to `ServiceManager`. It is
agnostic to CSI versions, so can be used to manage plugin containers for
both CSI v0 and v1 plugins.
This patch squashes the changes from r/70169.
Diffs (updated)
-----
src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2
src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07
src/csi/service_manager.hpp PRE-CREATION
src/csi/service_manager.cpp PRE-CREATION
src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70168/diff/8/
Changes: https://reviews.apache.org/r/70168/diff/7-8/
Testing
-------
Testing done later in chain.
Thanks,
Chun-Hung Hsiao
Re: Review Request 70168: Refactored SLRP with `ServiceManager` to
manage container lifecycles.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70168/#review214163
-----------------------------------------------------------
src/csi/service_manager.cpp
Lines 263 (patched)
<https://reviews.apache.org/r/70168/#comment300350>
Called `contains_value` now.
- Benjamin Bannier
On March 27, 2019, 6:51 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70168/
> -----------------------------------------------------------
>
> (Updated March 27, 2019, 6:51 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9632
> https://issues.apache.org/jira/browse/MESOS-9632
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Container management is moved out from SLRP to `ServiceManager`. It is
> agnostic to CSI versions, so can be used to manage plugin containers for
> both CSI v0 and v1 plugins.
>
> This patch squashes the changes from r/70169.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2
> src/Makefile.am bcafe48b2105575371464a29783bc6f3f1c2cf8d
> src/csi/service_manager.hpp PRE-CREATION
> src/csi/service_manager.cpp PRE-CREATION
> src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af
> src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
>
>
> Diff: https://reviews.apache.org/r/70168/diff/11/
>
>
> Testing
> -------
>
> Testing done later in chain.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70168: Refactored SLRP with `ServiceManager` to
manage container lifecycles.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70168/
-----------------------------------------------------------
(Updated April 2, 2019, 5:26 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Rebased and addressed Benjamin's comment.
Bugs: MESOS-9632
https://issues.apache.org/jira/browse/MESOS-9632
Repository: mesos
Description
-------
Container management is moved out from SLRP to `ServiceManager`. It is
agnostic to CSI versions, so can be used to manage plugin containers for
both CSI v0 and v1 plugins.
This patch squashes the changes from r/70169.
Diffs (updated)
-----
src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2
src/Makefile.am 7c2131a9daf16d49e8e8d75b12f019e5c4df1da3
src/csi/service_manager.hpp PRE-CREATION
src/csi/service_manager.cpp PRE-CREATION
src/resource_provider/storage/provider.cpp cc7944c73e24182ad9e5ec6f21b88d0f6f2974d5
src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70168/diff/12/
Changes: https://reviews.apache.org/r/70168/diff/11-12/
Testing
-------
Testing done later in chain.
Thanks,
Chun-Hung Hsiao
Re: Review Request 70168: Refactored SLRP with `ServiceManager` to
manage container lifecycles.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70168/
-----------------------------------------------------------
(Updated March 27, 2019, 5:51 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Fixed a clang 3.5 compilation issue.
Bugs: MESOS-9632
https://issues.apache.org/jira/browse/MESOS-9632
Repository: mesos
Description
-------
Container management is moved out from SLRP to `ServiceManager`. It is
agnostic to CSI versions, so can be used to manage plugin containers for
both CSI v0 and v1 plugins.
This patch squashes the changes from r/70169.
Diffs (updated)
-----
src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2
src/Makefile.am bcafe48b2105575371464a29783bc6f3f1c2cf8d
src/csi/service_manager.hpp PRE-CREATION
src/csi/service_manager.cpp PRE-CREATION
src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af
src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70168/diff/10/
Changes: https://reviews.apache.org/r/70168/diff/9-10/
Testing
-------
Testing done later in chain.
Thanks,
Chun-Hung Hsiao
Re: Review Request 70168: Refactored SLRP with `ServiceManager` to
manage container lifecycles.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70168/
-----------------------------------------------------------
(Updated March 26, 2019, 5 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Addressed Benjamin's comment and removed an unnecessary header inclusion.
Bugs: MESOS-9632
https://issues.apache.org/jira/browse/MESOS-9632
Repository: mesos
Description
-------
Container management is moved out from SLRP to `ServiceManager`. It is
agnostic to CSI versions, so can be used to manage plugin containers for
both CSI v0 and v1 plugins.
This patch squashes the changes from r/70169.
Diffs (updated)
-----
src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2
src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07
src/csi/service_manager.hpp PRE-CREATION
src/csi/service_manager.cpp PRE-CREATION
src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70168/diff/9/
Changes: https://reviews.apache.org/r/70168/diff/8-9/
Testing
-------
Testing done later in chain.
Thanks,
Chun-Hung Hsiao