You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Abhishek Rawat (Code Review)" <ge...@cloudera.org> on 2025/03/03 05:42:22 UTC
[Impala-ASF-CR] IMPALA-13817: Impala fails to start if 'ai endpoint' and 'ai additional platforms' are not set in the right order
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22567
Change subject: IMPALA-13817: Impala fails to start if 'ai_endpoint' and 'ai_additional_platforms' are not set in the right order
......................................................................
IMPALA-13817: Impala fails to start if 'ai_endpoint' and
'ai_additional_platforms' are not set in the right order
The 'ai_endpoint' flag has a validator which depends on
'ai_additional_platforms'. This could result in failure if the
'ai_additional_platforms' is not set before 'ai_endpoint' in the
flagfile.
This patch simplifies the validator for 'ai_endpoint' flag and moves
the supported platforms check to ExecEnv::Init.
Testing:
- Added unit tests for 'is_api_endpoint_supported' function.
Change-Id: I16480564ce434513ab73b531c03e1d229dac2dd6
---
M be/src/exprs/ai-functions-ir.cc
M be/src/exprs/ai-functions.cc
M be/src/exprs/ai-functions.h
M be/src/exprs/expr-test.cc
M be/src/runtime/exec-env.cc
5 files changed, 31 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/22567/2
--
To view, visit http://gerrit.cloudera.org:8080/22567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16480564ce434513ab73b531c03e1d229dac2dd6
Gerrit-Change-Number: 22567
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-13817: Impala fails to start if 'ai endpoint' and 'ai additional platforms' are not set in the right order
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22567 )
Change subject: IMPALA-13817: Impala fails to start if 'ai_endpoint' and 'ai_additional_platforms' are not set in the right order
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/22567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16480564ce434513ab73b531c03e1d229dac2dd6
Gerrit-Change-Number: 22567
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 03 Mar 2025 19:04:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13817: Impala fails to start if 'ai endpoint' and 'ai additional platforms' are not set in the right order
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22567 )
Change subject: IMPALA-13817: Impala fails to start if 'ai_endpoint' and 'ai_additional_platforms' are not set in the right order
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11556/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16480564ce434513ab73b531c03e1d229dac2dd6
Gerrit-Change-Number: 22567
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Mar 2025 23:14:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13817: Impala fails to start if 'ai endpoint' and 'ai additional platforms' are not set in the right order
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22567 )
Change subject: IMPALA-13817: Impala fails to start if 'ai_endpoint' and 'ai_additional_platforms' are not set in the right order
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16480564ce434513ab73b531c03e1d229dac2dd6
Gerrit-Change-Number: 22567
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 05 Mar 2025 04:41:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13817: Impala fails to start if 'ai endpoint' and 'ai additional platforms' are not set in the right order
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22567 )
Change subject: IMPALA-13817: Impala fails to start if 'ai_endpoint' and 'ai_additional_platforms' are not set in the right order
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18440/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16480564ce434513ab73b531c03e1d229dac2dd6
Gerrit-Change-Number: 22567
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 03 Mar 2025 06:08:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13817: Impala fails to start if 'ai endpoint' and 'ai additional platforms' are not set in the right order
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22567 )
Change subject: IMPALA-13817: Impala fails to start if 'ai_endpoint' and 'ai_additional_platforms' are not set in the right order
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16480564ce434513ab73b531c03e1d229dac2dd6
Gerrit-Change-Number: 22567
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Mar 2025 22:53:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13817: Impala fails to start if 'ai endpoint' and 'ai additional platforms' are not set in the right order
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22567 )
Change subject: IMPALA-13817: Impala fails to start if 'ai_endpoint' and 'ai_additional_platforms' are not set in the right order
......................................................................
IMPALA-13817: Impala fails to start if 'ai_endpoint' and
'ai_additional_platforms' are not set in the right order
The 'ai_endpoint' flag has a validator which depends on
'ai_additional_platforms'. This could result in failure if the
'ai_additional_platforms' is not set before 'ai_endpoint' in the
flagfile.
This patch simplifies the validator for 'ai_endpoint' flag and moves
the supported platforms check to ExecEnv::Init.
Testing:
- Added unit tests for 'is_api_endpoint_supported' function.
Change-Id: I16480564ce434513ab73b531c03e1d229dac2dd6
Reviewed-on: http://gerrit.cloudera.org:8080/22567
Reviewed-by: Yida Wu <wy...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exprs/ai-functions-ir.cc
M be/src/exprs/ai-functions.cc
M be/src/exprs/ai-functions.h
M be/src/exprs/expr-test.cc
M be/src/runtime/exec-env.cc
5 files changed, 33 insertions(+), 4 deletions(-)
Approvals:
Yida Wu: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/22567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I16480564ce434513ab73b531c03e1d229dac2dd6
Gerrit-Change-Number: 22567
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-13817: Impala fails to start if 'ai endpoint' and 'ai additional platforms' are not set in the right order
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22567 )
Change subject: IMPALA-13817: Impala fails to start if 'ai_endpoint' and 'ai_additional_platforms' are not set in the right order
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18465/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16480564ce434513ab73b531c03e1d229dac2dd6
Gerrit-Change-Number: 22567
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Mar 2025 21:37:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13817: Impala fails to start if 'ai endpoint' and 'ai additional platforms' are not set in the right order
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/22567 )
Change subject: IMPALA-13817: Impala fails to start if 'ai_endpoint' and 'ai_additional_platforms' are not set in the right order
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22567/2/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:
http://gerrit.cloudera.org:8080/#/c/22567/2/be/src/runtime/exec-env.cc@541
PS2, Line 541: if (FLAGS_ai_endpoint != "" &&
> nit. Can it be a single "if"? "if (!FLAGS_ai_endpoint != "" && !AiFunctions
Done
http://gerrit.cloudera.org:8080/#/c/22567/2/be/src/runtime/exec-env.cc@543
PS2, Line 543: ring supported_platforms = Substitute("$0, $1",
: AiFunctions::OPEN_AI_AZURE_ENDPOINT, AiFunctions::OPEN_AI_PUBLIC_ENDPOINT);
: if (!FLAGS_ai_additional_platforms.empty()) {
: supported_platforms += ", " + FLAGS_ai_additional_platforms;
> FLAGS_ai_additional_platforms can be empty, for better looking printing, ma
Done
--
To view, visit http://gerrit.cloudera.org:8080/22567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16480564ce434513ab73b531c03e1d229dac2dd6
Gerrit-Change-Number: 22567
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Mar 2025 21:10:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13817: Impala fails to start if 'ai endpoint' and 'ai additional platforms' are not set in the right order
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/22567 )
Change subject: IMPALA-13817: Impala fails to start if 'ai_endpoint' and 'ai_additional_platforms' are not set in the right order
......................................................................
IMPALA-13817: Impala fails to start if 'ai_endpoint' and
'ai_additional_platforms' are not set in the right order
The 'ai_endpoint' flag has a validator which depends on
'ai_additional_platforms'. This could result in failure if the
'ai_additional_platforms' is not set before 'ai_endpoint' in the
flagfile.
This patch simplifies the validator for 'ai_endpoint' flag and moves
the supported platforms check to ExecEnv::Init.
Testing:
- Added unit tests for 'is_api_endpoint_supported' function.
Change-Id: I16480564ce434513ab73b531c03e1d229dac2dd6
---
M be/src/exprs/ai-functions-ir.cc
M be/src/exprs/ai-functions.cc
M be/src/exprs/ai-functions.h
M be/src/exprs/expr-test.cc
M be/src/runtime/exec-env.cc
5 files changed, 33 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/22567/3
--
To view, visit http://gerrit.cloudera.org:8080/22567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I16480564ce434513ab73b531c03e1d229dac2dd6
Gerrit-Change-Number: 22567
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-13817: Impala fails to start if 'ai endpoint' and 'ai additional platforms' are not set in the right order
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22567 )
Change subject: IMPALA-13817: Impala fails to start if 'ai_endpoint' and 'ai_additional_platforms' are not set in the right order
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Looks good to me, minor things.
http://gerrit.cloudera.org:8080/#/c/22567/2/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:
http://gerrit.cloudera.org:8080/#/c/22567/2/be/src/runtime/exec-env.cc@541
PS2, Line 541: if (FLAGS_ai_endpoint != "") {
nit. Can it be a single "if"? "if (!FLAGS_ai_endpoint != "" && !AiFunctions::is_api_endpoint_supported(FLAGS_ai_endpoint))
http://gerrit.cloudera.org:8080/#/c/22567/2/be/src/runtime/exec-env.cc@543
PS2, Line 543: return Status(
: Substitute("Unsupported --ai_endpoint=$0, supported platforms are: $1, $2, $3",
: FLAGS_ai_endpoint, AiFunctions::OPEN_AI_AZURE_ENDPOINT,
: AiFunctions::OPEN_AI_PUBLIC_ENDPOINT, FLAGS_ai_additional_platforms));
FLAGS_ai_additional_platforms can be empty, for better looking printing, maybe also consider it?
string supported_platforms = Substitute("$0, $1", AiFunctions::OPEN_AI_AZURE_ENDPOINT, AiFunctions::OPEN_AI_PUBLIC_ENDPOINT);
if (!FLAGS_ai_additional_platforms.empty()) {
supported_platforms += ", " + FLAGS_ai_additional_platforms;
}
return Status(Substitute("Unsupported --ai_endpoint=$0, supported platforms: $1", FLAGS_ai_endpoint, supported_platforms));
--
To view, visit http://gerrit.cloudera.org:8080/22567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16480564ce434513ab73b531c03e1d229dac2dd6
Gerrit-Change-Number: 22567
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Mar 2025 03:51:28 +0000
Gerrit-HasComments: Yes