You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/08 03:35:01 UTC
[GitHub] [shardingsphere] Lucas-307 opened a new pull request #7310: Add shardingsphere-scaling-elasticjob module
Lucas-307 opened a new pull request #7310:
URL: https://github.com/apache/shardingsphere/pull/7310
Fixes #6743.
Changes proposed in this pull request:
- Add shardingsphere-scaling-elasticjob module
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7310: Add shardingsphere-scaling-elasticjob module
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7310:
URL: https://github.com/apache/shardingsphere/pull/7310#issuecomment-688606913
## Pull Request Test Coverage Report for [Build 14524](https://coveralls.io/builds/33292277)
* **6** of **95** **(6.32%)** changed or added relevant lines in **5** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage decreased (**-0.03%**) to **34.116%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/config/ScalingContext.java](https://coveralls.io/builds/33292277/source?filename=shardingsphere-scaling%2Fshardingsphere-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fscaling%2Fcore%2Fconfig%2FScalingContext.java#L66) | 3 | 4 | 75.0%
| [shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/spi/ElasticJobEntryLoader.java](https://coveralls.io/builds/33292277/source?filename=shardingsphere-scaling%2Fshardingsphere-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fscaling%2Fcore%2Fspi%2FElasticJobEntryLoader.java#L28) | 0 | 7 | 0.0%
| [shardingsphere-scaling/shardingsphere-scaling-elasticjob/src/main/java/org/apache/shardingsphere/scaling/elasticjob/job/ScalingElasticJob.java](https://coveralls.io/builds/33292277/source?filename=shardingsphere-scaling%2Fshardingsphere-scaling-elasticjob%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fscaling%2Felasticjob%2Fjob%2FScalingElasticJob.java#L33) | 0 | 21 | 0.0%
| [shardingsphere-scaling/shardingsphere-scaling-elasticjob/src/main/java/org/apache/shardingsphere/scaling/elasticjob/ScalingElasticJobEntry.java](https://coveralls.io/builds/33292277/source?filename=shardingsphere-scaling%2Fshardingsphere-scaling-elasticjob%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fscaling%2Felasticjob%2FScalingElasticJobEntry.java#L46) | 0 | 60 | 0.0%
<!-- | **Total:** | **6** | **95** | **6.32%** | -->
| Totals | [](https://coveralls.io/builds/33292277) |
| :-- | --: |
| Change from base [Build 14480](https://coveralls.io/builds/33275706): | -0.03% |
| Covered Lines: | 35450 |
| Relevant Lines: | 103910 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #7310: Add shardingsphere-scaling-elasticjob module
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #7310:
URL: https://github.com/apache/shardingsphere/pull/7310
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Lucas-307 commented on a change in pull request #7310: Add shardingsphere-scaling-elasticjob module
Posted by GitBox <gi...@apache.org>.
Lucas-307 commented on a change in pull request #7310:
URL: https://github.com/apache/shardingsphere/pull/7310#discussion_r484662996
##########
File path: shardingsphere-scaling/shardingsphere-scaling-bootstrap/src/main/resources/conf/server.yaml
##########
@@ -19,3 +19,8 @@ port: 8888
blockQueueSize: 10000
pushTimeout: 1000
workerThread: 30
+#name: elasticjob
+#registryCenter:
+# type: zookeeper
+# serverLists: localhost:2181
+# props:
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #7310: Add shardingsphere-scaling-elasticjob module
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #7310:
URL: https://github.com/apache/shardingsphere/pull/7310#discussion_r484639911
##########
File path: shardingsphere-scaling/shardingsphere-scaling-bootstrap/src/main/resources/conf/server.yaml
##########
@@ -19,3 +19,8 @@ port: 8888
blockQueueSize: 10000
pushTimeout: 1000
workerThread: 30
+#name: elasticjob
+#registryCenter:
+# type: zookeeper
+# serverLists: localhost:2181
+# props:
Review comment:
Need leave a blank line in the end of file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org