You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/09 23:28:59 UTC
[GitHub] [incubator-hudi] lamber-ken opened a new pull request #1205:
[HUDI-506] Optimize the new website based on feedback
lamber-ken opened a new pull request #1205: [HUDI-506] Optimize the new website based on feedback
URL: https://github.com/apache/incubator-hudi/pull/1205
## What is the purpose of the pull request
**Feedback Record** https://github.com/apache/incubator-hudi/issues/1196
- Fix some broken links in Quickstart.
- Reduce font size by one pixel in the new website.
- Chinese docs is a big work, not included.
BTW, ApacheCN helps finish the work of chinese translation, please visit https://hudi.apachecn.org/docs/0.5.0 .
## Brief change log
- Fix some broken links in Quickstart.
- Reduce font size by one pixel in the new website.
- Chinese docs is a big work, not included.
## Verify this pull request
This pull request is optimize work on the new website.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1205: [HUDI-506]
Optimize the new website based on feedback
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1205: [HUDI-506] Optimize the new website based on feedback
URL: https://github.com/apache/incubator-hudi/pull/1205#issuecomment-573394947
> This PR lgtm. Will merge shortly..
>
> Could we do the follow on changes in this way
>
> * 1 pr to remove `docs-tmp`
> * 1 pr to remove old `docs` (leaving the site as-is)
> * 1 pr to update the site content with new content only..
Got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1205: [HUDI-506]
Optimize the new website based on feedback
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1205: [HUDI-506] Optimize the new website based on feedback
URL: https://github.com/apache/incubator-hudi/pull/1205#issuecomment-573392072
> So this is just fixing a new things for new site and also porting over the chinese pages from old site? How does this work relate to the apachecn page?
>
> Side note: What purpose does `docs-tmp` solve.. We should make a plan to retire the old site and switch over to the new one early next week.. can you please outline the steps needed for that in a separate JIRA and we hash out a plan first.
Hi, @vinothchandar
1, ApacheCN page can help to promote hudi project, it's a additional work.
2, `docs-tmp` worked as a middle site role, it used to generate `/newsite-content` site, it can remove currently.
3, Here is my plan
- 1) Optimize the new website content based on feedback.
- 2) Replace old site docs with new docs.
- 3) Replace old content with new content.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1205:
[HUDI-506] Optimize the new website based on feedback
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on issue #1205: [HUDI-506] Optimize the new website based on feedback
URL: https://github.com/apache/incubator-hudi/pull/1205#issuecomment-573389085
hi @vinothchandar, thanks for your review.
I cleaned old site and tmp site files.
- 1, Remove `docs-tmp`, which is a middle docs contains `old-site` and `new-site`
- 2, Move `docs-new` to `docs`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar merged pull request #1205:
[HUDI-506] Optimize the new website based on feedback
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1205: [HUDI-506] Optimize the new website based on feedback
URL: https://github.com/apache/incubator-hudi/pull/1205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1205:
[HUDI-506] Optimize the new website based on feedback
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on issue #1205: [HUDI-506] Optimize the new website based on feedback
URL: https://github.com/apache/incubator-hudi/pull/1205#issuecomment-573392072
> So this is just fixing a new things for new site and also porting over the chinese pages from old site? How does this work relate to the apachecn page?
>
> Side note: What purpose does `docs-tmp` solve.. We should make a plan to retire the old site and switch over to the new one early next week.. can you please outline the steps needed for that in a separate JIRA and we hash out a plan first.
Hi, @vinothchandar
1, ApacheCN page can help to promote hudi project, it's a additional work.
2, `docs-tmp` worked as a middle site role, it used to generate `/newsite-content` site, it can be removed.
3, Here is my plan
- Optimize the new website content based on feedback.
- Remove `docs-tmp`
- Replace old site docs with new docs.
- Generate site based on new docs && Replace old content with new content.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1205: [HUDI-506]
Optimize the new website based on feedback
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1205: [HUDI-506] Optimize the new website based on feedback
URL: https://github.com/apache/incubator-hudi/pull/1205#issuecomment-573390865
hi @vinothchandar, thanks for your advice, all review comments are addressed and fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1205:
[HUDI-506] Optimize the new website based on feedback
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on issue #1205: [HUDI-506] Optimize the new website based on feedback
URL: https://github.com/apache/incubator-hudi/pull/1205#issuecomment-573392072
> So this is just fixing a new things for new site and also porting over the chinese pages from old site? How does this work relate to the apachecn page?
>
> Side note: What purpose does `docs-tmp` solve.. We should make a plan to retire the old site and switch over to the new one early next week.. can you please outline the steps needed for that in a separate JIRA and we hash out a plan first.
Hi, @vinothchandar
1, ApacheCN page can help to promote hudi project, it's a additional work.
2, `docs-tmp` worked as a middle site role, it used to generate `/newsite-content` site, it can be removed.
3, Here is my plan
- Optimize the new website content based on feedback.
- Replace old site docs with new docs.
- Replace old content with new content.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1205:
[HUDI-506] Optimize the new website based on feedback
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on issue #1205: [HUDI-506] Optimize the new website based on feedback
URL: https://github.com/apache/incubator-hudi/pull/1205#issuecomment-573392072
> So this is just fixing a new things for new site and also porting over the chinese pages from old site? How does this work relate to the apachecn page?
>
> Side note: What purpose does `docs-tmp` solve.. We should make a plan to retire the old site and switch over to the new one early next week.. can you please outline the steps needed for that in a separate JIRA and we hash out a plan first.
Hi, @vinothchandar
1, ApacheCN page can help to promote hudi project, it's a additional work.
2, `docs-tmp` worked as a middle site role, it used to generate `/newsite-content` site, it can be removed currently.
3, Here is my plan
- 1) Optimize the new website content based on feedback.
- 2) Replace old site docs with new docs.
- 3) Replace old content with new content.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1205:
[HUDI-506] Optimize the new website based on feedback
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on issue #1205: [HUDI-506] Optimize the new website based on feedback
URL: https://github.com/apache/incubator-hudi/pull/1205#issuecomment-573389085
hi @vinothchandar, thanks for your review. As your advice, all review comments are addressed and fixed.
I cleaned old site and tmp site files.
- 1, Remove `docs-tmp`, which is a middle docs contains `old-site` and `new-site`
- 2, Move `docs-new` to `docs`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1205:
[HUDI-506] Optimize the new website based on feedback
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on issue #1205: [HUDI-506] Optimize the new website based on feedback
URL: https://github.com/apache/incubator-hudi/pull/1205#issuecomment-573389085
hi @vinothchandar, thanks for your review.
I cleaned old site and tmp site files.
- 1, Remove `docs-tmp`, which is a middle docs contains `old-site` and `new-site`
- 2, Move `docs-new` to `docs`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1205: [HUDI-506]
Optimize the new website based on feedback
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1205: [HUDI-506] Optimize the new website based on feedback
URL: https://github.com/apache/incubator-hudi/pull/1205#issuecomment-573389085
@vinothchandar, thanks for your review.
I cleaned old site and tmp site files.
- 1, Remove `docs-tmp`, which is a middle docs contains `old-site` and `new-site`
- 2, Move `docs-new` to `docs`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services