You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "nmalin (via GitHub)" <gi...@apache.org> on 2024/10/10 12:12:37 UTC
[PR] Improved: Allow to use GroovyDsl in FlexibleStringExpander (OFBIZ-13133) [ofbiz-framework]
nmalin opened a new pull request, #839:
URL: https://github.com/apache/ofbiz-framework/pull/839
Second improvement on this functionality with increase the security by analyse each script to control the presence of potential code injection.
The regexp to control is a property: security.deniedScriptletsTokens.
If a script match the regexp, OFBiz raise in log an alert with the script and the script hash. The script is disabled and can't run.
If you have a safe script who is matched by the regexp, you can add the hash given by OFBiz on the property: security.allowedScriptletHashes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved: Allow to use GroovyDsl in FlexibleStringExpander (OFBIZ-13133) [ofbiz-framework]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #839:
URL: https://github.com/apache/ofbiz-framework/pull/839#issuecomment-2567579081
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved: Allow to use GroovyDsl in FlexibleStringExpander (OFBIZ-13133) [ofbiz-framework]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #839:
URL: https://github.com/apache/ofbiz-framework/pull/839#issuecomment-2405213189
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved: Allow to use GroovyDsl in FlexibleStringExpander (OFBIZ-13133) [ofbiz-framework]
Posted by "gilPts (via GitHub)" <gi...@apache.org>.
gilPts commented on code in PR #839:
URL: https://github.com/apache/ofbiz-framework/pull/839#discussion_r1795494799
##########
framework/base/src/main/java/org/apache/ofbiz/base/util/ScriptUtil.java:
##########
@@ -397,6 +407,61 @@ public static Class<?> parseScript(String language, String script) {
return scriptClass;
}
+ /**
+ * Analyse if we can run the script or need to block it due to potential security issue
+ * @param language
+ * @param script
+ * @return true is we can run the script
+ * @throws IOException
+ */
+ private static boolean isSafeScript(String language, String script) throws IOException {
+ HashSet<String> allowedScript = ALLOWED_SCRIPTS.putIfAbsentAndGet(language, initAllowedScriptHashes());
+ String scriptHash = HashCrypt.digestHash("SHA", script.getBytes());
+ boolean canExecuteScript = allowedScript.contains(scriptHash);
Review Comment:
```suggestion
boolean currentScriptAlreadyAllowed = allowedScript.contains(scriptHash);
```
##########
framework/base/src/main/java/org/apache/ofbiz/base/util/ScriptUtil.java:
##########
@@ -397,6 +407,61 @@ public static Class<?> parseScript(String language, String script) {
return scriptClass;
}
+ /**
+ * Analyse if we can run the script or need to block it due to potential security issue
+ * @param language
+ * @param script
+ * @return true is we can run the script
Review Comment:
```suggestion
* @return true if we can run the script
```
##########
framework/base/src/main/java/org/apache/ofbiz/base/util/ScriptUtil.java:
##########
@@ -397,6 +407,61 @@ public static Class<?> parseScript(String language, String script) {
return scriptClass;
}
+ /**
+ * Analyse if we can run the script or need to block it due to potential security issue
+ * @param language
+ * @param script
+ * @return true is we can run the script
+ * @throws IOException
+ */
+ private static boolean isSafeScript(String language, String script) throws IOException {
+ HashSet<String> allowedScript = ALLOWED_SCRIPTS.putIfAbsentAndGet(language, initAllowedScriptHashes());
+ String scriptHash = HashCrypt.digestHash("SHA", script.getBytes());
+ boolean canExecuteScript = allowedScript.contains(scriptHash);
+ if (!canExecuteScript) {
Review Comment:
```suggestion
if (!currentScriptAlreadyAllowed) {
```
##########
framework/base/src/main/java/org/apache/ofbiz/base/util/ScriptUtil.java:
##########
@@ -397,6 +407,61 @@ public static Class<?> parseScript(String language, String script) {
return scriptClass;
}
+ /**
+ * Analyse if we can run the script or need to block it due to potential security issue
+ * @param language
+ * @param script
+ * @return true is we can run the script
+ * @throws IOException
+ */
+ private static boolean isSafeScript(String language, String script) throws IOException {
+ HashSet<String> allowedScript = ALLOWED_SCRIPTS.putIfAbsentAndGet(language, initAllowedScriptHashes());
+ String scriptHash = HashCrypt.digestHash("SHA", script.getBytes());
+ boolean canExecuteScript = allowedScript.contains(scriptHash);
+ if (!canExecuteScript) {
+ if (!checkIfScriptIsSafe(script)) {
+ Debug.logWarning(String.format("Tried to execute unauthorized script \n **** \n%s\n **** "
+ + "\nif it's safe script you can add the following hash to security.allowedScriptlets: %s",
+ script, scriptHash), MODULE);
+ return false;
+ }
+ allowedScript.add(scriptHash);
+ }
+ return true;
+ }
+
+ /**
+ * if USEDENIEDSCRIPTLETSTOKENS is true check if content match the regexp DENIEDSCRIPTLETSTOKENS
+ * @param content
+ * @return true if the content doesn't match
+ * @throws IOException
+ */
+ public static boolean checkIfScriptIsSafe(String content) throws IOException {
+ if (content == null || !USEDENIEDSCRIPTLETSTOKENS) {
+ return true;
+ }
+ return !DENIEDSCRIPTLETSTOKENS.matcher(content).find();
+ }
+
+ /**
+ * Load the regExp for analyse script security
Review Comment:
```suggestion
* Load the regExp for security script analysis
```
##########
framework/base/src/main/java/org/apache/ofbiz/base/util/ScriptUtil.java:
##########
@@ -397,6 +407,61 @@ public static Class<?> parseScript(String language, String script) {
return scriptClass;
}
+ /**
+ * Analyse if we can run the script or need to block it due to potential security issue
+ * @param language
+ * @param script
+ * @return true is we can run the script
+ * @throws IOException
+ */
+ private static boolean isSafeScript(String language, String script) throws IOException {
+ HashSet<String> allowedScript = ALLOWED_SCRIPTS.putIfAbsentAndGet(language, initAllowedScriptHashes());
+ String scriptHash = HashCrypt.digestHash("SHA", script.getBytes());
+ boolean canExecuteScript = allowedScript.contains(scriptHash);
+ if (!canExecuteScript) {
+ if (!checkIfScriptIsSafe(script)) {
+ Debug.logWarning(String.format("Tried to execute unauthorized script \n **** \n%s\n **** "
+ + "\nif it's safe script you can add the following hash to security.allowedScriptlets: %s",
+ script, scriptHash), MODULE);
+ return false;
+ }
+ allowedScript.add(scriptHash);
+ }
+ return true;
+ }
+
+ /**
+ * if USEDENIEDSCRIPTLETSTOKENS is true check if content match the regexp DENIEDSCRIPTLETSTOKENS
+ * @param content
+ * @return true if the content doesn't match
+ * @throws IOException
+ */
+ public static boolean checkIfScriptIsSafe(String content) throws IOException {
+ if (content == null || !USEDENIEDSCRIPTLETSTOKENS) {
+ return true;
+ }
+ return !DENIEDSCRIPTLETSTOKENS.matcher(content).find();
+ }
+
+ /**
+ * Load the regExp for analyse script security
+ * @return Pattern init by the regExp security.deniedScriptletsTokens
+ */
+ private static Pattern initScriptletsTokensPattern() {
+ String deniedScriptletsTokens = UtilProperties.getPropertyValue("security", "deniedScriptletsTokens", "");
+ return Pattern.compile(deniedScriptletsTokens);
+ }
+
+ /**
+ * Load the list of script exception that we autorise to run despite the security risk
Review Comment:
```suggestion
* Load the list of script exceptions that are authorized to run despite the security risk
```
##########
framework/base/src/main/java/org/apache/ofbiz/base/util/ScriptUtil.java:
##########
@@ -397,6 +407,61 @@ public static Class<?> parseScript(String language, String script) {
return scriptClass;
}
+ /**
+ * Analyse if we can run the script or need to block it due to potential security issue
+ * @param language
+ * @param script
+ * @return true is we can run the script
+ * @throws IOException
+ */
+ private static boolean isSafeScript(String language, String script) throws IOException {
+ HashSet<String> allowedScript = ALLOWED_SCRIPTS.putIfAbsentAndGet(language, initAllowedScriptHashes());
+ String scriptHash = HashCrypt.digestHash("SHA", script.getBytes());
+ boolean canExecuteScript = allowedScript.contains(scriptHash);
+ if (!canExecuteScript) {
+ if (!checkIfScriptIsSafe(script)) {
+ Debug.logWarning(String.format("Tried to execute unauthorized script \n **** \n%s\n **** "
+ + "\nif it's safe script you can add the following hash to security.allowedScriptlets: %s",
+ script, scriptHash), MODULE);
+ return false;
+ }
+ allowedScript.add(scriptHash);
+ }
+ return true;
+ }
+
+ /**
+ * if USEDENIEDSCRIPTLETSTOKENS is true check if content match the regexp DENIEDSCRIPTLETSTOKENS
+ * @param content
+ * @return true if the content doesn't match
+ * @throws IOException
+ */
+ public static boolean checkIfScriptIsSafe(String content) throws IOException {
+ if (content == null || !USEDENIEDSCRIPTLETSTOKENS) {
+ return true;
+ }
+ return !DENIEDSCRIPTLETSTOKENS.matcher(content).find();
+ }
+
+ /**
+ * Load the regExp for analyse script security
+ * @return Pattern init by the regExp security.deniedScriptletsTokens
+ */
+ private static Pattern initScriptletsTokensPattern() {
+ String deniedScriptletsTokens = UtilProperties.getPropertyValue("security", "deniedScriptletsTokens", "");
+ return Pattern.compile(deniedScriptletsTokens);
+ }
+
+ /**
+ * Load the list of script exception that we autorise to run despite the security risk
+ * @return Pattern init by the regExp security.deniedScriptletsTokens
Review Comment:
```suggestion
* @return Pattern init by the regExp security.allowedScriptletHashes
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved: Allow to use GroovyDsl in FlexibleStringExpander (OFBIZ-13133) [ofbiz-framework]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #839:
URL: https://github.com/apache/ofbiz-framework/pull/839#issuecomment-2405213565
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved: Allow to use GroovyDsl in FlexibleStringExpander (OFBIZ-13133) [ofbiz-framework]
Posted by "nmalin (via GitHub)" <gi...@apache.org>.
nmalin commented on code in PR #839:
URL: https://github.com/apache/ofbiz-framework/pull/839#discussion_r1795569576
##########
framework/base/src/main/java/org/apache/ofbiz/base/util/ScriptUtil.java:
##########
@@ -397,6 +407,61 @@ public static Class<?> parseScript(String language, String script) {
return scriptClass;
}
+ /**
+ * Analyse if we can run the script or need to block it due to potential security issue
+ * @param language
+ * @param script
+ * @return true if we can run the script
+ * @throws IOException
+ */
+ private static boolean isSafeScript(String language, String script) throws IOException {
+ HashSet<String> allowedScript = ALLOWED_SCRIPTS.putIfAbsentAndGet(language, initAllowedScriptHashes());
+ String scriptHash = HashCrypt.digestHash("SHA", script.getBytes());
+ boolean currentScriptAlreadyAllowed = allowedScript.contains(scriptHash);
+ if (!currentScriptAlreadyAllowed) {
+ if (!checkIfScriptIsSafe(script)) {
+ Debug.logWarning(String.format("Tried to execute unauthorized script \n **** \n%s\n **** "
+ + "\nif it's safe script you can add the following hash to security.allowedScriptlets: %s",
+ script, scriptHash), MODULE);
+ return false;
+ }
+ allowedScript.add(scriptHash);
+ }
+ return true;
+ }
+
+ /**
+ * if USEDENIEDSCRIPTLETSTOKENS is true check if content match the regexp DENIEDSCRIPTLETSTOKENS
+ * @param content
+ * @return true if the content doesn't match
+ * @throws IOException
+ */
+ public static boolean checkIfScriptIsSafe(String content) throws IOException {
+ if (content == null || !USEDENIEDSCRIPTLETSTOKENS) {
+ return true;
+ }
+ return !DENIEDSCRIPTLETSTOKENS.matcher(content).find();
+ }
+
+ /**
+ * Load the regExp for security script analysis
+ * @return Pattern init by the regExp security.deniedScriptletsTokens
+ */
+ private static Pattern initScriptletsTokensPattern() {
+ String deniedScriptletsTokens = UtilProperties.getPropertyValue("security", "deniedScriptletsTokens", "");
+ return Pattern.compile(deniedScriptletsTokens);
+ }
+
+ /**
+ * Load the list of script exceptions that are authorized to run despite the security risk
+ * @return Pattern init by the regExp security.deniedScriptletsTokens
Review Comment:
```suggestion
* @return Allowed hashes List init by property security.allowedScriptletHashes
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved: Allow to use GroovyDsl in FlexibleStringExpander (OFBIZ-13133) [ofbiz-framework]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #839:
URL: https://github.com/apache/ofbiz-framework/pull/839#issuecomment-2419866197
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved: Allow to use GroovyDsl in FlexibleStringExpander (OFBIZ-13133) [ofbiz-framework]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #839:
URL: https://github.com/apache/ofbiz-framework/pull/839#issuecomment-2405213804
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved: Allow to use GroovyDsl in FlexibleStringExpander (OFBIZ-13133) [ofbiz-framework]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #839:
URL: https://github.com/apache/ofbiz-framework/pull/839#issuecomment-2405212057
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved: Allow to use GroovyDsl in FlexibleStringExpander (OFBIZ-13133) [ofbiz-framework]
Posted by "nmalin (via GitHub)" <gi...@apache.org>.
nmalin merged PR #839:
URL: https://github.com/apache/ofbiz-framework/pull/839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved: Allow to use GroovyDsl in FlexibleStringExpander (OFBIZ-13133) [ofbiz-framework]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #839:
URL: https://github.com/apache/ofbiz-framework/pull/839#issuecomment-2405212913
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved: Allow to use GroovyDsl in FlexibleStringExpander (OFBIZ-13133) [ofbiz-framework]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #839:
URL: https://github.com/apache/ofbiz-framework/pull/839#issuecomment-2407456823
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved: Allow to use GroovyDsl in FlexibleStringExpander (OFBIZ-13133) [ofbiz-framework]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #839:
URL: https://github.com/apache/ofbiz-framework/pull/839#issuecomment-2407747312
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved: Allow to use GroovyDsl in FlexibleStringExpander (OFBIZ-13133) [ofbiz-framework]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #839:
URL: https://github.com/apache/ofbiz-framework/pull/839#issuecomment-2506282952
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved: Allow to use GroovyDsl in FlexibleStringExpander (OFBIZ-13133) [ofbiz-framework]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #839:
URL: https://github.com/apache/ofbiz-framework/pull/839#issuecomment-2512153405
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improved: Allow to use GroovyDsl in FlexibleStringExpander (OFBIZ-13133) [ofbiz-framework]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #839:
URL: https://github.com/apache/ofbiz-framework/pull/839#issuecomment-2404926651
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=839&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=839&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=839)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org