You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2016/04/04 23:08:49 UTC
[GitHub] incubator-beam pull request: Fix JAXBCoder in the nested context
GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/116
Fix JAXBCoder in the nested context
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace "<Jira issue #>" in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
JAXBCoder in the nested context is broken with any coder that writes
content after the output of the XML stream, as decode will read the
entire remaining stream and fail.
In the nested context, prepend a long representing the size of the XML
while encoding, and limit the size of the returned stream while
decoding.
Replaces #112
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam jaxb_coder_nested
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
----
commit a11010b826acbe15f60bb2cc0df64bed81d4698c
Author: Thomas Groh <tg...@google.com>
Date: 2016-04-04T20:54:05Z
Fix JAXBCoder in the nested context
JAXBCoder in the nested context is broken with any coder that writes
content after the output of the XML stream, as decode will read the
entire remaining stream and fail.
In the nested context, prepend a long representing the size of the XML
while encoding, and limit the size of the returned stream while
decoding.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request: [BEAM-171] Fix JAXBCoder in the neste...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/116
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---