You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ramitkataria (via GitHub)" <gi...@apache.org> on 2025/05/27 17:48:38 UTC
[PR] Fix AWS `StopIteration` error in `variable_fetcher` when using remote executor [airflow]
ramitkataria opened a new pull request, #51127:
URL: https://github.com/apache/airflow/pull/51127
In `_get_test_name()` called by `set_env_id()`, the call stack is used to determine the name of the current test. After #50571, `set_env_id()` was being called from a `PythonOperator` (in addition to another call from the `SystemTestContextBuilder`) which changed the call stack to not include the name of the dag. As an example, here's all the files included in the call stack when called from `SystemTestContextBuilder`:
```
[
'/opt/airflow/providers/amazon/tests/system/amazon/aws/utils/__init__.py',
'/opt/airflow/providers/amazon/tests/system/amazon/aws/utils/__init__.py',
'/opt/airflow/providers/amazon/tests/system/amazon/aws/example_mwaa.py', '<frozen importlib._bootstrap>',
'<frozen importlib._bootstrap_external>', '/opt/airflow/airflow-core/src/airflow/models/dagbag.py',
'/opt/airflow/airflow-core/src/airflow/models/dagbag.py',
'/opt/airflow/airflow-core/src/airflow/models/dagbag.py',
'/opt/airflow/airflow-core/src/airflow/models/dagbag.py',
'/opt/airflow/airflow-core/src/airflow/models/dagbag.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/task_runner.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/task_runner.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/task_runner.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/supervisor.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/supervisor.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/supervisor.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/supervisor.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/supervisor.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/execute_workload.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/execute_workload.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/execute_workload.py', '<frozen runpy>',
'<frozen runpy>'
]
```
and from the `PythonOperator`:
```
[
'/opt/airflow/providers/amazon/tests/system/amazon/aws/utils/__init__.py',
'/opt/airflow/providers/amazon/tests/system/amazon/aws/utils/__init__.py',
'/opt/airflow/providers/amazon/tests/system/amazon/aws/utils/__init__.py',
'/opt/airflow/providers/amazon/tests/system/amazon/aws/utils/__init__.py',
'/opt/airflow/providers/amazon/tests/system/amazon/aws/utils/__init__.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/callback_runner.py',
'/opt/airflow/providers/standard/src/airflow/providers/standard/operators/python.py',
'/opt/airflow/providers/standard/src/airflow/providers/standard/operators/python.py',
'/opt/airflow/task-sdk/src/airflow/sdk/bases/operator.py',
'/opt/airflow/task-sdk/src/airflow/sdk/bases/decorator.py',
'/opt/airflow/task-sdk/src/airflow/sdk/bases/operator.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/task_runner.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/task_runner.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/task_runner.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/supervisor.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/supervisor.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/supervisor.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/supervisor.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/supervisor.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/execute_workload.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/execute_workload.py',
'/opt/airflow/task-sdk/src/airflow/sdk/execution_time/execute_workload.py', '<frozen runpy>',
'<frozen runpy>'
]
```
So the `StopIteration` error was being caused because it couldn't find the name of the test (in this case `example_mwaa`) in the call stack. This PR fixes this by using the test name already computed earlier in the `SystemTestContextBuilder`, in the `PythonOperator` for `variable_fetcher`.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Tests only] Fix `StopIteration` error in AWS System Test `variable_fetcher` when using remote executor [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas merged PR #51127:
URL: https://github.com/apache/airflow/pull/51127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test only. Fix `StopIteration` error in AWS System Test `variable_fetcher` when using remote executor [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #51127:
URL: https://github.com/apache/airflow/pull/51127#issuecomment-2916430670
> Please amend commit message to reflect this is about tests only. The commit message suggests this is a bug fix which may result in wrong tagging when preparing release. I raised #51132 for long term fix.
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Tests only] Fix `StopIteration` error in AWS System Test `variable_fetcher` when using remote executor [airflow]
Posted by "ramitkataria (via GitHub)" <gi...@apache.org>.
ramitkataria commented on PR #51127:
URL: https://github.com/apache/airflow/pull/51127#issuecomment-2917351991
@eladkal What do you think about the new commit message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org