[jira] [Comment Edited] (DOXIA-590) Either provided element class or default class gets ignored

["Michael Osipov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DOXIA-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539048#comment-17539048 ] 

Michael Osipov edited comment on DOXIA-590 at 5/18/22 7:57 PM:
---------------------------------------------------------------

So there are the spots need to be addressed:
 !image-2022-05-18-21-57-40-619.png!

[~fe2417], I do agree. In those places the semantics of the attribute needs to be retained since attributes are passed and the caller could have already supplied it. I will provide a PR for that.


was (Author: michael-o):
So there are the spots need to be addressed:
 !screenshot-1.png! 

[~fe2417], I do agree. In those places the semantics of the attribute needs to be retained since attributes are passed and the caller could have already supplied it. I will provide a PR for that.

> Either provided element class or default class gets ignored
> -----------------------------------------------------------
>
>                 Key: DOXIA-590
>                 URL: https://issues.apache.org/jira/browse/DOXIA-590
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.8
>            Reporter: Fred Eckertson
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 2.0.0-M3, 1.11.2
>
>         Attachments: image-2022-05-18-21-57-40-619.png
>
>
> The following construct is somewhat common in doxia-core
> att.addAttribute( Attribute.CLASS, "a" );
> The documentation says that basic attributes (including CLASS) are supported. However in cases like this either that "a" or the CLASS that was provided in the attributes parameter will be ignored. The correct way to do this is to append the provided CLASS to "a " if a CLASS attribute was provided.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)