You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/06 02:33:12 UTC
[GitHub] [flink] Sxnan opened a new pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Sxnan opened a new pull request #13073:
URL: https://github.com/apache/flink/pull/13073
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*This pull request make the SourceOperator send the Watermark.MAX_VALUE to the downstream when closing.*
## Brief change log
- *Send the Watermark.MAX_VALUE in the close method of SourceOperator
## Verifying this change
This change added tests and can be verified as follows:
- *Added test that validates that Watermark.MAX_VALUE is sent when closing*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13073:
URL: https://github.com/apache/flink/pull/13073#issuecomment-669650373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "145c86b135ee64462c449dacc81643ee8908e68b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5219",
"triggerID" : "145c86b135ee64462c449dacc81643ee8908e68b",
"triggerType" : "PUSH"
}, {
"hash" : "406f3764484bb5b004988002f620bd20c0c34fd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8494",
"triggerID" : "406f3764484bb5b004988002f620bd20c0c34fd6",
"triggerType" : "PUSH"
}, {
"hash" : "c7735c9b50701590dad4c52734ccae445419e4d6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8559",
"triggerID" : "c7735c9b50701590dad4c52734ccae445419e4d6",
"triggerType" : "PUSH"
}, {
"hash" : "b9756b68f7db097660ef4605275b67a6bdbcf3b4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8587",
"triggerID" : "b9756b68f7db097660ef4605275b67a6bdbcf3b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7735c9b50701590dad4c52734ccae445419e4d6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8559)
* b9756b68f7db097660ef4605275b67a6bdbcf3b4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8587)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Sxnan commented on a change in pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
Sxnan commented on a change in pull request #13073:
URL: https://github.com/apache/flink/pull/13073#discussion_r513334483
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java
##########
@@ -163,6 +164,7 @@ public void sendSourceEventToCoordinator(SourceEvent event) {
@Override
public void close() throws Exception {
eventTimeLogic.stopPeriodicWatermarkEmits();
+ currentMainOutput.emitWatermark(Watermark.MAX_WATERMARK);
Review comment:
Thanks for pointing out the problem and the detailed explaination. I have made the change at 406f376, please take a look.
I also think the the SourceoperatorStreamTask should override the `advanceToEndOfEventTime`. If @aljoscha can confirm that, I'd love to made that change in this pr as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13073:
URL: https://github.com/apache/flink/pull/13073#issuecomment-669650373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "145c86b135ee64462c449dacc81643ee8908e68b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5219",
"triggerID" : "145c86b135ee64462c449dacc81643ee8908e68b",
"triggerType" : "PUSH"
}, {
"hash" : "406f3764484bb5b004988002f620bd20c0c34fd6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8494",
"triggerID" : "406f3764484bb5b004988002f620bd20c0c34fd6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 406f3764484bb5b004988002f620bd20c0c34fd6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8494)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #13073:
URL: https://github.com/apache/flink/pull/13073#issuecomment-718485090
The changes look good. However there are some related test failures. Do you mind having a look at them @Sxnan ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13073:
URL: https://github.com/apache/flink/pull/13073#issuecomment-669650373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "145c86b135ee64462c449dacc81643ee8908e68b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5219",
"triggerID" : "145c86b135ee64462c449dacc81643ee8908e68b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 145c86b135ee64462c449dacc81643ee8908e68b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5219)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13073:
URL: https://github.com/apache/flink/pull/13073#issuecomment-669650373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "145c86b135ee64462c449dacc81643ee8908e68b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5219",
"triggerID" : "145c86b135ee64462c449dacc81643ee8908e68b",
"triggerType" : "PUSH"
}, {
"hash" : "406f3764484bb5b004988002f620bd20c0c34fd6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8494",
"triggerID" : "406f3764484bb5b004988002f620bd20c0c34fd6",
"triggerType" : "PUSH"
}, {
"hash" : "c7735c9b50701590dad4c52734ccae445419e4d6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8559",
"triggerID" : "c7735c9b50701590dad4c52734ccae445419e4d6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 406f3764484bb5b004988002f620bd20c0c34fd6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8494)
* c7735c9b50701590dad4c52734ccae445419e4d6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8559)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys edited a comment on pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
dawidwys edited a comment on pull request #13073:
URL: https://github.com/apache/flink/pull/13073#issuecomment-718485090
The changes look good. However there are some related test failures (`SourceOperatorEventTimeTest`). Do you mind having a look at them @Sxnan ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13073:
URL: https://github.com/apache/flink/pull/13073#issuecomment-669647740
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 145c86b135ee64462c449dacc81643ee8908e68b (Thu Aug 06 02:35:12 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18820).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #13073:
URL: https://github.com/apache/flink/pull/13073#discussion_r514150834
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/source/SourceOperatorEventTimeTest.java
##########
@@ -68,7 +68,8 @@ public void testMainOutputPeriodicWatermarks() throws Exception {
assertThat(result, contains(
new Watermark(100L),
- new Watermark(120L)
+ new Watermark(120L),
+ Watermark.MAX_WATERMARK
Review comment:
nit: Wrong indentation. I will fix it when merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13073:
URL: https://github.com/apache/flink/pull/13073#issuecomment-669650373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "145c86b135ee64462c449dacc81643ee8908e68b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5219",
"triggerID" : "145c86b135ee64462c449dacc81643ee8908e68b",
"triggerType" : "PUSH"
}, {
"hash" : "406f3764484bb5b004988002f620bd20c0c34fd6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8494",
"triggerID" : "406f3764484bb5b004988002f620bd20c0c34fd6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 145c86b135ee64462c449dacc81643ee8908e68b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5219)
* 406f3764484bb5b004988002f620bd20c0c34fd6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8494)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13073:
URL: https://github.com/apache/flink/pull/13073#issuecomment-669650373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "145c86b135ee64462c449dacc81643ee8908e68b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5219",
"triggerID" : "145c86b135ee64462c449dacc81643ee8908e68b",
"triggerType" : "PUSH"
}, {
"hash" : "406f3764484bb5b004988002f620bd20c0c34fd6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "406f3764484bb5b004988002f620bd20c0c34fd6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 145c86b135ee64462c449dacc81643ee8908e68b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5219)
* 406f3764484bb5b004988002f620bd20c0c34fd6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13073:
URL: https://github.com/apache/flink/pull/13073#issuecomment-669650373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "145c86b135ee64462c449dacc81643ee8908e68b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5219",
"triggerID" : "145c86b135ee64462c449dacc81643ee8908e68b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 145c86b135ee64462c449dacc81643ee8908e68b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5219)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys closed pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
dawidwys closed pull request #13073:
URL: https://github.com/apache/flink/pull/13073
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13073:
URL: https://github.com/apache/flink/pull/13073#issuecomment-717923105
Yes, what @dawidwys sounds correct! Please go for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13073:
URL: https://github.com/apache/flink/pull/13073#issuecomment-669650373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "145c86b135ee64462c449dacc81643ee8908e68b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5219",
"triggerID" : "145c86b135ee64462c449dacc81643ee8908e68b",
"triggerType" : "PUSH"
}, {
"hash" : "406f3764484bb5b004988002f620bd20c0c34fd6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8494",
"triggerID" : "406f3764484bb5b004988002f620bd20c0c34fd6",
"triggerType" : "PUSH"
}, {
"hash" : "c7735c9b50701590dad4c52734ccae445419e4d6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c7735c9b50701590dad4c52734ccae445419e4d6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 406f3764484bb5b004988002f620bd20c0c34fd6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8494)
* c7735c9b50701590dad4c52734ccae445419e4d6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13073:
URL: https://github.com/apache/flink/pull/13073#issuecomment-669650373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "145c86b135ee64462c449dacc81643ee8908e68b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5219",
"triggerID" : "145c86b135ee64462c449dacc81643ee8908e68b",
"triggerType" : "PUSH"
}, {
"hash" : "406f3764484bb5b004988002f620bd20c0c34fd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8494",
"triggerID" : "406f3764484bb5b004988002f620bd20c0c34fd6",
"triggerType" : "PUSH"
}, {
"hash" : "c7735c9b50701590dad4c52734ccae445419e4d6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8559",
"triggerID" : "c7735c9b50701590dad4c52734ccae445419e4d6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7735c9b50701590dad4c52734ccae445419e4d6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8559)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13073:
URL: https://github.com/apache/flink/pull/13073#issuecomment-669650373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "145c86b135ee64462c449dacc81643ee8908e68b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5219",
"triggerID" : "145c86b135ee64462c449dacc81643ee8908e68b",
"triggerType" : "PUSH"
}, {
"hash" : "406f3764484bb5b004988002f620bd20c0c34fd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8494",
"triggerID" : "406f3764484bb5b004988002f620bd20c0c34fd6",
"triggerType" : "PUSH"
}, {
"hash" : "c7735c9b50701590dad4c52734ccae445419e4d6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8559",
"triggerID" : "c7735c9b50701590dad4c52734ccae445419e4d6",
"triggerType" : "PUSH"
}, {
"hash" : "b9756b68f7db097660ef4605275b67a6bdbcf3b4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b9756b68f7db097660ef4605275b67a6bdbcf3b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7735c9b50701590dad4c52734ccae445419e4d6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8559)
* b9756b68f7db097660ef4605275b67a6bdbcf3b4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Sxnan commented on pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
Sxnan commented on pull request #13073:
URL: https://github.com/apache/flink/pull/13073#issuecomment-718343253
I have made the change accordingly. @dawidwys Please have another look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13073:
URL: https://github.com/apache/flink/pull/13073#issuecomment-669650373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "145c86b135ee64462c449dacc81643ee8908e68b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "145c86b135ee64462c449dacc81643ee8908e68b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 145c86b135ee64462c449dacc81643ee8908e68b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #13073:
URL: https://github.com/apache/flink/pull/13073#discussion_r512786339
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java
##########
@@ -163,6 +164,7 @@ public void sendSourceEventToCoordinator(SourceEvent event) {
@Override
public void close() throws Exception {
eventTimeLogic.stopPeriodicWatermarkEmits();
+ currentMainOutput.emitWatermark(Watermark.MAX_WATERMARK);
Review comment:
Unfortunately that will not work in the `BATCH` mode we will introduce shortly. In `BATCH` mode the `currentMainOutput` will ignore all watermarks. At the same time we should still emit `MAX_WATERMARK` in the `BATCH` mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org