[GitHub] [maven-surefire] NilsRenaud edited a comment on pull request #461: [SUREFIRE-1909] Replace --add-exports with --add-opens

[GitBox <gi...@apache.org>]

NilsRenaud edited a comment on pull request #461:
URL: https://github.com/apache/maven-surefire/pull/461#issuecomment-1034131508


   @Tibor17 : 
   
   > I have approved the CI. Now it is running. If it would pass successfully, we should obtain a new distinct integration test from you related to your use case. Would you have some spare time to write one? Thx
   
   Yes, I've updated the PR with a new integration test using this new option (not enabled by default as advised by @sormuras 
   
   > If you like adding a new config param, pls let's discuss the Javadoc with text and purpose of the parameter in prior of coding something. Thx
   
   Oops. I saw you message a bit too late. But I kept these changes in a separate commit for now, feel free to comment my code with your advices 
   
   > Pls name the title of the PR, Jira and commit same.
   
   I'll squash my commits in a single one with a correct name after your reviews, OK ?
   
   > Is it this IT maven-multimodule-project-with-jpms you are looking for?
   
   Nop, it's not related to multi modules, I've created a dedicated test with a single module tested by a non modularised tests
   
   > The open appears in the [documentation](https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/jpms.apt.vm#L196) and the [integration test](https://github.com/apache/maven-surefire/blob/master/surefire-its/src/test/resources/maven-multimodule-project-with-jpms/com.foo.impl/src/test/java/module-info.java#L20). If you remove the keyword open, would the test work? Pls try.
   
   It does not work without the open keyword. Since the tests are running in a module, I'm not sure it uses the same underlying ForkConfiguration though, but I've not investigated.
   
   I've added an integration test and a parameter usable directly from the XML file in the last version of this PR. Let me know what you think about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org