[GitHub] [kafka] cmccabe commented on a diff in pull request #14399: KAFKA-15466: Add KIP-919 support for some admin APIs

["cmccabe (via GitHub)" <gi...@apache.org>]

cmccabe commented on code in PR #14399:
URL: https://github.com/apache/kafka/pull/14399#discussion_r1333666076


##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -4009,12 +4134,11 @@ void handleFailure(Throwable throwable) {
 
     @Override
     public DescribeMetadataQuorumResult describeMetadataQuorum(DescribeMetadataQuorumOptions options) {
-        NodeProvider provider = new LeastLoadedNodeProvider();
-
         final KafkaFutureImpl<QuorumInfo> future = new KafkaFutureImpl<>();
         final long now = time.milliseconds();
         final Call call = new Call(
-                "describeMetadataQuorum", calcDeadlineMs(now, options.timeoutMs()), provider) {
+                "describeMetadataQuorum", calcDeadlineMs(now, options.timeoutMs()),
+                bc -> bc ? new ControllerNodeProvider() : new LeastLoadedNodeProvider()) {

Review Comment:
   bc = usingBootstrapControllers



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org