[GitHub] [lucene] uschindler edited a comment on pull request #335: LUCENE-10137: Refactor DirectReader and remove heavy code duplication

[GitBox <gi...@apache.org>]

uschindler edited a comment on pull request #335:
URL: https://github.com/apache/lucene/pull/335#issuecomment-931255937


   Hi,
   I will close this PR because with JDK 11 it is problematic.
   
   I improved the whole thing a bit by changing LongValues to be an interface instead of an abstract class, which made the DirectReader look like this:
   
   https://github.com/uschindler/lucene/blob/18e52b2b64bdc4020a32581935e0d44774aed39a/lucene/core/src/java/org/apache/lucene/util/packed/DirectReader.java
   
   As you see it is mush shorter and better readable, but for some reason it does not behave well yet. I will keep the other branch in my own repository for later investigation.
   
   The whole experiment is here: https://github.com/apache/lucene/compare/main...uschindler:jira/LUCENE-10137-v2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org