You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <mo...@yahoo.in> on 2013/03/05 03:31:14 UTC
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/
-----------------------------------------------------------
(Updated March 5, 2013, 2:31 a.m.)
Review request for oozie.
Changes
-------
Changed Event Handler Service to be pluggable for handling events via different dispatchers - i.e. job notifications via default JobDispatcher, and other types is configurable e.g. SLAEventDispatcher for SLA event notifications
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1209
WIP patch
This addresses bug OOZIE-1209.
https://issues.apache.org/jira/browse/OOZIE-1209
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1452586
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1452586
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1452586
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1452586
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1452586
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1452586
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1452586
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 1452586
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 1452586
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1452586
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1452586
trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1452586
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1452586
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1452586
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1452586
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionFailureEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionStartedEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionSuccessEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionWaitingEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/Event.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/EventDispatcher.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/JobEventDispatcher.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/SLAEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/SLAEventDispatcher.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobFailureEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobStartedEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobSuccessEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/CoordinatorEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/DummyCoordEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/DummyWFEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/SLAEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/WorkflowEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
trunk/core/src/main/resources/oozie-default.xml 1452586
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
Diff: https://reviews.apache.org/r/9602/diff/
Testing
-------
More unit tests to be added
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18444
-----------------------------------------------------------
great work.
just found one minor point below.
also one point is how to reflect user-level configuration whether to apply listener or not.
for instance, if one particular user don't need SLA email notification, (but rest of users need it, thus, assume EmailSLAListener included in event.listeners), can we switch to apply listener or not. probably EvenHandlerService is good place for that. JMS case, user filer can be pushed to selector on CMS.
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment38674>
need to call listener.init().
I believe the same for jobeventlistener.
- Ryota Egashira
On March 27, 2013, 10:05 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated March 27, 2013, 10:05 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/JobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1461403
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> More unit tests to be added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
> On March 27, 2013, 11:08 p.m., Mona Chitnis wrote:
> > Making a note of review comments
> > 1. Possibly rename "Status" in JobEvent class to "EventStatus" and the corresponding API to getEventStatus(), setEventStatus(), and retaining API getStatus(), setStatus() to "actual" job status.
> > 2. Refactor JobEvent and SLAEvent classes into client package (since listeners on the client side need status api)
3. Remove 'CREATED' from list of event statuses. We are not tracking notifications for coordinator action materialization as of now, as it will create lot of noise.
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18445
-----------------------------------------------------------
On March 27, 2013, 10:05 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated March 27, 2013, 10:05 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/JobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1461403
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> More unit tests to be added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18445
-----------------------------------------------------------
Making a note of review comments
1. Possibly rename "Status" in JobEvent class to "EventStatus" and the corresponding API to getEventStatus(), setEventStatus(), and retaining API getStatus(), setStatus() to "actual" job status.
2. Refactor JobEvent and SLAEvent classes into client package (since listeners on the client side need status api)
- Mona Chitnis
On March 27, 2013, 10:05 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated March 27, 2013, 10:05 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/JobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1461403
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> More unit tests to be added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mohammad Islam <mi...@yahoo.com>.
> On March 31, 2013, 9:23 a.m., Mohammad Islam wrote:
> > trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java, line 34
> > <https://reviews.apache.org/r/9602/diff/6/?file=276275#file276275line34>
> >
> > so many type and status. do we need so many thing?
> > it might confuse the people. Pls give a second thought in this line.
>
> Mona Chitnis wrote:
> Consolidating event types will offload burden on each event listener method to have a switch case and generate JMS/email notification based on status and app-type. We wanted to keep the listener code path as small as possible, hence the explicit enumeration of all event types at the beginning itself. People get a chance to filter on higher level values as well such as app-type and event-status, but each message's event-type will be specific for their benefit.
>
> Mohammad Islam wrote:
> Agreed from dev perspective. My concern is from user perspective. Does he/she will need to know all these different types/status. I prefer the user simplicity over code simplicity. If we have to write complex code to provide easiness to user, i think it is ok.
>
> For example, I want events for all WF jobs or I want all WF job that failed or all job that failed, it is beautiful if user doesn't need to where it is apptype or messagetype or eventtype or event status.
>
> Please consider from that philosophy.
>
>
> Virag Kothari wrote:
> All this different types are for better filtering of events and more selector options for the consumer
>
> For. e.g
> If the user wants all job notification but no sla, then he will do messageType='job'
> If the user cares about notifications only for workflow job, he can have 'appType=workflow_job'
> If the user cares only about notifications for failed jobs, he will have 'eventStatus=FAILURE'
> If the user cares about a particular event status for a particular job type, he can have 'eventType = appType + eventStatus (Workflow_job_failure)
>
> If we remove any one of this, the user can still use a combination of selectors but I dont think it is very flexible for the user.
> For. e.g if we remove appType and the user cares about notification only on workflow job, then he has to have
> eventtype='Workflow_job_start' or eventtype='workflow_job_failure' or eventtype='workflow_job_suspend' or eventtype='workflow_job_succeed'
> instead of just doing 'apptype=workflow_job'
>
> If we have proper documenation and examples related to the different selector options, do you think it may still be confusing for the user?
>
>
So many terminologies might confuse the user.
In another extreme, if user specifies only one thing such as job or workflow_job or FAILURE or workflow_job_failure. It will be the oozie's internal responsibility how to convert/map them to reply. In other words, there will be only one type and mapping will be internal.
I was/am basically confused about so many types. None of them is pretty obvious from a new user. May be you are discussing those many times and make sense to you.
I want to give user the similar filtration while maintaining the simplicity (if possible) as much as possible.
Providing documentation might not be a good sell. Because it will demand a very stiff learning curve. We already have that criticism against Oozie.
- Mohammad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18566
-----------------------------------------------------------
On April 3, 2013, 3:35 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated April 3, 2013, 3:35 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1463328
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1463328
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1463328
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1463328
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1463328
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
> On March 31, 2013, 9:23 a.m., Mohammad Islam wrote:
> > trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java, line 34
> > <https://reviews.apache.org/r/9602/diff/6/?file=276275#file276275line34>
> >
> > so many type and status. do we need so many thing?
> > it might confuse the people. Pls give a second thought in this line.
Consolidating event types will offload burden on each event listener method to have a switch case and generate JMS/email notification based on status and app-type. We wanted to keep the listener code path as small as possible, hence the explicit enumeration of all event types at the beginning itself. People get a chance to filter on higher level values as well such as app-type and event-status, but each message's event-type will be specific for their benefit.
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18566
-----------------------------------------------------------
On March 31, 2013, 6:07 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated March 31, 2013, 6:07 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1462882
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1462882
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/DummyJobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1462882
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1462882
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1462882
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mohammad Islam <mi...@yahoo.com>.
> On March 31, 2013, 9:23 a.m., Mohammad Islam wrote:
> > trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java, line 34
> > <https://reviews.apache.org/r/9602/diff/6/?file=276275#file276275line34>
> >
> > so many type and status. do we need so many thing?
> > it might confuse the people. Pls give a second thought in this line.
>
> Mona Chitnis wrote:
> Consolidating event types will offload burden on each event listener method to have a switch case and generate JMS/email notification based on status and app-type. We wanted to keep the listener code path as small as possible, hence the explicit enumeration of all event types at the beginning itself. People get a chance to filter on higher level values as well such as app-type and event-status, but each message's event-type will be specific for their benefit.
Agreed from dev perspective. My concern is from user perspective. Does he/she will need to know all these different types/status. I prefer the user simplicity over code simplicity. If we have to write complex code to provide easiness to user, i think it is ok.
For example, I want events for all WF jobs or I want all WF job that failed or all job that failed, it is beautiful if user doesn't need to where it is apptype or messagetype or eventtype or event status.
Please consider from that philosophy.
- Mohammad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18566
-----------------------------------------------------------
On March 31, 2013, 6:07 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated March 31, 2013, 6:07 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1462882
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1462882
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/DummyJobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1462882
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1462882
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1462882
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Virag Kothari <vi...@yahoo-inc.com>.
> On March 31, 2013, 9:23 a.m., Mohammad Islam wrote:
> > trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java, line 34
> > <https://reviews.apache.org/r/9602/diff/6/?file=276275#file276275line34>
> >
> > so many type and status. do we need so many thing?
> > it might confuse the people. Pls give a second thought in this line.
>
> Mona Chitnis wrote:
> Consolidating event types will offload burden on each event listener method to have a switch case and generate JMS/email notification based on status and app-type. We wanted to keep the listener code path as small as possible, hence the explicit enumeration of all event types at the beginning itself. People get a chance to filter on higher level values as well such as app-type and event-status, but each message's event-type will be specific for their benefit.
>
> Mohammad Islam wrote:
> Agreed from dev perspective. My concern is from user perspective. Does he/she will need to know all these different types/status. I prefer the user simplicity over code simplicity. If we have to write complex code to provide easiness to user, i think it is ok.
>
> For example, I want events for all WF jobs or I want all WF job that failed or all job that failed, it is beautiful if user doesn't need to where it is apptype or messagetype or eventtype or event status.
>
> Please consider from that philosophy.
>
All this different types are for better filtering of events and more selector options for the consumer
For. e.g
If the user wants all job notification but no sla, then he will do messageType='job'
If the user cares about notifications only for workflow job, he can have 'appType=workflow_job'
If the user cares only about notifications for failed jobs, he will have 'eventStatus=FAILURE'
If the user cares about a particular event status for a particular job type, he can have 'eventType = appType + eventStatus (Workflow_job_failure)
If we remove any one of this, the user can still use a combination of selectors but I dont think it is very flexible for the user.
For. e.g if we remove appType and the user cares about notification only on workflow job, then he has to have
eventtype='Workflow_job_start' or eventtype='workflow_job_failure' or eventtype='workflow_job_suspend' or eventtype='workflow_job_succeed'
instead of just doing 'apptype=workflow_job'
If we have proper documenation and examples related to the different selector options, do you think it may still be confusing for the user?
- Virag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18566
-----------------------------------------------------------
On April 1, 2013, 10:23 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated April 1, 2013, 10:23 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1462882
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1462882
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1462882
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1462882
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1462882
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/test/XEventTestCase.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18566
-----------------------------------------------------------
trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java
<https://reviews.apache.org/r/9602/#comment38916>
so many type and status. do we need so many thing?
it might confuse the people. Pls give a second thought in this line.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java
<https://reviews.apache.org/r/9602/#comment38917>
General comment:
If possible, reduce the # of such DB calls which are heavy weight.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java
<https://reviews.apache.org/r/9602/#comment38919>
The same line as mentioned before.
Consider a use-case: Oozie is not configured for any Event handling. But this type of DB access will be used.
My proposal :
1. Try to minimize this. Found already done few places.
2. If you have to call such, call it only if Event service is turned on. By default, this should not be called.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java
<https://reviews.apache.org/r/9602/#comment38918>
if event handler service is turned off, it will throw NPE.
Assumption: Event handler service is not must.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java
<https://reviews.apache.org/r/9602/#comment38920>
Add "&& misstep.length() > 0"
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java
<https://reviews.apache.org/r/9602/#comment38921>
same as before
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java
<https://reviews.apache.org/r/9602/#comment38922>
same logic as before for NPW.
- Mohammad Islam
On March 29, 2013, 3:35 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated March 29, 2013, 3:35 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1461403
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1461403
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1461403
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1461403
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> More unit tests to be added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Virag Kothari <vi...@yahoo-inc.com>.
> On April 1, 2013, 5:39 a.m., Virag Kothari wrote:
> > - SuspendX.suspend() should generate event for wf suspended state. This method is called when a transient error occurs and wf goes to SUSPENDED.
> >
> > - ActionCheckX.failAction() should generate wf Failed event.
> >
> > - CoordActionUpdatePushMissingDependency should generate waiting event
> >
> > - It seems that at some places like coordkill, coordinator job events are generated. But it seems at many other places, commands to generate coord job events are missed. If that is the case, plz remove event generating code for coordinator job and wf action. Can you only generate events for Workflow job and coordinator action in this patch and remove all other unused/commented code?
> >
> > - Have Javadoc
>
> Mona Chitnis wrote:
> - added generate event in SuspendX.suspendJob(). I was a little doubtful about this place because it does not do a DB update on the WF Job in/after the suspendJob() method.
>
> - In ActionCheckX , generateEvent is called in finally block, so failed wf case is handled
>
> - CoordActionUpdatePushMissingDependency calls CoordPushDependencyCheckXCommand.updateAction() and generateEvent is done there
discussed offline, ActionCheckX needs to generate event only in failure cases
> On April 1, 2013, 5:39 a.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java, line 100
> > <https://reviews.apache.org/r/9602/diff/7/?file=276754#file276754line100>
> >
> > I dont see the requirement for locking as the queue and currentsize is threadsafe and the combined operation need not be threadsafe in case of polling.
>
> Mona Chitnis wrote:
> The for loop execution for batchsize is assured to be correct if synchronized. Else one case I can think of different threads updating the index towards batchsize while polling events, and as a result, each thread polling more/less than batchSize events. I followed this pattern from our PriorityDelayQueue logic for Callables
discussed offline..no need for locking as batchsize is readonly variable and the index is local.
- Virag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18571
-----------------------------------------------------------
On April 1, 2013, 10:23 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated April 1, 2013, 10:23 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1462882
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1462882
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1462882
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1462882
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1462882
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/test/XEventTestCase.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
> On April 1, 2013, 5:39 a.m., Virag Kothari wrote:
> > - SuspendX.suspend() should generate event for wf suspended state. This method is called when a transient error occurs and wf goes to SUSPENDED.
> >
> > - ActionCheckX.failAction() should generate wf Failed event.
> >
> > - CoordActionUpdatePushMissingDependency should generate waiting event
> >
> > - It seems that at some places like coordkill, coordinator job events are generated. But it seems at many other places, commands to generate coord job events are missed. If that is the case, plz remove event generating code for coordinator job and wf action. Can you only generate events for Workflow job and coordinator action in this patch and remove all other unused/commented code?
> >
> > - Have Javadoc
- added generate event in SuspendX.suspendJob(). I was a little doubtful about this place because it does not do a DB update on the WF Job in/after the suspendJob() method.
- In ActionCheckX , generateEvent is called in finally block, so failed wf case is handled
- CoordActionUpdatePushMissingDependency calls CoordPushDependencyCheckXCommand.updateAction() and generateEvent is done there
> On April 1, 2013, 5:39 a.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/XCommand.java, line 524
> > <https://reviews.apache.org/r/9602/diff/7/?file=276732#file276732line524>
> >
> > It is better to evaluate eventsConfigured only once rather than during each method call
> > how about the following in Xcommand;
> >
> > protected static final boolean eventsConfigured = Services.get().get(EventHandlerService.class) != null;
thnx
> On April 1, 2013, 5:39 a.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java, line 50
> > <https://reviews.apache.org/r/9602/diff/7/?file=276748#file276748line50>
> >
> > is there any need for this? This just seems like user level suspend. ErrorCode and error message should be null
okay
> On April 1, 2013, 5:39 a.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java, line 100
> > <https://reviews.apache.org/r/9602/diff/7/?file=276754#file276754line100>
> >
> > I dont see the requirement for locking as the queue and currentsize is threadsafe and the combined operation need not be threadsafe in case of polling.
The for loop execution for batchsize is assured to be correct if synchronized. Else one case I can think of different threads updating the index towards batchsize while polling events, and as a result, each thread polling more/less than batchSize events. I followed this pattern from our PriorityDelayQueue logic for Callables
> On April 1, 2013, 5:39 a.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, line 83
> > <https://reviews.apache.org/r/9602/diff/7/?file=276760#file276760line83>
> >
> > the default value for CONF_LISTENERS should be already existing implementation of job and sla event listeners
> >
> > conf.getClasses(CONF_LISTENERS, jobJMSEvnetListener.class);
I mentioned in earlier comment that this change should be part of your JMS patch, otherwise I need to apply part of your patch to get the jmsjobeventlistener
> On April 1, 2013, 5:39 a.m., Virag Kothari wrote:
> > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java, line 90
> > <https://reviews.apache.org/r/9602/diff/7/?file=276765#file276765line90>
> >
> > assert for the expected attributes like status, errorcode and others, so we know for sure that events are generated with correct attributes.
> > same comment for all tests
ok todo
> On April 1, 2013, 5:39 a.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java, line 106
> > <https://reviews.apache.org/r/9602/diff/7/?file=276733#file276733line106>
> >
> > I think its better to filter to do
> > if (eventsConfigured) {generateEvent;}
> >
> > instead of filtering in generateEvent() method. That will save one function call.
ok TODO
> On April 1, 2013, 5:39 a.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java, line 215
> > <https://reviews.apache.org/r/9602/diff/7/?file=276734#file276734line215>
> >
> > It may happen that missingDeps is null but push missing deps exist, so we still want to generate event
> > can we do
> > if (coordAction.getStatus()!=READY)?
> >
let me check
> On April 1, 2013, 5:39 a.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java, line 255
> > <https://reviews.apache.org/r/9602/diff/7/?file=276741#file276741line255>
> >
> > should be generated if action not in ready
checking
> On April 1, 2013, 5:39 a.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java, line 229
> > <https://reviews.apache.org/r/9602/diff/7/?file=276744#file276744line229>
> >
> > ActionCheckX is called repeatedly by a service. It should only generate event when some status has changed.
good point. todo
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18571
-----------------------------------------------------------
On March 31, 2013, 6:07 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated March 31, 2013, 6:07 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1462882
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1462882
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/DummyJobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1462882
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1462882
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1462882
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
> On April 1, 2013, 5:39 a.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java, line 229
> > <https://reviews.apache.org/r/9602/diff/7/?file=276744#file276744line229>
> >
> > ActionCheckX is called repeatedly by a service. It should only generate event when some status has changed.
>
> Mona Chitnis wrote:
> good point. todo
Just checked. I believe, the precondition check for this command will fail itself if no status has changed i.e. wfAction.pending is false.
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18571
-----------------------------------------------------------
On March 31, 2013, 6:07 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated March 31, 2013, 6:07 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1462882
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1462882
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/DummyJobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1462882
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1462882
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1462882
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18571
-----------------------------------------------------------
- SuspendX.suspend() should generate event for wf suspended state. This method is called when a transient error occurs and wf goes to SUSPENDED.
- ActionCheckX.failAction() should generate wf Failed event.
- CoordActionUpdatePushMissingDependency should generate waiting event
- It seems that at some places like coordkill, coordinator job events are generated. But it seems at many other places, commands to generate coord job events are missed. If that is the case, plz remove event generating code for coordinator job and wf action. Can you only generate events for Workflow job and coordinator action in this patch and remove all other unused/commented code?
- Have Javadoc
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java
<https://reviews.apache.org/r/9602/#comment38934>
It is better to evaluate eventsConfigured only once rather than during each method call
how about the following in Xcommand;
protected static final boolean eventsConfigured = Services.get().get(EventHandlerService.class) != null;
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java
<https://reviews.apache.org/r/9602/#comment38946>
I think its better to filter to do
if (eventsConfigured) {generateEvent;}
instead of filtering in generateEvent() method. That will save one function call.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/9602/#comment38947>
It may happen that missingDeps is null but push missing deps exist, so we still want to generate event
can we do
if (coordAction.getStatus()!=READY)?
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
<https://reviews.apache.org/r/9602/#comment38948>
should be generated if action not in ready
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java
<https://reviews.apache.org/r/9602/#comment38949>
ActionCheckX is called repeatedly by a service. It should only generate event when some status has changed.
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java
<https://reviews.apache.org/r/9602/#comment38950>
is there any need for this? This just seems like user level suspend. ErrorCode and error message should be null
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java
<https://reviews.apache.org/r/9602/#comment38952>
I dont see the requirement for locking as the queue and currentsize is threadsafe and the combined operation need not be threadsafe in case of polling.
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java
<https://reviews.apache.org/r/9602/#comment38951>
this will throw NPE if no event to poll
trunk/core/src/main/java/org/apache/oozie/event/listener/DummyJobEventListener.java
<https://reviews.apache.org/r/9602/#comment38953>
if its required for unit testing, can you make this a inner class in the test case
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment38954>
the default value for CONF_LISTENERS should be already existing implementation of job and sla event listeners
conf.getClasses(CONF_LISTENERS, jobJMSEvnetListener.class);
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java
<https://reviews.apache.org/r/9602/#comment38955>
assert for the expected attributes like status, errorcode and others, so we know for sure that events are generated with correct attributes.
same comment for all tests
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java
<https://reviews.apache.org/r/9602/#comment38956>
Junit expectes the first parameter of assertEquals to be the expected value and the next one to be actual
- Virag Kothari
On March 31, 2013, 6:07 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated March 31, 2013, 6:07 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1462882
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1462882
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/DummyJobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1462882
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1462882
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1462882
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18678
-----------------------------------------------------------
I have also performed a dry-run by mkdistro and running examples. With defaults, no events are seen. With "services.ext" set to "EventHandlerService", the proper LOG info is seen on initialization with event queue, listener and number of worker threads. More end-to-end testing when the Scheduler Service threads actually pick up events will be later on
- Mona Chitnis
On April 4, 2013, 12:28 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated April 4, 2013, 12:28 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1463328
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1463328
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1463328
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1463328
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1463328
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18823
-----------------------------------------------------------
Looks good.
very few comments.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java
<https://reviews.apache.org/r/9602/#comment39280>
if missdep and pushmissdep is null,
this will wind up as 'null#null'
Have a variable upfront checking for null before doing string append.
in your test case, assert for missdep is null for any event other than waiting
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java
<https://reviews.apache.org/r/9602/#comment39282>
Event shoud'nt be null.
In any case, NPE should be avoided instead of having it being handled.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
<https://reviews.apache.org/r/9602/#comment39285>
it would be good to do the same way as you were doing previously of having a static method in EHS to check whether events are configured or not.
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java
<https://reviews.apache.org/r/9602/#comment39284>
errorMessage=msg
it will be good to assert for all event attributes to prevent such tiny things which are difficult to catch.
assert("errorMsg", event.getErrorMessage())
- Virag Kothari
On April 8, 2013, 9:56 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated April 8, 2013, 9:56 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1465571
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1465571
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1465571
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java 1465571
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1465571
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java 1465571
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java 1465571
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1465571
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1465571
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1465571
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18822
-----------------------------------------------------------
Ship it!
+1
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
<https://reviews.apache.org/r/9602/#comment39278>
Minor comment:
It appears the same condition check are done in most of the command. Can we make a new method in XCommand.java some method (or variable) boolean isEventEnabled();
It will improve the code readability and compactness.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
<https://reviews.apache.org/r/9602/#comment39279>
Minor comment:
It appears the same condition check are done in most of the command. Can we make a new method in XCommand.java some method (or variable) boolean isEventEnabled();
It will improve the code readability and compactness.
- Mohammad Islam
On April 8, 2013, 9:56 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated April 8, 2013, 9:56 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1465571
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1465571
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1465571
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1465571
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java 1465571
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1465571
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java 1465571
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java 1465571
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1465571
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1465571
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1465571
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
> On April 9, 2013, 9:52 a.m., Virag Kothari wrote:
> > +1..Good work
> > Before committing, have Junit4 annotations for all new test cases(@Test, @Before, @After)
done. thanks
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18841
-----------------------------------------------------------
On April 9, 2013, 8:17 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated April 9, 2013, 8:17 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1465918
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1465918
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1465918
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java 1465918
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1465918
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java 1465918
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java 1465918
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1465918
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1465918
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1465918
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18841
-----------------------------------------------------------
+1..Good work
Before committing, have Junit4 annotations for all new test cases(@Test, @Before, @After)
- Virag Kothari
On April 9, 2013, 8:17 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated April 9, 2013, 8:17 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1465918
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1465918
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1465918
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1465918
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java 1465918
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1465918
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java 1465918
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java 1465918
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1465918
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1465918
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1465918
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/
-----------------------------------------------------------
(Updated April 9, 2013, 8:17 a.m.)
Review request for oozie.
Changes
-------
Final patch for Mohammad's and Virag's comments. Mohammad, I addressed your final question by resorting to my earlier approach of a static method isEventsConfigured in the Event Service class itself
Also, added 2 more tests to check more event attributes thoroughly
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1209
WIP patch
This addresses bug OOZIE-1209.
https://issues.apache.org/jira/browse/OOZIE-1209
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1465918
trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1465918
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1465918
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1465918
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1465918
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1465918
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1465918
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1465918
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1465918
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1465918
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1465918
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1465918
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1465918
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1465918
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1465918
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1465918
trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1465918
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1465918
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1465918
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1465918
trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java 1465918
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1465918
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java 1465918
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java 1465918
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1465918
trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
trunk/core/src/main/resources/oozie-default.xml 1465918
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1465918
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
Diff: https://reviews.apache.org/r/9602/diff/
Testing
-------
unit tests added
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/
-----------------------------------------------------------
(Updated April 8, 2013, 9:56 a.m.)
Review request for oozie.
Changes
-------
fixed a small NPE from previous patch
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1209
WIP patch
This addresses bug OOZIE-1209.
https://issues.apache.org/jira/browse/OOZIE-1209
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1465571
trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1465571
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1465571
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java 1465571
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1465571
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java 1465571
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java 1465571
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1465571
trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
trunk/core/src/main/resources/oozie-default.xml 1465571
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1465571
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
Diff: https://reviews.apache.org/r/9602/diff/
Testing
-------
unit tests added
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/
-----------------------------------------------------------
(Updated April 8, 2013, 9:02 a.m.)
Review request for oozie.
Changes
-------
rebased again to trunk head. Also note for patch - modified JPA queries to include nominal-time and created (start) time for Coordinator actions. It would not be wise to fetch missing dependencies from each of those queries too, even though the event looks for setting them - they would simply be null in events other than from CoordActionInputCheck
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1209
WIP patch
This addresses bug OOZIE-1209.
https://issues.apache.org/jira/browse/OOZIE-1209
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1465571
trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1465571
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1465571
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1465571
trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java 1465571
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1465571
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java 1465571
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java 1465571
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1465571
trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
trunk/core/src/main/resources/oozie-default.xml 1465571
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1465571
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
Diff: https://reviews.apache.org/r/9602/diff/
Testing
-------
unit tests added
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/
-----------------------------------------------------------
(Updated April 8, 2013, 8:55 a.m.)
Review request for oozie.
Changes
-------
Addressed final set of review comments from Mohammad and Virag
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1209
WIP patch
This addresses bug OOZIE-1209.
https://issues.apache.org/jira/browse/OOZIE-1209
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1464795
trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1464795
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1464795
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java 1464795
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1464795
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java 1464795
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java 1464795
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1464795
trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
trunk/core/src/main/resources/oozie-default.xml 1464795
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1464795
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
Diff: https://reviews.apache.org/r/9602/diff/
Testing
-------
unit tests added
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
> On April 5, 2013, 8:35 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java, line 68
> > <https://reviews.apache.org/r/9602/diff/12/?file=278132#file278132line68>
> >
> > Is this for "TIMEOUT" state? If not, for all other states, missing dependency is not needed, right?
> >
also sending event for WAITING state, when there is change in the missing dependencies. so need this for 2 types of events
> On April 5, 2013, 8:35 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java, line 48
> > <https://reviews.apache.org/r/9602/diff/12/?file=278138#file278138line48>
> >
> > there are 3 statuses of type Status, jobStatus, eventStatus.
> > The method set which status. I think it is eventStatus. In that case, the method name could be better "setEventStatus".
> > Is this an override method? if yes, please use "@override"
> >
It sets the actual job status first, and eventStatus as an addition. But fixed the variable above it to be named 'status' and not jobStatus <- typo.
> On April 5, 2013, 8:35 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java, line 58
> > <https://reviews.apache.org/r/9602/diff/12/?file=278140#file278140line58>
> >
> > there is another status called "PREP_SUSPEND"
> > Do we need to do anything?
yes that is similar to SUSPEND in behavior. adding it too. thanks!
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18694
-----------------------------------------------------------
On April 5, 2013, 12:20 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated April 5, 2013, 12:20 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1464795
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1464795
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1464795
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1464795
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1464795
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18694
-----------------------------------------------------------
Very good progress.
Most of them are minor comments.
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java
<https://reviews.apache.org/r/9602/#comment39115>
if not needed, please remove this.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java
<https://reviews.apache.org/r/9602/#comment39117>
Please use if {
}
Also do we need to this if? is there any possibility of null?
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java
<https://reviews.apache.org/r/9602/#comment39118>
Is this for "TIMEOUT" state? If not, for all other states, missing dependency is not needed, right?
trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java
<https://reviews.apache.org/r/9602/#comment39119>
there are 3 statuses of type Status, jobStatus, eventStatus.
The method set which status. I think it is eventStatus. In that case, the method name could be better "setEventStatus".
Is this an override method? if yes, please use "@override"
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java
<https://reviews.apache.org/r/9602/#comment39121>
there is another status called "PREP_SUSPEND"
Do we need to do anything?
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java
<https://reviews.apache.org/r/9602/#comment39120>
is it required? the line can be moved in after line 61.
minor stuffs.
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment39122>
it is very long line. did u apply the formatting?
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment39124>
any use of this variable (listeners)? one use could be "null" chking.
if not combine line 172 & 173.
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment39128>
Does it need to be class level variable? what about declare it in run() {}.
Also make it something more meaningful "workList".
these are minor comments!!!
- Mohammad Islam
On April 5, 2013, 12:20 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated April 5, 2013, 12:20 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1464795
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1464795
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1464795
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1464795
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1464795
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
> On April 5, 2013, 8:45 a.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, line 129
> > <https://reviews.apache.org/r/9602/diff/12/?file=278147#file278147line129>
> >
> > wrong logic
> > if (listenerlist==null){
> > listenersList = new ArrayList();
> > map.put(..,..);
> > }
> > listenersList.add(listener)
> >
> > same comment for slaeventlistener
> >
> >
> >
Order does not matter. List added to map in previous line carries a reference, and second line (list.add) manipulates the pointer. So change is reflected.
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18693
-----------------------------------------------------------
On April 5, 2013, 12:20 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated April 5, 2013, 12:20 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1464795
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1464795
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1464795
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1464795
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1464795
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18693
-----------------------------------------------------------
In some places for generating coordinator action event, the queries need to be updated. For. e.g we are doing coordAction.getCreatedTime() while constructing the event, but the the coordaction might not have that attribute and jpa query need to be updated to account for that.
To ensure that we dont miss cases like this, it would be good to have testcases which check for each and every attributes which are used in constructing the event.
trunk/client/src/main/java/org/apache/oozie/client/event/Event.java
<https://reviews.apache.org/r/9602/#comment39101>
remove this and above javadoc
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java
<https://reviews.apache.org/r/9602/#comment39102>
remove
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java
<https://reviews.apache.org/r/9602/#comment39103>
remove
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java
<https://reviews.apache.org/r/9602/#comment39104>
coord job shouldn't be null, remove this condition
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/9602/#comment39105>
seems the change is not required.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java
<https://reviews.apache.org/r/9602/#comment39106>
user and appname need to be set in constructor otherwise it will be null
Can we please have a test case for this?
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java
<https://reviews.apache.org/r/9602/#comment39107>
coord job shouldnt be null
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java
<https://reviews.apache.org/r/9602/#comment39108>
if pushMissDep is null
this would wind up as HCAT:null
I dont think we need HDFS or HCAT as prependers.
We should emulate OozieCLI to preserve consistency
basically missdep+Instace_seperator+pushMissdep
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java
<https://reviews.apache.org/r/9602/#comment39109>
can we obtain a reference to EHS during class loading and use to avoid this get() everytime?
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java
<https://reviews.apache.org/r/9602/#comment39110>
same as above
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java
<https://reviews.apache.org/r/9602/#comment39111>
same comment as before for having single ref
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java
<https://reviews.apache.org/r/9602/#comment39112>
same comment
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java
<https://reviews.apache.org/r/9602/#comment39114>
should we have debug instead of info?
asking as we can have lot of events/sec
Same comment for all events
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java
<https://reviews.apache.org/r/9602/#comment39113>
I thought we had an agreement on passing the actual job's end time instead of new Date() to have a consistency between job and event's end time.
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment39116>
wrong logic
if (listenerlist==null){
listenersList = new ArrayList();
map.put(..,..);
}
listenersList.add(listener)
same comment for slaeventlistener
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment39123>
what is the concept behind schedThreads and workerThreads?
These variables are unused.
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment39125>
setAppTypes
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment39126>
getAppTypes
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment39127>
it seems it would be better to check for empty queue without polling in batch first
- Virag Kothari
On April 5, 2013, 12:20 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated April 5, 2013, 12:20 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1464795
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1464795
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1464795
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1464795
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1464795
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18744
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment39164>
My comment was not referring to order.
This wont add multiple listeners as only the first time listenerlist will be null. The condition when list is not null is not handled.
- Virag Kothari
On April 5, 2013, 12:20 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated April 5, 2013, 12:20 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1464795
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1464795
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1464795
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1464795
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1464795
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18759
-----------------------------------------------------------
Is there any new update based on recent comments? I would like to close it ASAP.
- Mohammad Islam
On April 5, 2013, 12:20 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated April 5, 2013, 12:20 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1464795
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1464795
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1464795
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1464795
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1464795
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1464795
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/
-----------------------------------------------------------
(Updated April 5, 2013, 12:20 a.m.)
Review request for oozie.
Changes
-------
patch rebased to trunk head
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1209
WIP patch
This addresses bug OOZIE-1209.
https://issues.apache.org/jira/browse/OOZIE-1209
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1464795
trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1464795
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1464795
trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1464795
trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
trunk/core/src/main/resources/oozie-default.xml 1464795
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1464795
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
Diff: https://reviews.apache.org/r/9602/diff/
Testing
-------
unit tests added
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/
-----------------------------------------------------------
(Updated April 4, 2013, 11:04 p.m.)
Review request for oozie.
Changes
-------
Addressed Mohammad's comment (from offline discussion) and removed the unnecessary EventType. Users can use any combination of AppType+EventStatus or MessageType+EventStatus etc to get desired notifications, and the JMS listener (OOZIE-1234) will take care of setting appropriate headers so users can apply those selectors.
Also, added a utility static function isEventsConfigured() in EventHandlerService instead of earlier boolean variable in XCommand
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1209
WIP patch
This addresses bug OOZIE-1209.
https://issues.apache.org/jira/browse/OOZIE-1209
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1463328
trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1463328
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1463328
trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
trunk/core/src/main/resources/oozie-default.xml 1463328
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1463328
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
Diff: https://reviews.apache.org/r/9602/diff/
Testing
-------
unit tests added
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/
-----------------------------------------------------------
(Updated April 4, 2013, 12:28 a.m.)
Review request for oozie.
Changes
-------
Latest and final patch -
1. Javadoc added
2. Implemented another test case to test event listeners
3. LOG statement on event generation added
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1209
WIP patch
This addresses bug OOZIE-1209.
https://issues.apache.org/jira/browse/OOZIE-1209
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1463328
trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1463328
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1463328
trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
trunk/core/src/main/resources/oozie-default.xml 1463328
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1463328
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
Diff: https://reviews.apache.org/r/9602/diff/
Testing
-------
unit tests added
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18635
-----------------------------------------------------------
I forgot javadoc again in diff#9. Will add it along with test-patch related fixes in diff#10
- Mona Chitnis
On April 3, 2013, 3:35 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated April 3, 2013, 3:35 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1463328
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1463328
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1463328
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1463328
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1463328
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/
-----------------------------------------------------------
(Updated April 3, 2013, 3:35 a.m.)
Review request for oozie.
Changes
-------
Uploaded the final set of review comments. I will handle the test-patch results as an incremental patch
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1209
WIP patch
This addresses bug OOZIE-1209.
https://issues.apache.org/jira/browse/OOZIE-1209
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1463328
trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1463328
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1463328
trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1463328
trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
trunk/core/src/main/resources/oozie-default.xml 1463328
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1463328
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
Diff: https://reviews.apache.org/r/9602/diff/
Testing
-------
unit tests added
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18599
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java
<https://reviews.apache.org/r/9602/#comment39001>
if (eventsConfigured) {generateEvent}
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java
<https://reviews.apache.org/r/9602/#comment39002>
if (eventsConfigured) generateEvent();
trunk/core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/9602/#comment39003>
can you add other properties like conf_listeners?
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java
<https://reviews.apache.org/r/9602/#comment39015>
discussed offline..need to assert for all event attributes
trunk/core/src/test/java/org/apache/oozie/test/XEventTestCase.java
<https://reviews.apache.org/r/9602/#comment39014>
discussed offline..make this inner class of EHS and remove this file
- Virag Kothari
On April 1, 2013, 10:23 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated April 1, 2013, 10:23 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1462882
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1462882
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1462882
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1462882
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1462882
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/test/XEventTestCase.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/
-----------------------------------------------------------
(Updated April 1, 2013, 10:23 a.m.)
Review request for oozie.
Changes
-------
Final patch after incorporating all review comments
@Virag, checking errorcode in testcase is left as TODO for now. Can be added as an incremental patch (creating one) since current patch ensures almost all the functionality
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1209
WIP patch
This addresses bug OOZIE-1209.
https://issues.apache.org/jira/browse/OOZIE-1209
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1462882
trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1462882
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1462882
trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
trunk/core/src/main/resources/oozie-default.xml 1462882
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1462882
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/test/XEventTestCase.java PRE-CREATION
Diff: https://reviews.apache.org/r/9602/diff/
Testing
-------
unit tests added
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mohammad Islam <mi...@yahoo.com>.
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, line 119
> > <https://reviews.apache.org/r/9602/diff/7/?file=276760#file276760line119>
> >
> > what does it mean? WF_JOB and COORD_ACTION is must?
> >
> > If someone wants *only* COORD_JOB. How will it be achieved?
>
> Mona Chitnis wrote:
> The rationale was that WF_JOB and COORD_ACTION would be the most common use-case. In this case *only* COORD_JOB is not possible. But on the receiving end, user can filter incoming messages on app-type COORD_JOB and it is achieved.
So we are enforcing to create both message while user doesn't care one type. A lot of extra unnecessary messages will be there. Is there any other reason?
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, line 91
> > <https://reviews.apache.org/r/9602/diff/7/?file=276760#file276760line91>
> >
> > Is this a right approach? Just report the failure. shoudl it fail the whole service?
> > I'm sure also. Do you?
> >
>
> Mona Chitnis wrote:
> The error could arise from a mistyped or non-existent class in the config properties. We wouldnt want the whole service to fail in that case. There will be a default listener anyway
ok
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, line 85
> > <https://reviews.apache.org/r/9602/diff/7/?file=276760#file276760line85>
> >
> > is it possible, 'listernerclass' could be 'null'. in that case add "listernerClass != null && i <linsternerClass.lentgth)
>
> Mona Chitnis wrote:
> Will be adding a default implementation for the listener (part of the other JIRA for JMS listener), in which case 'listenerclass' wont be null
ok.
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java, line 62
> > <https://reviews.apache.org/r/9602/diff/7/?file=276752#file276752line62>
> >
> > How the user will know if it is DOENWITH ERROR or KEILLED? Any message text associated with that could be helpful.
>
> Mona Chitnis wrote:
> the line above the switch case ladder sets the "actual" status, i.e. DONEWITHERROR, KILLED etc. User will know from the 'status' field. 'eventStatus' is meant to be the coarse version
ok.
- Mohammad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18570
-----------------------------------------------------------
On April 3, 2013, 3:35 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated April 3, 2013, 3:35 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1463328
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1463328
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1463328
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1463328
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1463328
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, line 119
> > <https://reviews.apache.org/r/9602/diff/7/?file=276760#file276760line119>
> >
> > what does it mean? WF_JOB and COORD_ACTION is must?
> >
> > If someone wants *only* COORD_JOB. How will it be achieved?
>
> Mona Chitnis wrote:
> The rationale was that WF_JOB and COORD_ACTION would be the most common use-case. In this case *only* COORD_JOB is not possible. But on the receiving end, user can filter incoming messages on app-type COORD_JOB and it is achieved.
>
> Mohammad Islam wrote:
> So we are enforcing to create both message while user doesn't care one type. A lot of extra unnecessary messages will be there. Is there any other reason?
>
I will change this to have user setting "override" the system default, rather than "adding" to it. Thanks
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18570
-----------------------------------------------------------
On April 3, 2013, 3:35 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated April 3, 2013, 3:35 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1463328
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1463328
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1463328
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1463328
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1463328
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1463328
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java, line 32
> > <https://reviews.apache.org/r/9602/diff/7/?file=276751#file276751line32>
> >
> > remove those code , if not needed in future.
I have a use-case in mind for this being a useful metric in the metric. Say the user ingests these notifications for some post-analysis on his coordinators, finding trends in his jobs and such. Then knowing frequency would be useful. So keeping it there for now
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java, line 62
> > <https://reviews.apache.org/r/9602/diff/7/?file=276752#file276752line62>
> >
> > How the user will know if it is DOENWITH ERROR or KEILLED? Any message text associated with that could be helpful.
the line above the switch case ladder sets the "actual" status, i.e. DONEWITHERROR, KILLED etc. User will know from the 'status' field. 'eventStatus' is meant to be the coarse version
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java, line 59
> > <https://reviews.apache.org/r/9602/diff/7/?file=276754#file276754line59>
> >
> > should be at least WARN.
done
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java, line 63
> > <https://reviews.apache.org/r/9602/diff/7/?file=276754#file276754line63>
> >
> > WARN. better error handling. please check how it is handled in CallableQueuService
done. changed to warn
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java, line 87
> > <https://reviews.apache.org/r/9602/diff/7/?file=276754#file276754line87>
> >
> > use the pattern like
> > else {
> > break
> > }.
> >
> > Also a LOG info/debug to define why it reached here.
done
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java, line 62
> > <https://reviews.apache.org/r/9602/diff/7/?file=276755#file276755line62>
> >
> > Do we need to handle START_MANUAL or END_MANUAL?
> > Because user needs to know they need to intervene.
Had removed it in this patch, but I agree its a good idea to keep it. Will add the *_MANUAL statuses in the patch, and I believe they'd map to WORKFLOW_ACTION_SUSPEND event type. Note however, event generation in WF Action commands will be done as a separate JIRA
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, line 75
> > <https://reviews.apache.org/r/9602/diff/7/?file=276760#file276760line75>
> >
> > Very long method. If possible, modularize into multiple method.
done
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, line 85
> > <https://reviews.apache.org/r/9602/diff/7/?file=276760#file276760line85>
> >
> > is it possible, 'listernerclass' could be 'null'. in that case add "listernerClass != null && i <linsternerClass.lentgth)
Will be adding a default implementation for the listener (part of the other JIRA for JMS listener), in which case 'listenerclass' wont be null
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, line 91
> > <https://reviews.apache.org/r/9602/diff/7/?file=276760#file276760line91>
> >
> > Is this a right approach? Just report the failure. shoudl it fail the whole service?
> > I'm sure also. Do you?
> >
The error could arise from a mistyped or non-existent class in the config properties. We wouldnt want the whole service to fail in that case. There will be a default listener anyway
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, line 119
> > <https://reviews.apache.org/r/9602/diff/7/?file=276760#file276760line119>
> >
> > what does it mean? WF_JOB and COORD_ACTION is must?
> >
> > If someone wants *only* COORD_JOB. How will it be achieved?
The rationale was that WF_JOB and COORD_ACTION would be the most common use-case. In this case *only* COORD_JOB is not possible. But on the receiving end, user can filter incoming messages on app-type COORD_JOB and it is achieved.
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, line 121
> > <https://reviews.apache.org/r/9602/diff/7/?file=276760#file276760line121>
> >
> > so WFJOB could be twice. right? one from default and another from config.
> > Please rethink about this behavior.
Hence using a HashSet. It will eliminate duplicates.
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, lines 124-125
> > <https://reviews.apache.org/r/9602/diff/7/?file=276760#file276760line124>
> >
> > Default '0' is correct?
good catch. changing it to '5' - consistent with the default in SchedulerService init
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, line 208
> > <https://reviews.apache.org/r/9602/diff/7/?file=276760#file276760line208>
> >
> > For better modularization, make it a separate method something like runJob() and the else part as runSLA()
done
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, line 226
> > <https://reviews.apache.org/r/9602/diff/7/?file=276760#file276760line226>
> >
> > Add the jobType in the message
done
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, line 251
> > <https://reviews.apache.org/r/9602/diff/7/?file=276760#file276760line251>
> >
> > Same
done
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, line 273
> > <https://reviews.apache.org/r/9602/diff/7/?file=276760#file276760line273>
> >
> > same...
done
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/event/listener/DummyJobEventListener.java, line 2
> > <https://reviews.apache.org/r/9602/diff/7/?file=276757#file276757line2>
> >
> > Why do we need it? for unit-testing?
moving it as the testcase's inner class
> On April 1, 2013, 4:06 a.m., Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java, line 50
> > <https://reviews.apache.org/r/9602/diff/7/?file=276748#file276748line50>
> >
> > will it be exposed to user? if yes, than it is better to define it on the client package.
I didn't get this. The variable is simply to avoid using strings in the method invocations here. This is not exposed to user directly, only through the event's error message
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18570
-----------------------------------------------------------
On March 31, 2013, 6:07 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated March 31, 2013, 6:07 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1462882
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1462882
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/DummyJobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1462882
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1462882
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1462882
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18570
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java
<https://reviews.apache.org/r/9602/#comment38925>
will it be exposed to user? if yes, than it is better to define it on the client package.
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java
<https://reviews.apache.org/r/9602/#comment38926>
remove those code , if not needed in future.
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java
<https://reviews.apache.org/r/9602/#comment38927>
How the user will know if it is DOENWITH ERROR or KEILLED? Any message text associated with that could be helpful.
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java
<https://reviews.apache.org/r/9602/#comment38928>
should be at least WARN.
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java
<https://reviews.apache.org/r/9602/#comment38929>
WARN. better error handling. please check how it is handled in CallableQueuService
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java
<https://reviews.apache.org/r/9602/#comment38930>
use the pattern like
else {
break
}.
Also a LOG info/debug to define why it reached here.
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java
<https://reviews.apache.org/r/9602/#comment38931>
Do we need to test this always? If possible, make sure it will be always instantiated in class level.
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java
<https://reviews.apache.org/r/9602/#comment38932>
Do we need to handle START_MANUAL or END_MANUAL?
Because user needs to know they need to intervene.
trunk/core/src/main/java/org/apache/oozie/event/listener/DummyJobEventListener.java
<https://reviews.apache.org/r/9602/#comment38933>
Why do we need it? for unit-testing?
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment38935>
Very long method. If possible, modularize into multiple method.
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment38936>
is it possible, 'listernerclass' could be 'null'. in that case add "listernerClass != null && i <linsternerClass.lentgth)
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment38937>
Is this a right approach? Just report the failure. shoudl it fail the whole service?
I'm sure also. Do you?
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment38938>
what does it mean? WF_JOB and COORD_ACTION is must?
If someone wants *only* COORD_JOB. How will it be achieved?
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment38939>
so WFJOB could be twice. right? one from default and another from config.
Please rethink about this behavior.
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment38940>
Default '0' is correct?
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment38941>
could be write how many threads are determine finally.
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment38942>
For better modularization, make it a separate method something like runJob() and the else part as runSLA()
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment38943>
Add the jobType in the message
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment38944>
Same
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment38945>
same...
- Mohammad Islam
On March 31, 2013, 6:07 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated March 31, 2013, 6:07 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1462882
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1462882
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1462882
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/DummyJobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1462882
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1462882
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1462882
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> unit tests added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/
-----------------------------------------------------------
(Updated March 31, 2013, 6:07 p.m.)
Review request for oozie.
Changes
-------
Mohammad's Review comments incorporated. Moved PersistentEventQueue from this patch to another JIRA to keep this simple.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1209
WIP patch
This addresses bug OOZIE-1209.
https://issues.apache.org/jira/browse/OOZIE-1209
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1462882
trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1462882
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonCoordinatorAction.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1462882
trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/DummyJobEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1462882
trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
trunk/core/src/main/resources/oozie-default.xml 1462882
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1462882
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
Diff: https://reviews.apache.org/r/9602/diff/
Testing (updated)
-------
unit tests added
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/
-----------------------------------------------------------
(Updated March 29, 2013, 3:35 a.m.)
Review request for oozie.
Changes
-------
temporary patch still WIP incorporating all comments.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1209
WIP patch
This addresses bug OOZIE-1209.
https://issues.apache.org/jira/browse/OOZIE-1209
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1461403
trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1461403
trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
trunk/core/src/main/resources/oozie-default.xml 1461403
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1461403
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
Diff: https://reviews.apache.org/r/9602/diff/
Testing
-------
More unit tests to be added
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
> On March 28, 2013, 5:58 p.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java, line 50
> > <https://reviews.apache.org/r/9602/diff/5/?file=275649#file275649line50>
> >
> > both currentsize() and eventQueue.add() are atomic operations, but the combined operation is not.
> > I dont think there is any better way other than synchronize the combined operation of checking the overflow of queue and adding to queue.
Added a reentrant lock for the poll() method. Not required in add() as 1 or 2 elements inserted above maxSize when this corner case race condition occurs between threads, can be tolerated
> On March 28, 2013, 5:58 p.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java, line 69
> > <https://reviews.apache.org/r/9602/diff/5/?file=275649#file275649line69>
> >
> > instead of having this method return set of events, its better to have it return only event as a usual method of queue would do.
> > Have the logic of draining elements in batch in event handler service
better to keep these details in the lower level (event queue) instead of higher up in the service. Added another method pollBatch() to allow both options as needed
> On March 28, 2013, 5:58 p.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java, line 71
> > <https://reviews.apache.org/r/9602/diff/5/?file=275649#file275649line71>
> >
> > Same comment as earlier. The combined operations are not thread safe.
see comment above
> On March 28, 2013, 5:58 p.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, line 82
> > <https://reviews.apache.org/r/9602/diff/5/?file=275654#file275654line82>
> >
> > every configuration variable should have a default value
> > For e.g if listenerClass is null here, we should add the existing listeners.
you will have to add this as part of your patch on top of mine, as org.apache.oozie.jms.JMSJobEventListener does not exist in my code
> On March 28, 2013, 5:58 p.m., Virag Kothari wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java, line 119
> > <https://reviews.apache.org/r/9602/diff/5/?file=275654#file275654line119>
> >
> > create the runnable passing the batch size in constructor.
> > Make the poll() method of eventqueue return only event.
if size passed through constructor, would need an if-else clause in the run() method to choose between poll single (since it should return only event and not event-set with size 1) and poll batch. Resorted to calling pollBatch() method from the runnable. poll() also exists as an available option
> On March 28, 2013, 5:58 p.m., Virag Kothari wrote:
> > trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java, line 42
> > <https://reviews.apache.org/r/9602/diff/5/?file=275657#file275657line42>
> >
> > More coverage of test cases required
> > like having multiple threads adding, removing from queue etc.
thanks. will do
> On March 28, 2013, 5:58 p.m., Virag Kothari wrote:
> > trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java, line 51
> > <https://reviews.apache.org/r/9602/diff/5/?file=275658#file275658line51>
> >
> > we should have test cases for the all commands which are generating events.
thanks will do
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18464
-----------------------------------------------------------
On March 29, 2013, 3:35 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated March 29, 2013, 3:35 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1461403
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1461403
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1461403
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1461403
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> More unit tests to be added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18464
-----------------------------------------------------------
trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java
<https://reviews.apache.org/r/9602/#comment38705>
Move errorCode, errorMessage to sub classes
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java
<https://reviews.apache.org/r/9602/#comment38708>
both currentsize() and eventQueue.add() are atomic operations, but the combined operation is not.
I dont think there is any better way other than synchronize the combined operation of checking the overflow of queue and adding to queue.
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java
<https://reviews.apache.org/r/9602/#comment38710>
instead of having this method return set of events, its better to have it return only event as a usual method of queue would do.
Have the logic of draining elements in batch in event handler service
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java
<https://reviews.apache.org/r/9602/#comment38711>
Same comment as earlier. The combined operations are not thread safe.
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment38712>
every configuration variable should have a default value
For e.g if listenerClass is null here, we should add the existing listeners.
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment38713>
default value required.
conf.get (CONF_ENTITY_TYPES, default values)
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment38714>
create the runnable passing the batch size in constructor.
Make the poll() method of eventqueue return only event.
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java
<https://reviews.apache.org/r/9602/#comment38715>
More coverage of test cases required
like having multiple threads adding, removing from queue etc.
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java
<https://reviews.apache.org/r/9602/#comment38716>
we should have test cases for the all commands which are generating events.
- Virag Kothari
On March 28, 2013, 12:47 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated March 28, 2013, 12:47 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1461403
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1461403
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> More unit tests to be added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
> On March 29, 2013, 2:05 a.m., Mona Chitnis wrote:
> > Comments by Mohammad from an in-person meeting:
> >
> > - how to keep ordering of events in eventQueue - open question
> > - can we have user, appName as a new column in coord actions?
> > OR pass user appName through constructor
> > - setEndTime() : Pass the end time in constructor while creating event
> > - variable 'entity_types' rename in EHS
> > - newInstance() to be done only in if listener instance of Jobevent or slaevent: EHS
> > - separate the code in run() method of Runnable: EHS
> > - Look into PriorityDelayQueue for queue thread safety
next patch incorporates following:
- passing user, appname through event constructor, instead of entire coordJob object. In most cases coordJob was already available through the Command. In only a couple of cases where it wasnt, new JPAExecutor which only retrieves user+appname in coordJob bean is used.
- not possible to pass endTime in constructor because constructor is agnostic of event type and will result in say START event having end time value as same time as the start time i.e. when start event got generated
- renamed "entity_types" to familiar "job_types"
- run() in EHS runnable made modular
- added thread safety for MemoryEventQueue poll() method on the same lines as our PDQ for callables
- fixed the listener newInstance() comment
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18490
-----------------------------------------------------------
On March 29, 2013, 3:35 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated March 29, 2013, 3:35 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1461403
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1461403
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1461403
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1461403
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> More unit tests to be added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
> On March 29, 2013, 2:05 a.m., Mona Chitnis wrote:
> > Comments by Mohammad from an in-person meeting:
> >
> > - how to keep ordering of events in eventQueue - open question
> > - can we have user, appName as a new column in coord actions?
> > OR pass user appName through constructor
> > - setEndTime() : Pass the end time in constructor while creating event
> > - variable 'entity_types' rename in EHS
> > - newInstance() to be done only in if listener instance of Jobevent or slaevent: EHS
> > - separate the code in run() method of Runnable: EHS
> > - Look into PriorityDelayQueue for queue thread safety
>
> Mona Chitnis wrote:
> next patch incorporates following:
> - passing user, appname through event constructor, instead of entire coordJob object. In most cases coordJob was already available through the Command. In only a couple of cases where it wasnt, new JPAExecutor which only retrieves user+appname in coordJob bean is used.
> - not possible to pass endTime in constructor because constructor is agnostic of event type and will result in say START event having end time value as same time as the start time i.e. when start event got generated
> - renamed "entity_types" to familiar "job_types"
> - run() in EHS runnable made modular
> - added thread safety for MemoryEventQueue poll() method on the same lines as our PDQ for callables
> - fixed the listener newInstance() comment
correction about newInstance() comment - how will it be possible to determine whether listener instance is Job or SLA before invoking newInstance() on it??
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18490
-----------------------------------------------------------
On March 29, 2013, 3:35 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated March 29, 2013, 3:35 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1461403
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordinatorJobGetForUserAppnameJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1461403
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1461403
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1461403
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> More unit tests to be added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18490
-----------------------------------------------------------
Comments by Mohammad from an in-person meeting:
- how to keep ordering of events in eventQueue - open question
- can we have user, appName as a new column in coord actions?
OR pass user appName through constructor
- setEndTime() : Pass the end time in constructor while creating event
- variable 'entity_types' rename in EHS
- newInstance() to be done only in if listener instance of Jobevent or slaevent: EHS
- separate the code in run() method of Runnable: EHS
- Look into PriorityDelayQueue for queue thread safety
- Mona Chitnis
On March 28, 2013, 12:47 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated March 28, 2013, 12:47 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1461403
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1461403
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> More unit tests to be added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/
-----------------------------------------------------------
(Updated March 28, 2013, 12:47 a.m.)
Review request for oozie.
Changes
-------
Incorporated review comments till now. Main changes
- JobEvent and SLAEvent to client
- EventHandlerService invokes init() and destroy() for registered listeners
- Other minor changes around suspend action
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1209
WIP patch
This addresses bug OOZIE-1209.
https://issues.apache.org/jira/browse/OOZIE-1209
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/SLAEvent.java 1461403
trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/JobEvent.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/event/SLAEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
trunk/core/src/main/resources/oozie-default.xml 1461403
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
Diff: https://reviews.apache.org/r/9602/diff/
Testing
-------
More unit tests to be added
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/
-----------------------------------------------------------
(Updated March 27, 2013, 10:05 p.m.)
Review request for oozie.
Changes
-------
Small diff from last patch:
- Event Listener updated with the correct methods for each status change per entity type
- Workflow Job's generate event takes errorCode and errorCode corresponding to erroring WF Action (where applicable)
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1209
WIP patch
This addresses bug OOZIE-1209.
https://issues.apache.org/jira/browse/OOZIE-1209
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/JobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
trunk/core/src/main/resources/oozie-default.xml 1461403
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
Diff: https://reviews.apache.org/r/9602/diff/
Testing
-------
More unit tests to be added
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review18441
-----------------------------------------------------------
Few comments mainly related to event and eventlistener interfaces
trunk/core/src/main/java/org/apache/oozie/event/JobEvent.java
<https://reviews.apache.org/r/9602/#comment38661>
private
same for other protected members.
trunk/core/src/main/java/org/apache/oozie/event/JobEvent.java
<https://reviews.apache.org/r/9602/#comment38660>
Discussed offline, move errorCode and errorMessage to required sub classes
trunk/core/src/main/java/org/apache/oozie/event/JobEvent.java
<https://reviews.apache.org/r/9602/#comment38659>
suspended job means it is not ended. So I think its better to have end time as null.
trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java
<https://reviews.apache.org/r/9602/#comment38664>
discussed offline, require all methods specific to event types
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment38665>
I think we should instantiate the listeners here to make sure that they are either jobeventlistener or slaEventListener.
Also init() method to be called after instantiating
and destroy() on listeners in the destroy()
trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java
<https://reviews.apache.org/r/9602/#comment38666>
As discussed, methods should be abstract.
- Virag Kothari
On March 27, 2013, 4:04 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated March 27, 2013, 4:04 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1461403
> trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/JobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1461403
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> More unit tests to be added
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/
-----------------------------------------------------------
(Updated March 27, 2013, 4:04 a.m.)
Review request for oozie.
Changes
-------
Updated patch incorporating all combo comments.
Unit tests in progress..
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1209
WIP patch
This addresses bug OOZIE-1209.
https://issues.apache.org/jira/browse/OOZIE-1209
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/event/Event.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1461403
trunk/core/src/main/java/org/apache/oozie/event/BundleJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/CoordinatorJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/JobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/sla/event/listener/SLAEventListener.java PRE-CREATION
trunk/core/src/main/resources/oozie-default.xml 1461403
trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
Diff: https://reviews.apache.org/r/9602/diff/
Testing
-------
More unit tests to be added
Thanks,
Mona Chitnis
Re: Review Request: OOZIE-1209 Event generation and handling for workflow
and coordinator
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9602/#review17437
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java
<https://reviews.apache.org/r/9602/#comment36985>
i don't have strong opinion which one better,
but wondering, instead of calling different methods (generateSuccessEvent, generateFailureEvent..), how about having generic generateEvent(Event, ActionBean, JobBean), and inside the method, do appropriate conditional branching based on event.AppType?
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java
<https://reviews.apache.org/r/9602/#comment36987>
# of dispatcher might be limited, but still seem a bit waste to loop through not relevant dispatchers, one option might be to keep mapping between Event type --> dispatcher?
- Ryota Egashira
On March 5, 2013, 2:31 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9602/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 2:31 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1209
> WIP patch
>
>
> This addresses bug OOZIE-1209.
> https://issues.apache.org/jira/browse/OOZIE-1209
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java 1452586
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1452586
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1452586
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java 1452586
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1452586
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1452586
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1452586
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 1452586
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 1452586
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java 1452586
> trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java 1452586
> trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java 1452586
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1452586
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1452586
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1452586
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionFailureEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionStartedEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionSuccessEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionWaitingEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/Event.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventDispatcher.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/JobEventDispatcher.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/SLAEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/SLAEventDispatcher.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobFailureEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobStartedEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobSuccessEvent.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/CoordinatorEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/DummyCoordEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/DummyWFEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/SLAEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/event/listener/WorkflowEventListener.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java PRE-CREATION
> trunk/core/src/main/resources/oozie-default.xml 1452586
> trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9602/diff/
>
>
> Testing
> -------
>
> More unit tests to be added
>
>
> Thanks,
>
> Mona Chitnis
>
>