[jira] [Comment Edited] (AVRO-2254) Unions with 2 records declared downward fail

["Nandor Kollar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685032#comment-16685032 ] 

Nandor Kollar edited comment on AVRO-2254 at 11/13/18 10:54 AM:
----------------------------------------------------------------

[~zolyfarkas] the fix looks good to me, I can merge the PR if you open one, and every test passes.


was (Author: nkollar):
[~zolyfarkas] the fix looks good to me, I can merge the PR if you open one, and all test pass.

> Unions with 2 records declared downward fail
> --------------------------------------------
>
>                 Key: AVRO-2254
>                 URL: https://issues.apache.org/jira/browse/AVRO-2254
>             Project: Apache Avro
>          Issue Type: Bug
>    Affects Versions: 1.9.0
>            Reporter: Zoltan Farkas
>            Priority: Major
>
> The following IDL will fail complaining that 2 same type is declared twice in the union:
> {code}
> @namespace("org.apache.avro.gen")
> protocol UnionFwd {
>     record TestRecord {
>       union {SR1, SR2} unionField;
>     }
>     record SR1 {
>       string field;
>     }
>     record SR2 {
>       string field;
>     }
> }
> {code}
> the fix for this can be pretty simple:
> https://github.com/zolyfarkas/avro/commit/56b215f73f34cc80d505875c90217916b271abb5



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)