You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "janhoy (via GitHub)" <gi...@apache.org> on 2024/04/09 13:05:21 UTC
[PR] Renovatebot config fixes [solr]
janhoy opened a new pull request, #2394:
URL: https://github.com/apache/solr/pull/2394
Ref discussion in https://lists.apache.org/thread/ovwytr47zv2y9xs7fxbgl6kbpfmbqc5v
Try to be explicit with schedule on the packages we want to update less frequently.
Also fix changelog location for some gitbox repos, where renovate was complaining, e.g.
```
INFO: Unknown platform, skipping changelog fetching. (repository=apache/solr, branch=renovate/org.apache.zookeeper)
"sourceUrl": "https://gitbox.apache.org/repos/asf/zookeeper.git",
"hostType": null
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Renovatebot config fixes [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #2394:
URL: https://github.com/apache/solr/pull/2394#discussion_r1559205658
##########
.github/renovate.json:
##########
@@ -46,6 +46,26 @@
"description": "Lucene dependencies should be skipped",
"matchPackageNames": ["org.apache.lucene"],
Review Comment:
I tried to fix this by using `matchPackagePrefixes` instead of `matchPackageNames`, which matches package name exactly, which would be e.g. `org.apache.lucene:lucene-core`, i.e. including group and artifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Renovatebot config fixes [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #2394:
URL: https://github.com/apache/solr/pull/2394#issuecomment-2046143957
Currently the bot opens PRs all week. Earlier it did only on Sundays. Should we go back to the Sunday schedule for less churn during the week?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Renovatebot config fixes [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy merged PR #2394:
URL: https://github.com/apache/solr/pull/2394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Renovatebot config fixes [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2394:
URL: https://github.com/apache/solr/pull/2394#issuecomment-2045155991
This looks great. Though, it doesn't change that we need to be better as a community on merging these SolrBot PR's right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Renovatebot config fixes [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #2394:
URL: https://github.com/apache/solr/pull/2394#discussion_r1559202905
##########
.github/renovate.json:
##########
@@ -46,6 +46,26 @@
"description": "Lucene dependencies should be skipped",
"matchPackageNames": ["org.apache.lucene"],
Review Comment:
Another issue is that this rule does not work. The bot opened a lucene upgrade PR on Feb 27 even if this rule has been in place since June 2023. https://github.com/apache/solr/pull/2309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org