You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Peter Cseh <ge...@cloudera.com> on 2017/09/05 13:56:18 UTC

Re: Review Request 61560: OOZIE-2909 LauncherAM: rewrite UGI calls


> On Aug. 22, 2017, 8:34 p.m., Robert Kanter wrote:
> > core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentialHelper.java
> > Line 66 (original), 65 (patched)
> > <https://reviews.apache.org/r/61560/diff/1/?file=1794986#file1794986line66>
> >
> >     Have we verified that HCat/HMS is okay with changing the alias?  I don't know if maybe they were doing something funny with it.

I know there is a reference for it in Sqoop (https://issues.apache.org/jira/browse/SQOOP-3177) , but It does not seem to work anyways.


> On Aug. 22, 2017, 8:34 p.m., Robert Kanter wrote:
> > core/src/main/java/org/apache/oozie/action/hadoop/Hive2Credentials.java
> > Line 82 (original), 81 (patched)
> > <https://reviews.apache.org/r/61560/diff/1/?file=1794988#file1794988line82>
> >
> >     Have we verified that HS2 is okay with changing the alias?  I don't know if maybe they were doing something funny with it.

I could not find a reference for this alias in Hive's codebase.


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61560/#review183516
-----------------------------------------------------------


On Aug. 10, 2017, 5:21 p.m., Peter Cseh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61560/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2017, 5:21 p.m.)
> 
> 
> Review request for oozie, Attila Sasvari, Peter Bacsko, Robert Kanter, and Rohini Palaniswamy.
> 
> 
> Bugs: OOZIE-2909
>     https://issues.apache.org/jira/browse/OOZIE-2909
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Changing UGI calls and cleaning up things around requesting tokens.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProviderFactory.java 5ca8d3e80942840a5bba51a06694350929044042 
>   core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentialHelper.java 9804c7b673a899cd9c778850c9a64731cc642fb3 
>   core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java 4add5f14cb20ab77c755b81eff939335c0c5fddc 
>   core/src/main/java/org/apache/oozie/action/hadoop/Hive2Credentials.java 0b495f75842b0033a3337ef6728a334bf5651770 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java dc17950418ada9b4848ed5597702a29e7124ab38 
>   core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java b507c79d44aa2095caf532a5f4d19d20c1a30630 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java 6a98d6ef3a09a7a75272f3f0f9a9c2fc5472e76d 
>   sharelib/oozie/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAM.java 37af3dd9ed43f4504ff3909484237e2d05665c6c 
> 
> 
> Diff: https://reviews.apache.org/r/61560/diff/1/
> 
> 
> Testing
> -------
> 
> We're running tests on a Kerberized cluster with these changes.
> 
> 
> Thanks,
> 
> Peter Cseh
> 
>