You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/29 12:06:09 UTC

[GitHub] [cloudstack] onitake opened a new pull request #4037: Document cidrlist parameter deprecation

onitake opened a new pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037


   ## Description
   <!--- Describe your changes in detail -->
   Amend the description for the cidrlist parameter in CreatePortForwardingRule and CreateFirewallRule to state that it is deprecated and shouldn't be used.
   
   Passing this parameter will always result in an error.
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   Fixes: #4036 
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   See the original bug report for an explanation.
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti merged pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-880540896


   @onitake 
   as I mentioned above, could you please create another pr to fix the issue ? 
   it is not urgent, but do not forget it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#discussion_r660552516



##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
##########
@@ -73,7 +73,7 @@
     @Parameter(name = ApiConstants.END_PORT, type = CommandType.INTEGER, description = "the ending port of firewall rule")
     private Integer publicEndPort;
 
-    @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST, collectionType = CommandType.STRING, description = "the CIDR list to forward traffic from. Multiple entries must be separated by a single comma character (,).")
+    @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST, collectionType = CommandType.STRING, description = "the CIDR list to forward traffic from. Multiple entries must be separated by a single comma character (,). This parameter is depcreated. Do not use.")

Review comment:
       typo, _depcreated_ => _deprecated_




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#discussion_r660552516



##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
##########
@@ -73,7 +73,7 @@
     @Parameter(name = ApiConstants.END_PORT, type = CommandType.INTEGER, description = "the ending port of firewall rule")
     private Integer publicEndPort;
 
-    @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST, collectionType = CommandType.STRING, description = "the CIDR list to forward traffic from. Multiple entries must be separated by a single comma character (,).")
+    @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST, collectionType = CommandType.STRING, description = "the CIDR list to forward traffic from. Multiple entries must be separated by a single comma character (,). This parameter is depcreated. Do not use.")

Review comment:
       typo, _depcreated_ => _deprecated_

##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java
##########
@@ -108,7 +108,7 @@
                 description = "the ID of the virtual machine for the port forwarding rule")
     private Long virtualMachineId;
 
-    @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST, collectionType = CommandType.STRING, description = "the cidr list to forward traffic from. Multiple entries must be separated by a single comma character (,).")
+    @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST, collectionType = CommandType.STRING, description = "the cidr list to forward traffic from. Multiple entries must be separated by a single comma character (,). This parameter is depcreated. Do not use.")

Review comment:
       same typo error here as well




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-877313385


   <b>Trillian test result (tid-1225)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33254 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4037-t1225-kvm-centos7.zip
   Smoke tests completed. 88 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-876961461


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-770913728


   @onitake can you update this (and maybe make sure the cidr lists are actually ignored and don't throw an exception)?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-877087778


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-876961203


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-868278088


   Hi @onitake Can you please resolve conflicts in this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-870116641


   @onitake looks good, only one question: if the parameter is deprecated and must not be used why not then remove it? cc. @rhtyd @DaanHoogland 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-871913340


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-871924122


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-877100847


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 508


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-877341948


   Merging this based on approvals and test results


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-870347362


   > @onitake looks good, only one question: if the parameter is deprecated and must not be used why not then remove it? cc. @rhtyd @DaanHoogland
   
   For backward compatibility reasons for scripts, but you are right @nvazquez. Unknown parameters are ignored, so if we are sure it is completely ignored. I didn't think of that. I'd say let's keep them in like this for a few versions and then remove them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-877472558


   @sureshanaparti @DaanHoogland @onitake 
   I think cidrlist is not deprecated in CreateFirewallRuleCmd.java. 
   Please revert this merge.
   
   @onitake could you please create another pr for CreatePortForwardingRuleCmd.java which cidrlist is deprecated ?
   
   ```
   (localcloud) SBCM5> > create firewallrule ipaddressid=997f8efd-2ec7-46f4-a054-de837e196cc2 startport=22 endport=22 cidrlist=10.10.10.0/24 protocol=tcp
   {
     "firewallrule": {
       "cidrlist": "10.10.10.0/24",
       "endport": 22,
       "fordisplay": true,
       "id": "f0b7270d-77b0-4d97-8c02-d95a0e774561",
       "ipaddress": "10.0.52.5",
       "ipaddressid": "997f8efd-2ec7-46f4-a054-de837e196cc2",
       "networkid": "5528f815-c365-4702-8a6b-b59a1d33e8c5",
       "protocol": "tcp",
       "startport": 22,
       "state": "Active",
       "tags": []
     }
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] onitake commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
onitake commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-868368767


   I combined the documentation strings. Hope that's ok?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-876961461


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-877679165


   > @weizhouapache Couldn't you have said this a few days earlier? This PR has been open for more than a year. 
   > 
   > Sure, I can submit another PR that reverts this... But only if it's confirmed that this isn't deprecated. @rhtyd @DaanHoogland ?
   
   @onitake I found the problem right after this pr is merged...
   
   maybe it is unnecessary to revert the pr as it is not an major issue, you can create a PR to (1) revert the change in CreateFirewallRuleCmd.java; (2) change CreateLoadBalancerRuleCmd.java and CreateIpForwardingRuleCmd.java 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-781927963


   @onitake conflicts on this PR, please fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-871913056


   Ok thanks @DaanHoogland 
   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti closed pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
sureshanaparti closed pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#discussion_r661346972



##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
##########
@@ -73,7 +73,7 @@
     @Parameter(name = ApiConstants.END_PORT, type = CommandType.INTEGER, description = "the ending port of firewall rule")
     private Integer publicEndPort;
 
-    @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST, collectionType = CommandType.STRING, description = "the CIDR list to forward traffic from. Multiple entries must be separated by a single comma character (,).")
+    @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST, collectionType = CommandType.STRING, description = "the CIDR list to forward traffic from. Multiple entries must be separated by a single comma character (,). This parameter is depcreated. Do not use.")

Review comment:
       ```suggestion
       @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST, collectionType = CommandType.STRING, description = "the CIDR list to forward traffic from. Multiple entries must be separated by a single comma character (,). This parameter is deprecated. Do not use.")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#discussion_r660552758



##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java
##########
@@ -108,7 +108,7 @@
                 description = "the ID of the virtual machine for the port forwarding rule")
     private Long virtualMachineId;
 
-    @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST, collectionType = CommandType.STRING, description = "the cidr list to forward traffic from. Multiple entries must be separated by a single comma character (,).")
+    @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST, collectionType = CommandType.STRING, description = "the cidr list to forward traffic from. Multiple entries must be separated by a single comma character (,). This parameter is depcreated. Do not use.")

Review comment:
       same typo error here as well




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-876961203


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] onitake commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
onitake commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-877668424


   @weizhouapache Couldn't you have said this a few days earlier? This PR has been open for more than a year. :disappointed: 
   
   Sure, I can submit another PR that reverts this... But only if it's confirmed that this isn't deprecated. @rhtyd @DaanHoogland ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] onitake commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
onitake commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-872270853


   @sureshanaparti @DaanHoogland Woops, thank you. :sweat_smile: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-877088290


   @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache edited a comment on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-877472558


   @sureshanaparti @DaanHoogland @onitake 
   I think cidrlist is not deprecated in CreateFirewallRuleCmd.java. 
   Please revert this merge.
   
   @onitake could you please create another pr for CreatePortForwardingRuleCmd.java, CreateLoadBalancerRuleCmd.java and CreateIpForwardingRuleCmd.java which cidrlist is deprecated ?
   
   ```
   (localcloud) SBCM5> > create firewallrule ipaddressid=997f8efd-2ec7-46f4-a054-de837e196cc2 startport=22 endport=22 cidrlist=10.10.10.0/24 protocol=tcp
   {
     "firewallrule": {
       "cidrlist": "10.10.10.0/24",
       "endport": 22,
       "fordisplay": true,
       "id": "f0b7270d-77b0-4d97-8c02-d95a0e774561",
       "ipaddress": "10.0.52.5",
       "ipaddressid": "997f8efd-2ec7-46f4-a054-de837e196cc2",
       "networkid": "5528f815-c365-4702-8a6b-b59a1d33e8c5",
       "protocol": "tcp",
       "startport": 22,
       "state": "Active",
       "tags": []
     }
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#discussion_r661347163



##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java
##########
@@ -108,7 +108,7 @@
                 description = "the ID of the virtual machine for the port forwarding rule")
     private Long virtualMachineId;
 
-    @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST, collectionType = CommandType.STRING, description = "the cidr list to forward traffic from. Multiple entries must be separated by a single comma character (,).")
+    @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST, collectionType = CommandType.STRING, description = "the cidr list to forward traffic from. Multiple entries must be separated by a single comma character (,). This parameter is depcreated. Do not use.")

Review comment:
       ```suggestion
       @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST, collectionType = CommandType.STRING, description = "the cidr list to forward traffic from. Multiple entries must be separated by a single comma character (,). This parameter is deprecated. Do not use.")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-870347362


   > @onitake looks good, only one question: if the parameter is deprecated and must not be used why not then remove it? cc. @rhtyd @DaanHoogland
   
   For backward compatibility reasons for scripts, but you are right @nvazquez. Unknown parameters are ignored, so if we are sure it is completely ignored. I didn't think of that. I'd say let's keep them in like this for a few versions and then remove them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-871923577


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 439


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti closed pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
sureshanaparti closed pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-870116641


   @onitake looks good, only one question: if the parameter is deprecated and must not be used why not then remove it? cc. @rhtyd @DaanHoogland 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4037: Document cidrlist parameter deprecation

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4037:
URL: https://github.com/apache/cloudstack/pull/4037#issuecomment-871924453


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org