You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by jo...@apache.org on 2019/03/22 16:50:30 UTC

[impala] 03/04: IMPALA-8202: Add more logging to TestAdmissionControllerStress

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 75ec9336e04d0fce0ac30963108c967dfeec771f
Author: Bikramjeet Vig <bi...@cloudera.com>
AuthorDate: Wed Mar 20 11:44:10 2019 -0700

    IMPALA-8202: Add more logging to TestAdmissionControllerStress
    
    This change adds some logging and fixes a bug where the string
    match that identified a timeout was wrong. The added logging
    would provide more information about the state to help diagnose
    root cause for IMPALA-8202.
    
    Change-Id: Ib62cefac0dc53da0a9f26fdd959975deafc70c8f
    Reviewed-on: http://gerrit.cloudera.org:8080/12829
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/custom_cluster/test_admission_controller.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/custom_cluster/test_admission_controller.py b/tests/custom_cluster/test_admission_controller.py
index 7c97c5e..5c2799a 100644
--- a/tests/custom_cluster/test_admission_controller.py
+++ b/tests/custom_cluster/test_admission_controller.py
@@ -1208,13 +1208,15 @@ class TestAdmissionControllerStress(TestAdmissionControllerBase):
             self.query_state = 'REJECTED'
             self.query_handle = None
             return
-          elif "timeout" in admission_result:
+          elif "Timed out" in admission_result:
             LOG.info("Query %s timed out", self.query_num)
             self.query_state = 'TIMED OUT'
             self.query_handle = None
             return
+          LOG.info("Admission result for query %s : %s", self.query_num, admission_result)
         except ImpalaBeeswaxException as e:
-            raise e
+          LOG.exception(e)
+          raise e
         finally:
           self.lock.release()
         LOG.info("Admitted query %s", self.query_num)