You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/07/13 17:37:59 UTC
[PR] fix(deps): pin syntaqlite below 0.5.0 for Python 3.10 compatibility [superset]
rusackas opened a new pull request, #42007:
URL: https://github.com/apache/superset/pull/42007
### SUMMARY
Master CI has been intermittently red since #41952 bumped `syntaqlite` 0.4.2 → 0.6.0.
`syntaqlite` 0.5.0+ (including 0.6.0) imports `StrEnum` from the stdlib `enum` module **unconditionally**:
```python
# syntaqlite/__init__.py
from enum import IntEnum, StrEnum
```
`enum.StrEnum` was only added in **Python 3.11**, yet the package still declares `requires-python>=3.10`. Superset supports Python 3.10, and `superset/sql_validators/sqlite.py` imports `syntaqlite` on the app-init import path (`init_views` → `databases.api` → `validate_sql` → `sql_validators`), so **any test that builds the app fails at import time on Python 3.10**:
```
File ".../syntaqlite/__init__.py", line 21, in <module>
from enum import IntEnum, StrEnum
ImportError: cannot import name 'StrEnum' from 'enum'
```
**Why it slipped through PR CI and only broke master:** the `Python-Unit` / `Python-Integration` matrices run the `previous` (Python 3.10) leg **only on pushes to master** — PRs run the `current` (3.11) leg only. So #41952 merged green, and the break surfaces on the next push to master that touches Python files (the `changes` filter skips the matrix otherwise, which is why some master commits still show green).
### FIX
- Revert the pin to the last 3.10-safe range: `<0.5.0` for the `sqlite` extra, `>=0.4.2,<0.5.0` for `development`, and `syntaqlite==0.4.2` in `requirements/development.txt`. (`0.4.2` has no `StrEnum` import; `0.5.1` already added it.)
- Add a Dependabot `ignore` entry for `syntaqlite` so it is not immediately re-bumped past `0.5.0` until Superset drops Python 3.10.
- Add explanatory comments at each pin so the constraint isn't "fixed" blindly later.
### TESTING INSTRUCTIONS
On Python 3.10, before this change `python -c "import superset.sql_validators.sqlite"` raises `ImportError: cannot import name 'StrEnum'`; after pinning back to `syntaqlite==0.4.2` the import succeeds. CI's `Python-Unit` / `Python-Integration` `previous` (3.10) legs go green.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Upstream fix would be for `syntaqlite` to guard the `StrEnum` import (as Superset itself does in `superset/utils/backports.py`) or to raise its `requires-python` to `>=3.11`. This PR just unblocks master in the meantime.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(deps): pin syntaqlite below 0.5.0 for Python 3.10 compatibility [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42007:
URL: https://github.com/apache/superset/pull/42007#issuecomment-4960836697
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(deps): pin syntaqlite below 0.5.0 for Python 3.10 compatibility [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #42007:
URL: https://github.com/apache/superset/pull/42007#issuecomment-4997336067
Closing, removed 3.10 from the CI matrix, and will remove 3.10 support officially if I can get lazy consensus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(deps): pin syntaqlite below 0.5.0 for Python 3.10 compatibility [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #42007:
URL: https://github.com/apache/superset/pull/42007#issuecomment-4960986034
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/42007?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 64.44%. Comparing base ([`e063f50`](https://app.codecov.io/gh/apache/superset/commit/e063f5093c9efe8956e255ad237ec4e2351fb2cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`15ae40c`](https://app.codecov.io/gh/apache/superset/commit/15ae40c9345b916ac81ef6c409a4602b243b029f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #42007 +/- ##
==========================================
+ Coverage 56.16% 64.44% +8.28%
==========================================
Files 2744 2744
Lines 153608 153611 +3
Branches 35223 35223
==========================================
+ Hits 86267 98997 +12730
+ Misses 66515 52705 -13810
- Partials 826 1909 +1083
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/42007/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/42007/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.05% <ø> (-0.01%)` | :arrow_down: |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/42007/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.97% <ø> (?)` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/42007/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.04% <ø> (-0.01%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/42007/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.14% <ø> (+17.04%)` | :arrow_up: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/42007/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.57% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/42007?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(deps): pin syntaqlite below 0.5.0 for Python 3.10 compatibility [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #42007: fix(deps): pin syntaqlite below 0.5.0 for Python 3.10 compatibility
URL: https://github.com/apache/superset/pull/42007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org