You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@httpd.apache.org by Ruediger Pluem <rp...@apache.org> on 2020/05/29 18:47:34 UTC

Re: svn commit: r1878280 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_http.c


On 5/29/20 7:05 PM, ylavic@apache.org wrote:
> Author: ylavic
> Date: Fri May 29 17:05:29 2020
> New Revision: 1878280
> 
> URL: http://svn.apache.org/viewvc?rev=1878280&view=rev
> Log:
> mod_proxy_http: don't strip EOS when spooling request body to file.
> 
> To prevent stream_reqbody() from sending the FILE and EOS bucket in separate
> brigades, and thus apr_file_setaside() to trigger if network congestion occurs
> with the backend, restore the EOS in spool_reqbody_cl() which was stripped
> when spooling the request body to a file.
> 
> Until APR r1878279 is released (and installed by users), apr_file_setaside()
> on a temporary file (mktemp) will simply drop the file cleanup, leaking the
> fd and inode..
> 
> This fixes BZ 64452.

This was a really tricky and nasty one. Excellent debug job. Plus it brought us nice improvements to .gdbinit :-)

Regards

Rüdiger