You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/07/13 04:58:04 UTC
[jira] [Commented] (TAJO-1679) Client APIs should validate
identifiers for database object names
[ https://issues.apache.org/jira/browse/TAJO-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624141#comment-14624141 ]
ASF GitHub Bot commented on TAJO-1679:
--------------------------------------
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/627
TAJO-1679: Client APIs should validate identifiers for database object names.
See https://issues.apache.org/jira/browse/TAJO-1679.
For example, the current API accepts wrong object names as follows:
```java
client.createDatabase("12345");
```
This patch does not include the unit tests because the current error propagation system just causes exceptions in TajoMaster and cannot catch this kind of errors. This problem will be solved in TAJO-1670 and failure unit tests will be added in that jira too.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-1679
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/627.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #627
----
commit 3a737dd446b3975f0eca6afabf8358686a3548fc
Author: Hyunsik Choi <hy...@apache.org>
Date: 2015-07-13T02:42:10Z
TAJO-1679: Client APIs should validate identifiers for database object names.
----
> Client APIs should validate identifiers for database object names
> -----------------------------------------------------------------
>
> Key: TAJO-1679
> URL: https://issues.apache.org/jira/browse/TAJO-1679
> Project: Tajo
> Issue Type: Bug
> Components: Java Client, REST API
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Fix For: 0.11.0
>
>
> When a user put database, table, column names in SQL statements, the names are automatically validated due to SQL Parser rules. But, if a users directly use client APIs, the validation is omitted. We need to add validation for API calls.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)